From a09eb9b66c240ca518cbda1af2fabf1cfac08b50 Mon Sep 17 00:00:00 2001 From: Jan Gantzert Date: Fri, 20 Dec 2019 11:33:13 +0100 Subject: [PATCH 1/2] fix usage of CacheRouteInterfaceFactory --- Model/Route/Query/GetById.php | 1 + Model/Route/Query/GetByRoute.php | 1 + Model/Route/Query/SaveRoute.php | 1 + 3 files changed, 3 insertions(+) diff --git a/Model/Route/Query/GetById.php b/Model/Route/Query/GetById.php index ebc91c2..850fb72 100644 --- a/Model/Route/Query/GetById.php +++ b/Model/Route/Query/GetById.php @@ -3,6 +3,7 @@ namespace Firegento\CacheWarmup\Model\Route\Query; use Firegento\CacheWarmup\Api\Data\CacheRouteInterface; +use Firegento\CacheWarmup\Api\Data\CacheRouteInterfaceFactory; use Magento\Framework\Api\SimpleDataObjectConverter; use Magento\Framework\App\ResourceConnection; diff --git a/Model/Route/Query/GetByRoute.php b/Model/Route/Query/GetByRoute.php index 9c1bf4d..2d2a2f3 100644 --- a/Model/Route/Query/GetByRoute.php +++ b/Model/Route/Query/GetByRoute.php @@ -3,6 +3,7 @@ namespace Firegento\CacheWarmup\Model\Route\Query; use Firegento\CacheWarmup\Api\Data\CacheRouteInterface; +use Firegento\CacheWarmup\Api\Data\CacheRouteInterfaceFactory; use Magento\Framework\Api\SimpleDataObjectConverter; use Magento\Framework\App\ResourceConnection; diff --git a/Model/Route/Query/SaveRoute.php b/Model/Route/Query/SaveRoute.php index 18e9d9f..75db53a 100644 --- a/Model/Route/Query/SaveRoute.php +++ b/Model/Route/Query/SaveRoute.php @@ -3,6 +3,7 @@ namespace Firegento\CacheWarmup\Model\Route\Query; use Firegento\CacheWarmup\Api\Data\CacheRouteInterface; +use Firegento\CacheWarmup\Api\Data\CacheRouteInterfaceFactory; use Magento\Framework\App\ResourceConnection; class SaveRoute From e5b4353c08caa07c2467fcc42265bf6e7f7bc446 Mon Sep 17 00:00:00 2001 From: Jan Gantzert Date: Wed, 8 Jan 2020 12:56:22 +0100 Subject: [PATCH 2/2] close #5 with better logging output --- Console/Command/CacheWarmup.php | 12 ++++++++---- composer.json | 2 +- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/Console/Command/CacheWarmup.php b/Console/Command/CacheWarmup.php index bc5cb29..17118df 100755 --- a/Console/Command/CacheWarmup.php +++ b/Console/Command/CacheWarmup.php @@ -2,6 +2,10 @@ namespace Firegento\CacheWarmup\Console\Command; +use GuzzleHttp\Client; +use GuzzleHttp\Exception\RequestException; +use GuzzleHttp\Pool; +use GuzzleHttp\Psr7\Response; use GuzzleHttp\RequestOptions; use League\CLImate\CLImate; use Magento\UrlRewrite\Model\ResourceModel\UrlRewriteCollection; @@ -129,11 +133,11 @@ private function getPool(Client $client, callable $requests, OutputInterface $ou { return new Pool($client, $requests(), [ 'concurrency' => $this->maxConcurrentRequests, - 'fulfilled' => function ($response, $index) use ($output) { - $output->writeln("Successful: " . $index); + 'fulfilled' => function (Response $response, $index) use ($client, $output) { + $output->writeln('Successful: ' . $index); }, - 'rejected' => function ($reason, $index) use ($output) { - $output->writeln("Rejected: " . $index); + 'rejected' => function (RequestException $reason, $index) use ($client, $output) { + $output->writeln('Rejected: ' . $reason->getRequest()->getUri()); }, ]); } diff --git a/composer.json b/composer.json index 2648eae..b6f978a 100755 --- a/composer.json +++ b/composer.json @@ -13,7 +13,7 @@ "guzzlehttp/guzzle": "~6.2" }, "type": "magento2-module", - "version": "0.1.0", + "version": "0.1.1", "autoload": { "files": [ "registration.php"