MQE-1561: CreateData action must be able to parse Data entity which references another data

- fix static check failures

Author: okolesnyk

src/Magento/FunctionalTestingFramework/DataGenerator/Objects/EntityDataObject.php

@@ -82,14 +82,14 @@ class EntityDataObject
     /**
      * Constructor
      *
-     * @param string $name
-     * @param string $type
+     * @param string   $name
+     * @param string   $type
      * @param string[] $data
      * @param string[] $linkedEntities
      * @param string[] $uniquenessData
      * @param string[] $vars
-     * @param string $parentEntity
-     * @param string $filename
+     * @param string   $parentEntity
+     * @param string   $filename
      */
     public function __construct(
         $name,
@@ -161,6 +161,7 @@ public function getAllData()
      * @param integer $uniquenessFormat
      * @return string|null
      * @throws TestFrameworkException
+     * @SuppressWarnings(PHPMD)
      */
     public function getDataByName($name, $uniquenessFormat)
     {

src/Magento/FunctionalTestingFramework/DataGenerator/Persist/OperationDataArrayResolver.php

@@ -66,8 +66,7 @@ public function __construct($dependentEntities = null)
      * @param boolean          $fromArray
      * @return array
      * @throws \Exception
-     * @SuppressWarnings(PHPMD.NPathComplexity)
-     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     * @SuppressWarnings(PHPMD)
      */
     public function resolveOperationDataArray($entityObject, $operationMetadata, $operation, $fromArray = false)
     {
@@ -124,7 +123,7 @@ public function resolveOperationDataArray($entityObject, $operationMetadata, $op
 
         $dataReferenceResolver = new RuntimeDataReferenceResolver();
         foreach ($operationDataArray as $key => $operationDataValue) {
-            if (is_array($operationDataValue)){
+            if (is_array($operationDataValue)) {
                 continue;
             }
             $operationDataArray[$key] = $dataReferenceResolver->getDataReference(

src/Magento/FunctionalTestingFramework/DataGenerator/Util/GenerationDataReferenceResolver.php

@@ -12,6 +12,37 @@
 
 class GenerationDataReferenceResolver implements DataReferenceResolverInterface
 {
+    /**
+     * @param string $data
+     * @param string $originalDataEntity
+     * @return string|null
+     * @throws TestReferenceException
+     */
+    public function getDataUniqueness(string $data, string $originalDataEntity)
+    {
+        preg_match(
+            ActionObject::ACTION_ATTRIBUTE_VARIABLE_REGEX_PATTERN,
+            $data,
+            $matches
+        );
+
+        if (empty($matches['reference'])) {
+            return null;
+        }
+
+        $strippedReference = str_replace(['{{', '}}'], '', $matches['reference']);
+        list($entity, $var) = explode('.', $strippedReference);
+        $entityObject = DataObjectHandler::getInstance()->getObject($entity);
+        if ($entityObject === null) {
+            throw new TestReferenceException(
+                "Could not resolve entity reference \"{$matches['reference']}\" "
+                . "in Data entity \"{$originalDataEntity}\""
+            );
+        }
+
+        return $entityObject->getUniquenessDataByName($var);
+    }
+
     /**
      * @param string $data
      * @param string $originalDataEntity
@@ -48,35 +79,4 @@ public function getDataReference(string $data, string $originalDataEntity)
 
         return $result;
     }
-
-    /**
-     * @param string $data
-     * @param string $originalDataEntity
-     * @return string|null
-     * @throws TestReferenceException
-     */
-    public function getDataUniqueness(string $data, string $originalDataEntity)
-    {
-        preg_match(ActionObject::ACTION_ATTRIBUTE_VARIABLE_REGEX_PATTERN,
-            $data,
-            $matches
-        );
-
-        if (empty($matches['reference'])) {
-            return null;
-        }
-
-        $strippedReference = str_replace(['{{', '}}'], '', $matches['reference']);
-        list($entity, $var) = explode('.', $strippedReference);
-        $entityObject = DataObjectHandler::getInstance()->getObject($entity);
-        if ($entityObject === null) {
-            throw new TestReferenceException(
-                "Could not resolve entity reference \"{$matches['reference']}\" "
-                . "in Data entity \"{$originalDataEntity}\""
-            );
-
-        }
-
-        return $entityObject->getUniquenessDataByName($var);
-    }
 }

src/Magento/FunctionalTestingFramework/DataGenerator/Util/RuntimeDataReferenceResolver.php

@@ -63,7 +63,8 @@ public function getDataReference(string $data, string $originalDataEntity)
      */
     public function getDataUniqueness(string $data, string $originalDataEntity)
     {
-        preg_match(ActionObject::ACTION_ATTRIBUTE_VARIABLE_REGEX_PATTERN,
+        preg_match(
+            ActionObject::ACTION_ATTRIBUTE_VARIABLE_REGEX_PATTERN,
             $data,
             $matches
         );
@@ -80,7 +81,6 @@ public function getDataUniqueness(string $data, string $originalDataEntity)
                 "Could not resolve entity reference \"{$matches['reference']}\" "
                 . "in Data entity \"{$originalDataEntity}\""
             );
-
         }
 
         return $entityObject->getUniquenessDataByName($var);