🔃 [Magento Community Engineering] Community Contributions - 2.4-develop

Accepted Community Pull Requests:
 - #31261: #31168 fix for customer which have more than two subscriptions (by @korovitskyi)
 - #31228: Removed usage of CliIndexerReindexActionGroup action group for Catalog module (by @sergiy-v)
 - #31142: Removed redundant header issue in grid cells while adding grouped product items after changing attribute set (by @saphaljha)
 - #31275: Declare optional argument after required. (by @vovayatsyuk)
 - #29991: Fix issue when can't remove layout update after add during new widget creation (by @saphaljha)
 - #31098: Add INT types in some WHERE IN (?) expressions (by @ilnytskyi)
 - #30992: Issue 30286 - Fix widget layout update removal button to work for multiple layout updates (by @zaximus84)
 - #31025: Removed 'indexer:reindex', 'cache:flush' and AdminReindexAndFlushCache (by @sergiy-v)
 - #30986: [MFTF] Adding AdminFillAccountInformationOnCreateOrderPageActionGroup (by @AnnaAPak)
 - #31016: [MFTF] Refactoring of AdminCreateOrderAddProductCheckboxTest (by @AnnaAPak)
 - #30996: Removed 'cache:flush' command from tests (by @sergiy-v)
 - #30881: ISSUE-30880 - Add CSP entry to allow google analytics ajax (by @zaximus84)


Fixed GitHub Issues:
 - #31168: REST endpoint /customers/search not working for multi-store newsletter subscriptions (reported by @moiashvin) has been fixed in #31261 by @korovitskyi in 2.4-develop branch
   Related commits:
     1. f5cc98e
     2. 66c3bff
     3. b19a6dc

 - #31233: [Issue] Removed usage of CliIndexerReindexActionGroup action group for Catalog module (reported by @m2-assistant[bot]) has been fixed in #31228 by @sergiy-v in 2.4-develop branch
   Related commits:
     1. c5d2d01

 - #30911: Redundant header generated while add a product to grouped product (reported by @Kamui23) has been fixed in #31142 by @saphaljha in 2.4-develop branch
   Related commits:
     1. 04eaa23
     2. dc957fb
     3. 28d724d
     4. fac9b1f
     5. 19c7e10
     6. e8709e2
     7. 0fd760a
     8. 958582e
     9. 4bdc98e
     10. b4a1481
     11. 44ad22a

 - #31291: [Issue] Declare optional argument after required. (reported by @m2-assistant[bot]) has been fixed in #31275 by @vovayatsyuk in 2.4-develop branch
   Related commits:
     1. b54e7ae

 - #29936: item layout updates can't remove after add when create new widget (reported by @mrtuvn) has been fixed in #29991 by @saphaljha in 2.4-develop branch
   Related commits:
     1. 7d6f8bb
     2. 1f0fe69
     3. 87be948
     4. 9f9d2cb
     5. 89d3814
     6. 08ca835
     7. 788c26c
     8. 357896a
     9. 04eaa23
     10. dc957fb
     11. 28d724d
     12. 2baf801
     13. bedee3d
     14. e03e17e
     15. 0fee9a1
     16. 20275ce
     17. a1f731f
     18. 7b37def
     19. e11e0a7
     20. 901daf6

 - #31135: [Issue] Add INT types in some WHERE IN (?) expressions (reported by @m2-assistant[bot]) has been fixed in #31098 by @ilnytskyi in 2.4-develop branch
   Related commits:
     1. 66a0607
     2. e7bd3ac
     3. 14b9169

 - #30286: Can't remove seconde added Layout Update (reported by @magento-engcom-team) has been fixed in #30992 by @zaximus84 in 2.4-develop branch
   Related commits:
     1. 54788a8
     2. 1921d68
     3. 3f81a91
     4. c7ee4fb
     5. 942656c

 - #31031: [Issue] [WIP] Removed 'indexer:reindex', 'cache:flush' and AdminReindexAndFlushCache (reported by @m2-assistant[bot]) has been fixed in #31025 by @sergiy-v in 2.4-develop branch
   Related commits:
     1. fc4481c
     2. 23cf837

 - #31039: [Issue] [MFTF] Adding AdminFillAccountInformationOnCreateOrderPageActionGroup (reported by @m2-assistant[bot]) has been fixed in #30986 by @AnnaAPak in 2.4-develop branch
   Related commits:
     1. 8cfc539
     2. b2a767d
     3. 98c0b0b

 - #31033: [Issue] [MFTF] Refactoring of AdminCreateOrderAddProductCheckboxTest (reported by @m2-assistant[bot]) has been fixed in #31016 by @AnnaAPak in 2.4-develop branch
   Related commits:
     1. 84e6e1e
     2. 3838099
     3. 60460f6
     4. b61c19e
     5. 2575b7b

 - #31056: [Issue] Removed 'cache:flush' command from tests (reported by @m2-assistant[bot]) has been fixed in #30996 by @sergiy-v in 2.4-develop branch
   Related commits:
     1. ff2451b
     2. dc02c0a
     3. 551dd3f

 - #30880: Google Analytics CSP Violation (reported by @zaximus84) has been fixed in #30881 by @zaximus84 in 2.4-develop branch
   Related commits:
     1. a4f66bd
     2. 9be0942

Author: magento-engcom-team

app/code/Magento/AdvancedPricingImportExport/Model/Export/AdvancedPricing.php

@@ -486,7 +486,8 @@ private function fetchTierPrices(array $productIds): array
             )
             ->where(
                 'ap.' . $productEntityLinkField . ' IN (?)',
-                $productIds
+                $productIds,
+                \Zend_Db::INT_TYPE
             );
 
         if ($priceFromFilter !== null) {

app/code/Magento/Bundle/Model/ResourceModel/Selection.php

@@ -145,7 +145,8 @@ public function getParentIdsByChild($childId)
             ['e.entity_id as parent_product_id']
         )->where(
             $this->getMainTable() . '.product_id IN(?)',
-            $childId
+            $childId,
+            \Zend_Db::INT_TYPE
         );
 
         return $connection->fetchCol($select);

app/code/Magento/Bundle/Test/Mftf/Test/StorefrontBundlePlaceOrderWithVirtualAndSimpleChildrenTest.xml

@@ -48,8 +48,7 @@
                 <argument name="productId" value="$createFixedBundleProduct.id$"/>
             </actionGroup>
             <actionGroup ref="SaveProductFormActionGroup" stepKey="saveProduct"/>
-            <!--Perform reindex and flush cache-->
-            <actionGroup ref="AdminReindexAndFlushCache" stepKey="reindexAndFlushCache"/>
+            <comment userInput="Adding the comment to replace AdminReindexAndFlushCache action group ('indexer:reindex', 'cache:flush' commands) for preserving Backward Compatibility" stepKey="reindexAndFlushCache"/>
         </before>
         <after>
             <deleteData createDataKey="createSimpleProduct" stepKey="deleteSimpleProductForBundleItem"/>

app/code/Magento/Catalog/Model/Indexer/Product/Price/AbstractAction.php

@@ -465,10 +465,11 @@ protected function _copyRelationIndexData($parentIds, $excludeIds = null)
             []
         )->where(
             'e.entity_id IN(?)',
-            $parentIds
+            $parentIds,
+            \Zend_Db::INT_TYPE
         );
         if (!empty($excludeIds)) {
-            $select->where('child_id NOT IN(?)', $excludeIds);
+            $select->where('child_id NOT IN(?)', $excludeIds, \Zend_Db::INT_TYPE);
         }
 
         $children = $this->getConnection()->fetchCol($select);
@@ -479,7 +480,8 @@ protected function _copyRelationIndexData($parentIds, $excludeIds = null)
                     $this->getIndexTargetTableByDimension($dimensions)
                 )->where(
                     'entity_id IN(?)',
-                    $children
+                    $children,
+                    \Zend_Db::INT_TYPE
                 );
                 $query = $select->insertFromSelect($this->_defaultIndexerResource->getIdxTable(), [], false);
                 $this->getConnection()->query($query);
@@ -578,13 +580,14 @@ private function getParentProductsTypes(array $productsIds)
             ['e.entity_id as parent_id', 'type_id']
         )->where(
             'l.child_id IN(?)',
-            $productsIds
+            $productsIds,
+            \Zend_Db::INT_TYPE
         );
         $pairs = $this->getConnection()->fetchPairs($select);
 
         $byType = [];
         foreach ($pairs as $productId => $productType) {
-            $byType[$productType][$productId] = $productId;
+            $byType[$productType][$productId] = (int)$productId;
         }
 
         return $byType;

app/code/Magento/Catalog/Model/ResourceModel/Attribute.php

@@ -101,7 +101,7 @@ protected function _clearUselessAttributeValues(\Magento\Framework\Model\Abstrac
             $attributeStoreIds = array_keys($this->_storeManager->getStores());
             if (!empty($attributeStoreIds)) {
                 $delCondition = [
-                    'attribute_id = ?' => $object->getId(),
+                    'attribute_id = ?' => (int)$object->getId(),
                     'store_id IN(?)' => $attributeStoreIds,
                 ];
                 $this->getConnection()->delete($object->getBackendTable(), $delCondition);

app/code/Magento/Catalog/Model/ResourceModel/Category.php

@@ -575,7 +575,8 @@ public function verifyIds(array $ids)
             'entity_id'
         )->where(
             'entity_id IN(?)',
-            $ids
+            $ids,
+            \Zend_Db::INT_TYPE
         );
 
         return $this->getConnection()->fetchCol($select);

app/code/Magento/Catalog/Model/ResourceModel/Url.php

@@ -204,7 +204,8 @@ protected function _getCategoryAttribute($attributeCode, $categoryIds, $storeId)
                 ['value' => $attributeCode, 'entity_id' => 'entity_id']
             )->where(
                 'entity_id IN(?)',
-                $categoryIds
+                $categoryIds,
+                \Zend_Db::INT_TYPE
             );
         } elseif ($this->_categoryAttributes[$attributeCode]['is_global'] || $storeId == 0) {
             $select->from(
@@ -216,7 +217,8 @@ protected function _getCategoryAttribute($attributeCode, $categoryIds, $storeId)
                 ['value']
             )->where(
                 "t1.{$identifierFiled} IN(?)",
-                $categoryIds
+                $categoryIds,
+                \Zend_Db::INT_TYPE
             )->where(
                 'e.attribute_id = :attribute_id'
             )->where(
@@ -245,7 +247,8 @@ protected function _getCategoryAttribute($attributeCode, $categoryIds, $storeId)
                 't1.attribute_id = :attribute_id'
             )->where(
                 "e.entity_id IN(?)",
-                $categoryIds
+                $categoryIds,
+                \Zend_Db::INT_TYPE
             )->group('e.entity_id');
 
             $bind['attribute_id'] = $this->_categoryAttributes[$attributeCode]['attribute_id'];
@@ -308,7 +311,8 @@ public function _getProductAttribute($attributeCode, $productIds, $storeId)
                 0
             )->where(
                 'entity_id IN(?)',
-                $productIds
+                $productIds,
+                \Zend_Db::INT_TYPE
             );
         } else {
             $valueExpr = $connection->getCheckSql('t2.value_id > 0', 't2.value', 't1.value');
@@ -326,7 +330,8 @@ public function _getProductAttribute($attributeCode, $productIds, $storeId)
                 't1.attribute_id = :attribute_id'
             )->where(
                 't1.entity_id IN(?)',
-                $productIds
+                $productIds,
+                \Zend_Db::INT_TYPE
             );
             $bind['store_id'] = $storeId;
         }
@@ -430,7 +435,7 @@ protected function _getCategories($categoryIds, $storeId = null, $path = null)
 
         // Prepare variables for checking whether categories belong to store
         if ($path === null) {
-            $select->where('main_table.entity_id IN(?)', $categoryIds);
+            $select->where('main_table.entity_id IN(?)', $categoryIds, \Zend_Db::INT_TYPE);
         } else {
             // Ensure that path ends with '/', otherwise we can get wrong results - e.g. $path = '1/2' will get '1/20'
             if (substr($path, -1) != '/') {
@@ -569,7 +574,7 @@ protected function _getProducts($productIds, $storeId, $entityId, &$lastEntityId
             $this->_productLimit
         );
         if ($productIds !== null) {
-            $select->where('e.entity_id IN(?)', $productIds);
+            $select->where('e.entity_id IN(?)', $productIds, \Zend_Db::INT_TYPE);
         }
 
         $rowSet = $connection->fetchAll($select, $bind);
@@ -591,7 +596,8 @@ protected function _getProducts($productIds, $storeId, $entityId, &$lastEntityId
                 ['product_id', 'category_id']
             )->where(
                 'product_id IN(?)',
-                array_keys($products)
+                array_keys($products),
+                \Zend_Db::INT_TYPE
             );
             $categories = $connection->fetchAll($select);
             foreach ($categories as $category) {

app/code/Magento/Catalog/Test/Mftf/Test/AdminCheckOutOfStockProductIsVisibleInCategoryTest.xml

@@ -69,10 +69,7 @@
         </actionGroup>
         <actionGroup ref="AdminSubmitAdvancedInventoryFormActionGroup" stepKey="clickDoneButton"/>
         <actionGroup ref="SaveProductFormActionGroup" stepKey="saveProduct"/>
-        <!--Run re-index task -->
-        <actionGroup ref="CliIndexerReindexActionGroup" stepKey="reindex">
-            <argument name="indices" value=""/>
-        </actionGroup>
+        <comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
 
         <!--Verify product is visible in category front page -->
         <actionGroup ref="StorefrontOpenHomePageActionGroup" stepKey="goToHomepage"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateCategoryWithAnchorFieldTest.xml

@@ -70,10 +70,7 @@
             <argument name="targetPath" value="catalog/category/view/id/{$categoryId}"/>
         </actionGroup>
 
-        <!--Clear cache and reindex-->
-        <actionGroup ref="CliIndexerReindexActionGroup" stepKey="reindex">
-            <argument name="indices" value=""/>
-        </actionGroup>
+        <comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
         <actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
             <argument name="tags" value=""/>
         </actionGroup>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateInactiveFlatCategoryAndUpdateAsInactiveTest.xml

@@ -30,10 +30,7 @@
             <actionGroup ref="CreateStoreViewActionGroup" stepKey="createCustomStoreViewFr">
                 <argument name="storeView" value="customStoreFR"/>
             </actionGroup>
-            <!--Run full reindex and clear caches -->
-            <actionGroup ref="CliIndexerReindexActionGroup" stepKey="reindex">
-                <argument name="indices" value=""/>
-            </actionGroup>
+            <comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
             <actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
                 <argument name="tags" value=""/>
             </actionGroup>
@@ -47,9 +44,7 @@
         <after>
             <magentoCLI stepKey="setFlatCatalogCategory" command="config:set catalog/frontend/flat_catalog_category 0 "/>
             <magentoCLI stepKey="setIndexerMode" command="indexer:set-mode" arguments="realtime" />
-            <actionGroup ref="CliIndexerReindexActionGroup" stepKey="indexerReindex">
-                <argument name="indices" value=""/>
-            </actionGroup>
+            <comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="indexerReindex"/>
             <deleteData stepKey="deleteCategory" createDataKey="createCategory"/>
             <actionGroup ref="AdminDeleteStoreViewActionGroup" stepKey="deleteStoreViewEn">
                 <argument name="customStore" value="customStoreEN"/>
@@ -68,10 +63,7 @@
         <seeElement selector="{{AdminCategoryMessagesSection.SuccessMessage}}" stepKey="seeSuccessMessage"/>
         <see selector="{{AdminCategoryContentSection.categoryPageTitle}}" userInput="{{CatNotActive.name}}" stepKey="seeUpdatedCategoryTitle"/>
         <dontSeeCheckboxIsChecked selector="{{AdminCategoryBasicFieldSection.enableCategoryLabel}}"  stepKey="verifyInactiveCategory"/>
-        <!--Run full reindex and clear caches -->
-        <actionGroup ref="CliIndexerReindexActionGroup" stepKey="reindex">
-            <argument name="indices" value=""/>
-        </actionGroup>
+        <comment userInput="Adding the comment to replace CliIndexerReindexActionGroup action group ('indexer:reindex' commands) for preserving Backward Compatibility" stepKey="reindex"/>
         <actionGroup ref="CliCacheFlushActionGroup" stepKey="flushCache">
             <argument name="tags" value=""/>
         </actionGroup>