ACPT-1929

Cache result of isObjectInClassList because now that its time is O(n)
when search for matching classes, when same class is checked twice, it can be
O(1) instead when using the cache

Author: JacobBrownAustin

lib/internal/Magento/Framework/ObjectManager/Resetter/Resetter.php

@@ -31,11 +31,15 @@ class Resetter implements ResetterInterface
     /** @var WeakMapSorter|null Note: We use temporal coupling here because of chicken/egg during bootstrapping */
     private ?WeakMapSorter $weakMapSorter = null;
 
-    /**
-     * @var array
-     */
+    /** @var array */
     private array $reflectionCache = [];
 
+    /** @var array */
+    private array $isObjectInClassListCache = [];
+
+    /** @var array */
+    private readonly array $classList;
+
     /**
      * @param ComponentRegistrarInterface|null $componentRegistrar
      * @param array $classList
@@ -44,7 +48,7 @@ class Resetter implements ResetterInterface
      */
     public function __construct(
         private ?ComponentRegistrarInterface $componentRegistrar = null,
-        private array $classList = [],
+        array $classList = [],
     ) {
         if (null === $this->componentRegistrar) {
             $this->componentRegistrar = new ComponentRegistrar();
@@ -57,8 +61,9 @@ public function __construct(
             if (!$resetData) {
                 throw new LocalizedException(__('Error parsing %1', $resetPath));
             }
-            $this->classList += $resetData;
+            $classList += $resetData;
         }
+        $this->classList = $classList;
         $this->resetAfterWeakMap = new WeakMap;
     }
 
@@ -138,11 +143,18 @@ public function setObjectManager(ObjectManagerInterface $objectManager) : void
      */
     public function isObjectInClassList(object $object)
     {
+        $className = \get_class($object);
+        $isObjectInClassListCachedValue = $this->isObjectInClassListCache[$className] ?? null;
+        if (null !== $isObjectInClassListCachedValue) {
+            return $isObjectInClassListCachedValue;
+        }
         foreach ($this->classList as $key => $value) {
             if ($object instanceof $key) {
+                $this->isObjectInClassListCache[$className] = true;
                 return true;
             }
         }
+        $this->isObjectInClassListCache[$className] = false;
         return false;
     }