AC-1271: Add rate limiting for payment information endpoint and mutation

Author: arhiopterecs

app/code/Magento/Quote/Model/Backpressure/Config/PeriodValue.php

@@ -60,8 +60,14 @@ public function beforeSave()
     {
         if ($this->isValueChanged()) {
             $value = (string)$this->getValue();
-            if (!array_key_exists($value, $this->source->toOptionArray())) {
-                throw new LocalizedException(__('Please select a valid rate limit period'));
+            $availableValues = $this->source->toOptionArray();
+            if (!array_key_exists($value, $availableValues)) {
+                throw new LocalizedException(
+                    __(
+                        'Please select a valid speed limit period in seconds: %1',
+                        implode(', ', array_keys($availableValues))
+                    )
+                );
             }
         }
 

app/code/Magento/Quote/i18n/en_US.csv

@@ -70,6 +70,6 @@ Carts,Carts
 "Validated Vat Number","Validated Vat Number"
 "Invalid Quote Item id %1","Invalid Quote Item id %1"
 "Number above 0 is required for the limit","Number above 0 is required for the limit"
-"Please select a valid rate limit period","Please select a valid rate limit period"
+"Please select a valid speed limit period in seconds: %1.","Please select a valid speed limit period in seconds: %1."
 "Identity type not found","Identity type not found"
 "Invalid order backpressure limit config","Invalid order backpressure limit config"

app/code/Magento/Webapi/Controller/Rest/RequestValidator.php

@@ -145,7 +145,11 @@ private function checkBackpressure(Route $route)
             try {
                 $this->backpressureEnforcer->enforce($context);
             } catch (BackpressureExceededException $exception) {
-                throw new WebapiException(__('Something went wrong, please try again later'));
+                throw new WebapiException(
+                    __('Something went wrong, please try again later'),
+                    0,
+                    WebapiException::HTTP_TOO_MANY_REQUESTS
+                );
             }
         }
     }

app/code/Magento/Webapi/Controller/Soap/Request/Handler.php

@@ -299,7 +299,11 @@ private function backpressureEnforcement(string $class, string $method, string $
             try {
                 $this->backpressureEnforcer->enforce($context);
             } catch (BackpressureExceededException $exception) {
-                throw new WebapiException(__('Something went wrong, please try again later'));
+                throw new WebapiException(
+                    __('Something went wrong, please try again later'),
+                    0,
+                    WebapiException::HTTP_TOO_MANY_REQUESTS
+                );
             }
         }
     }

lib/internal/Magento/Framework/Webapi/Exception.php

@@ -27,27 +27,29 @@ class Exception extends LocalizedException
     /**#@+
      * Error HTTP response codes.
      */
-    const HTTP_BAD_REQUEST = 400;
+    public const HTTP_BAD_REQUEST = 400;
 
-    const HTTP_UNAUTHORIZED = 401;
+    public const HTTP_UNAUTHORIZED = 401;
 
-    const HTTP_FORBIDDEN = 403;
+    public const HTTP_FORBIDDEN = 403;
 
-    const HTTP_NOT_FOUND = 404;
+    public const HTTP_NOT_FOUND = 404;
 
-    const HTTP_METHOD_NOT_ALLOWED = 405;
+    public const HTTP_METHOD_NOT_ALLOWED = 405;
 
-    const HTTP_NOT_ACCEPTABLE = 406;
+    public const HTTP_NOT_ACCEPTABLE = 406;
 
-    const HTTP_INTERNAL_ERROR = 500;
+    public const HTTP_TOO_MANY_REQUESTS = 429;
+
+    public const HTTP_INTERNAL_ERROR = 500;
 
     /**#@-*/
 
     /**#@+
      * Fault codes that are used in SOAP faults.
      */
-    const FAULT_CODE_SENDER = 'Sender';
-    const FAULT_CODE_RECEIVER = 'Receiver';
+    public const FAULT_CODE_SENDER = 'Sender';
+    public const FAULT_CODE_RECEIVER = 'Receiver';
 
     /**
      * Optional exception details.
@@ -71,8 +73,6 @@ class Exception extends LocalizedException
     protected $_name;
 
     /**
-     * Stacktrace
-     *
      * @var string
      */
     protected $_stackTrace;