Skip to content

Commit 74b50ac

Browse files
magento-engcom-teammagento-engcom-team
committed
ENGCOM-7737: Refactoring admin update category url key with store view test #28661
- Merge Pull Request #28661 from kate-kyzyma/magento2:Refactoring-AdminUpdateCategoryUrlKeyWithStoreViewTest - Merged commits: 1. 247c1be 2. f292071 3. 8293d87
2 parents cb1719f + 8293d87 commit 74b50ac

File tree

2 files changed

+52
-32
lines changed

2 files changed

+52
-32
lines changed

‎app/code/Magento/Catalog/Test/Mftf/ActionGroup/StorefrontAssertProperUrlIsShownActionGroup.xml‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="StorefrontAssertProperUrlIsShownActionGroup">
12+
<annotations>
13+
<description>Validate that the URL path is correct</description>
14+
</annotations>
15+
<arguments>
16+
<argument name="urlPath" type="string"/>
17+
</arguments>
18+
19+
<seeInCurrentUrl url="{{urlPath}}" stepKey="checkUrl"/>
20+
</actionGroup>
21+
</actionGroups>

‎app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateCategoryUrlKeyWithStoreViewTest.xml‎

Lines changed: 31 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,12 @@
3232
<actionGroup ref="AdminLogoutActionGroup" stepKey="logout"/>
3333
</after>
3434

35-
<!--Open Store Page -->
36-
<amOnPage url="{{AdminSystemStorePage.url}}" stepKey="amOnAdminSystemStorePage"/>
37-
<waitForPageLoad stepKey="waitForSystemStorePage"/>
38-
3935
<!--Create Custom Store -->
40-
<click selector="{{AdminStoresMainActionsSection.createStoreButton}}" stepKey="selectCreateStore"/>
41-
<fillField userInput="{{customStore.name}}" selector="{{AdminNewStoreGroupSection.storeGrpNameTextField}}" stepKey="fillStoreName"/>
42-
<fillField userInput="{{customStore.code}}" selector="{{AdminNewStoreGroupSection.storeGrpCodeTextField}}" stepKey="fillStoreCode"/>
43-
<selectOption userInput="{{NewRootCategory.name}}" selector="{{AdminNewStoreGroupSection.storeRootCategoryDropdown}}" stepKey="selectStoreStatus"/>
44-
<click selector="{{AdminStoresMainActionsSection.saveButton}}" stepKey="clickSaveStoreButton"/>
36+
<actionGroup ref="CreateCustomStoreActionGroup" stepKey="createCustomStore">
37+
<argument name="website" value="{{_defaultWebsite.name}}"/>
38+
<argument name="store" value="{{customStore.name}}"/>
39+
<argument name="rootCategory" value="$$rootCategory.name$$"/>
40+
</actionGroup>
4541

4642
<!--Create Store View-->
4743
<actionGroup ref="AdminCreateStoreViewActionGroup" stepKey="createStoreView">
@@ -50,34 +46,37 @@
5046
</actionGroup>
5147

5248
<!--Verify Category in Store View-->
53-
<amOnPage url="/{{NewRootCategory.name}}/{{SimpleRootSubCategory.name}}.html" stepKey="seeTheCategoryInStoreFront"/>
54-
<waitForPageLoad stepKey="waitForSystemStorePage1"/>
55-
<click selector="{{StorefrontFooterSection.switchStoreButton}}" stepKey="ClickSwitchStoreButtonOnDefaultStore"/>
56-
<click selector="{{StorefrontFooterSection.storeLink(customStore.name)}}" stepKey="SelectSecondStoreToSwitchOn"/>
57-
<seeElement selector="{{StorefrontHeaderSection.NavigationCategoryByName(SimpleRootSubCategory.name)}}" stepKey="seeCatergoryInStoreFront"/>
58-
<click selector="{{StorefrontHeaderSection.NavigationCategoryByName(SimpleRootSubCategory.name)}}" stepKey="selectCategory"/>
59-
<waitForPageLoad stepKey="waitForProductToLoad"/>
49+
<actionGroup ref="StorefrontOpenHomePageActionGroup" stepKey="goToHomepage"/>
50+
<actionGroup ref="StorefrontSwitchStoreActionGroup" stepKey="switchToCustomStore">
51+
<argument name="storeName" value="{{customStore.name}}"/>
52+
</actionGroup>
53+
<actionGroup ref="StorefrontAssertCategoryNameIsShownInMenuActionGroup" stepKey="seeCatergoryInStoreFront">
54+
<argument name="categoryName" value="{{SimpleRootSubCategory.name}}"/>
55+
</actionGroup>
56+
<actionGroup ref="StorefrontGoToCategoryPageActionGroup" stepKey="selectCategory">
57+
<argument name="categoryName" value="$$category.name$$"/>
58+
</actionGroup>
6059

6160
<!--Update URL Key-->
62-
<actionGroup ref="AdminOpenCategoryPageActionGroup" stepKey="openAdminCategoryIndexPage"/>
63-
<click selector="{{AdminCategorySidebarTreeSection.expandAll}}" stepKey="clickOnExpandTree"/>
64-
<click selector="{{AdminCategorySidebarTreeSection.categoryInTree(SimpleRootSubCategory.name)}}" stepKey="selectCategory1"/>
65-
<scrollTo selector="{{AdminCategorySEOSection.SectionHeader}}" stepKey="scrollToSearchEngineOptimization"/>
66-
<click selector="{{AdminCategorySEOSection.SectionHeader}}" stepKey="openSeoSection"/>
67-
<clearField selector="{{AdminCategorySEOSection.UrlKeyInput}}" stepKey="clearUrlKeyField"/>
68-
<fillField selector="{{AdminCategorySEOSection.UrlKeyInput}}" userInput="newurlkey" stepKey="enterURLKey"/>
69-
<click selector="{{AdminCategoryMainActionsSection.SaveButton}}" stepKey="saveCategoryAfterFirstSeoUpdate"/>
70-
<seeElement selector="{{AdminCategoryMessagesSection.SuccessMessage}}" stepKey="assertSuccessMessage"/>
71-
<waitForPageLoad stepKey="waitForPageToLoad"/>
61+
<actionGroup ref="NavigateToCreatedCategoryActionGroup" stepKey="openCreatedSubCategory">
62+
<argument name="Category" value="$$category$$"/>
63+
</actionGroup>
64+
<actionGroup ref="ChangeSeoUrlKeyActionGroup" stepKey="changeSeoUrlKey">
65+
<argument name="value" value="newurlkey"/>
66+
</actionGroup>
7267

7368
<!--Open Category Store Front Page-->
74-
<amOnPage url="/{{NewRootCategory.name}}/{{SimpleRootSubCategory.name}}.html" stepKey="seeTheCategoryInStoreFront1"/>
75-
<waitForPageLoad stepKey="waitForSystemStorePage3"/>
76-
<seeElement selector="{{StorefrontHeaderSection.NavigationCategoryByName(SimpleRootSubCategory.name)}}" stepKey="seeCategoryOnNavigation1"/>
77-
<click selector="{{StorefrontHeaderSection.NavigationCategoryByName(SimpleRootSubCategory.name)}}" stepKey="selectCategory2"/>
78-
<waitForPageLoad stepKey="waitForProductToLoad1"/>
69+
<actionGroup ref="StorefrontOpenHomePageActionGroup" stepKey="openHomepage"/>
70+
<actionGroup ref="StorefrontAssertCategoryNameIsShownInMenuActionGroup" stepKey="seeCatergoryNameInStoreFront">
71+
<argument name="categoryName" value="{{SimpleRootSubCategory.name}}"/>
72+
</actionGroup>
73+
<actionGroup ref="StorefrontGoToCategoryPageActionGroup" stepKey="openCategory">
74+
<argument name="categoryName" value="{{SimpleRootSubCategory.name}}"/>
75+
</actionGroup>
7976

8077
<!--Verify Updated URLKey is present-->
81-
<seeInCurrentUrl stepKey="verifyUpdatedUrlKey" url="newurlkey.html"/>
78+
<actionGroup ref="StorefrontAssertProperUrlIsShownActionGroup" stepKey="seeUpdatedUrlkey">
79+
<argument name="urlPath" value="newurlkey.html"/>
80+
</actionGroup>
8281
</test>
8382
</tests>

0 commit comments

Comments
 (0)