ACP2E-3660: REST endpoint Product Import Json not validate the mandatory fields

Author: aplapana

app/code/Magento/CatalogImportExport/Model/Import/Product/Type/AbstractType.php

@@ -583,7 +583,7 @@ public function isRowValid(array $rowData, $rowNum, $isNewProduct = true)
                     // For the default scope - if this is a new product or
                     // for an old product, if the imported doc has the column present for the attrCode
                     if (Product::SCOPE_DEFAULT == $rowScope &&
-                        ($isNewProduct || !in_array($attrCode,self::NON_REQUIRED_ATTRIBUTES_EXISTING_PRODUCTS)) &&
+                        ($isNewProduct || !in_array($attrCode, self::NON_REQUIRED_ATTRIBUTES_EXISTING_PRODUCTS)) &&
                         array_key_exists($attrCode, $rowData)
                     ) {
                         $this->_entityModel->addRowError(

app/code/Magento/CatalogImportExport/Model/Import/Product/Validator.php

@@ -382,9 +382,8 @@ public function getInvalidAttribute()
      * Is valid attributes
      *
      * @return array
-     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
      */
-    protected function isValidAttributes(): array
+    protected function isValidAttributes()
     {
         $this->_clearMessages();
         $this->setInvalidAttribute(null);
@@ -441,7 +440,7 @@ public function isValid($value)
             }
         }
 
-        return !in_array(false, array_values($validatedAttributes['attributes']));
+        return count($this->_messages) == 0;
     }
 
     /**
@@ -458,16 +457,6 @@ public function getRowScope(array $rowData)
         return Product::SCOPE_STORE;
     }
 
-    private function getValidatorFields(): array
-    {
-        $validatorFields = [];
-        /** @var Product\Validator\AbstractImportValidator $validator */
-        foreach($this->validators as $validator) {
-            $validatorFields[] = $validator->getFieldName();
-        }
-        return $validatorFields;
-    }
-
     /**
      * Validate category names
      *

app/code/Magento/CatalogImportExport/Model/Import/Product/Validator/AbstractImportValidator.php

@@ -21,8 +21,7 @@ abstract class AbstractImportValidator extends AbstractValidator implements RowV
     protected $context;
 
     /**
-     * @param \Magento\CatalogImportExport\Model\Import\Product $context
-     * @return $this
+     * @inheritDoc
      */
     public function init($context)
     {
@@ -31,6 +30,8 @@ public function init($context)
     }
 
     /**
+     * Get validating field name
+     *
      * @return string|null
      */
     public function getFieldName(): ?string

app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Type/AbstractTypeTest.php

@@ -331,7 +331,8 @@ public function testIsRowValidError()
     {
         $rowData = [
             '_attribute_set' => 'attribute_set_name',
-            'sku' => 'sku'
+            'sku' => 'sku',
+            'attr_code' => 'test'
         ];
         $rowNum = 1;
         $this->entityModel->method('getRowScope')