PWA-1558: Include test coverages from the deprecated url resolver

 - add test coverage from deprecated query

Author: cspruiell

dev/tests/api-functional/testsuite/Magento/GraphQl/CatalogUrlRewrite/RouteTest.php

@@ -8,6 +8,8 @@
 namespace Magento\GraphQl\CatalogUrlRewrite;
 
 use Magento\Catalog\Api\ProductRepositoryInterface;
+use Magento\Framework\GraphQl\Exception\GraphQlInputException;
+use Magento\Framework\GraphQl\Query\Uid;
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\TestFramework\ObjectManager;
 use Magento\TestFramework\TestCase\GraphQlAbstract;
@@ -22,12 +24,16 @@ class RouteTest extends GraphQlAbstract
     /** @var ObjectManager */
     private $objectManager;
 
+    /** @var Uid */
+    private $idDecoder;
+
     /**
      * {@inheritdoc}
      */
     protected function setUp(): void
     {
         $this->objectManager = Bootstrap::getObjectManager();
+        $this->idDecoder = $this->objectManager->get(Uid::class);
     }
 
     /**
@@ -115,7 +121,7 @@ public function testProductUrlWithNonSeoFriendlyUrlInput()
                 'store_id' => $storeId
             ]
         );
-        // even of non seo friendly path requested, the seo friendly path should be preferred
+        // even if non seo friendly path requested, the seo friendly path should be preferred
         $relativePath = $actualUrls->getRequestPath();
         $expectedType = $actualUrls->getEntityType();
         $nonSeoFriendlyPath = $actualUrls->getTargetPath();
@@ -481,6 +487,7 @@ public function testProductUrlResolverWithEmptyUrlSuffix()
      * @param string $relativePath
      * @param string $expectedType
      * @param int $redirectCode
+     * @throws GraphQlInputException
      */
     private function queryUrlAndAssertResponse(
         int $productId,
@@ -494,14 +501,25 @@ private function queryUrlAndAssertResponse(
 {
   route(url:"{$urlKey}")
   {
-   relative_url
-   type
-   redirect_code
-  }
+       relative_url
+       type
+       redirect_code
+       __typename
+         ...on SimpleProduct {
+          uid
+        }
+         ...on ConfigurableProduct {
+          uid
+        }
+        ...on CategoryTree {
+            uid
+        }
+    }
 }
 QUERY;
         $response = $this->graphQlQuery($query);
         $this->assertArrayHasKey('route', $response);
+        $this->assertEquals($productId, $this->idDecoder->decode($response['route']['uid']));
         $this->assertEquals($relativePath, $response['route']['relative_url']);
         $this->assertEquals(strtoupper($expectedType), $response['route']['type']);
         $this->assertEquals($redirectCode, $response['route']['redirect_code']);

dev/tests/api-functional/testsuite/Magento/GraphQl/CmsUrlRewrite/RouteTest.php

@@ -52,13 +52,15 @@ public function testCMSPageUrlResolver()
         $this->assertEquals($requestPath, $response['route']['relative_url']);
         $this->assertEquals(strtoupper(str_replace('-', '_', $expectedEntityType)), $response['route']['type']);
         $this->assertEquals(0, $response['route']['redirect_code']);
+        $this->assertEquals($page->getIdentifier(), $response['route']['identifier']);
 
         // querying by non seo friendly url path should return seo friendly relative url
         $query = $this->createQuery($targetPath);
         $response = $this->graphQlQuery($query);
         $this->assertEquals($requestPath, $response['route']['relative_url']);
         $this->assertEquals(strtoupper(str_replace('-', '_', $expectedEntityType)), $response['route']['type']);
         $this->assertEquals(0, $response['route']['redirect_code']);
+        $this->assertEquals($page->getIdentifier(), $response['route']['identifier']);
     }
 
     /**
@@ -75,6 +77,7 @@ public function testResolveCMSPageWithQueryParameters()
         $response = $this->graphQlQuery($query);
         $this->assertNotEmpty($response['route']);
         $this->assertEquals($requestPath, $response['route']['relative_url']);
+        $this->assertEquals($page->getIdentifier(), $response['route']['identifier']);
     }
 
     /**
@@ -97,6 +100,7 @@ public function testResolveSlash()
         $this->assertEquals($homePageIdentifier, $response['route']['relative_url']);
         $this->assertEquals('CMS_PAGE', $response['route']['type']);
         $this->assertEquals(0, $response['route']['redirect_code']);
+        $this->assertEquals($page->getIdentifier(), $response['route']['identifier']);
     }
 
     /**
@@ -109,9 +113,13 @@ private function createQuery(string $path): string
 {
   route(url:"{$path}")
   {
-   relative_url
-   type
-   redirect_code
+    relative_url
+    type
+    redirect_code
+    __typename
+    ...on CmsPage {
+      identifier
+    }
   }
 }
 QUERY;