ACP2E-3660: REST endpoint Product Import Json not validate the mandatory fields

Author: aplapana

app/code/Magento/CatalogImportExport/Model/Import/Product.php

@@ -2708,7 +2708,9 @@ public function validateRow(array $rowData, $rowNum)
         // if product doesn't exist, need to throw critical error else all errors should be not critical.
         $errorLevel = $this->getValidationErrorLevel($sku);
 
-        if (!$this->validator->isValid($rowData)) {
+        $hasValidatedImportParent = $sku && $this->skuProcessor->getNewSku($sku);
+        $contextRowData = array_merge(['has_import_parent' => $hasValidatedImportParent], $rowData);
+        if (!$this->validator->isValid($contextRowData)) {
             foreach ($this->validator->getMessages() as $message) {
                 $this->skipRow($rowNum, $message, $errorLevel, $this->validator->getInvalidAttribute());
             }
@@ -2756,6 +2758,7 @@ public function validateRow(array $rowData, $rowNum)
                         'attr_set_code' => $rowData[self::COL_ATTR_SET],
                     ]
                 );
+                //$this->skuStorage->set(array_merge(['sku' => $sku], $this->skuProcessor->getNewSku($sku)));
             }
         }
 

app/code/Magento/CatalogImportExport/Model/Import/Product/Validator/Name.php

@@ -37,8 +37,9 @@ public function isValid($value)
         $skuExists = $this->skuStorage->has($value[Product::COL_SKU]);
         $hasCustomOptions = $this->hasCustomOptions($value);
         $hasNameValue = $this->hasNameValue($value);
+        $hasParentInImport = $this->hasValidatedImportParent($value);
 
-        if (!$skuExists && !$hasCustomOptions && !$hasNameValue) {
+        if (!$skuExists && !$hasCustomOptions && !$hasNameValue && !$hasParentInImport) {
             return $this->invalidate();
         }
 
@@ -64,6 +65,17 @@ private function invalidate(): bool
         return false;
     }
 
+    /**
+     * Check if current row data has a soon-to-be added parent product
+     *
+     * @param array $rowData
+     * @return bool
+     */
+    private function hasValidatedImportParent(array $rowData): bool
+    {
+        return array_key_exists('has_import_parent', $rowData) && $rowData['has_import_parent'];
+    }
+
     /**
      * Check if row data contains name value
      *

app/code/Magento/CatalogImportExport/Test/Unit/Model/Import/Product/Validator/NameTest.php

@@ -63,7 +63,7 @@ public static function getRowData(): array
                 ['name' => 'anything goes here', 'store_view_code' => 'en', 'sku' => 'sku']
             ],
             [
-                true,
+                false,
                 ['name' => null, 'store_view_code' => 'en', 'sku' => 'sku']
             ],
         ];