Move Dockerfile env vars to production.yml

[oliverbarnes]

All APP_* (except APP_ENVIRONMENT) config values should really be handled via a production.yml configuration file

reStations/Dockerfile

Line 37 in fefc166

ENV APP_SERVER__PORT=3000

Originally posted by @LukeMathWalker in #109 (comment)

[marcoow]

I don't really agree with this – IMO, the YAML files are for how the application behaves, whereas the env vars are for how the application connects to its runtime environment.

The difference is also that the YAML files are in git vs. the env vars can obviously change without a commit to git – I wouldn't want a commit, new version, etc. in order to change the database URL

[LukeMathWalker]

I don't really agree with this – IMO, the YAML files are for how the application behaves, whereas the env vars are for how the application connects to its runtime environment.

The difference is also that the YAML files are in git vs. the env vars can obviously change without a commit to git – I wouldn't want a commit, new version, etc. in order to change the database URL

The YAML files are defaults for each environment, that can then be overridden at runtime via environment variables. It's all configuration, in the end.
That's the way I look at this.

[marcoow]

I see – that I'd agree with 👍

[marcoow]

(I now remember I think we had that exact conversation before :))