Include country name in returned Places data

[pablobm]

After #85, we might be able to add the field countryName. This is not present as such in the source data, but we could add it manually. There are 36 different country codes in the data so it's possible convert from code to name with a manually-curated list.

[oliverbarnes]

Would we add that during the data sync step?

(part of #84)

[pablobm]

That might be the simplest and most effective option, yes. In the sync script we could add a handful of lines like UPDATE stations SET country_name = "United Kingdom" WHERE country = "GB"; (plus adding the column itself in the CREATE statement).

[marcoow]

I can't see how it's a good idea to include country name in the response? That's a localized string so there's no one name anyway. In particular when there's countryCode already, what's the point of adding localized country names as well? It seems this should be a data API only?

[pablobm]

OSDM does allow for localised content to be returned. The field cityName is another example.

Details are at https://osdm.io/spec/language/, but the summary is that the locale can be communicated with Accept-Language, and the fallback is English or a native language.

[pablobm]

Potentially simpler sources of this data:

• https://cldr.unicode.org/
• https://github.com/umpirsky/country-list

[marcoow]

the challenge is not getting a list of country names, the challenge is knowing which country a particular station is in

[pablobm]

I don't understand. All entries in the DB have a country field.

[marcoow]

ok, all of the other address fields then