Support for other sensor types on dashboard?

[rcloran]

I'd like to show the values of some sensor types that aren't temperature related on my dashboard. One that has come up a few times in Klipper forums is support for monitoring voltages, another that might be interesting to some is values from the load_cell component (eg, Klipper3d/klipper#6729 is adding support for using the load_cell as a regular scale for uses such as weighing remaining filament).

I've put together a quick prototype for this, but I'm not sure whether further work on it is worth pursuing. Is this something that Mainsail would consider adding?

Here's what it currently looks like:

In its current form, I've just added support for gcode_button, load_cell, and analog_input -- with analog_input being something that I'm working on, but haven't tried to get a PR together for Klipper yet, as I'm still trying to gauge whether it'd be useful to the community.

Here's the code: develop...rcloran:mainsail:misc-sensor

I'd like to add charts too -- I imagine one chart for each type of component displayed beneath the list of values, similar to how the temperature chart works. I haven't tried to make this work yet, as it looks like it'd be a fair amount of work just to test out, without knowing whether Mainsail would want it included :)

[rackrick]

Hey there... there is already support for moonraker sensors integrated into mainsail:

• feat(dashboard): add support for moonraker sensor #1888
• https://moonraker.readthedocs.io/en/latest/configuration/#sensor

Well I guess this does not cover all sensors you have mentioned here, but the engery stuff is pretty much in there. Its even integrated into the history to get the consumption of a print and so on.

[meteyou]

no sry... this is no "chicken & egg situation". Mainsail is a webinterface for Klipper. We will (try to) support all official Klipper functions. So when this feature is merged in Klipper, we will implement it in Mainsail.

[rcloran]

I never suggested it should be implemented in Mainsail before it was merged into Klipper. I'm asking whether it's something that's likely to be done if it is merged into Klipper. Specifically, I said "it's hard to motivate addition to Klipper without at least some indication that support for it in the UI would be possible". Reading between the lines, it sounds like you would support that?

Should I just send PRs for other sensor types I want supported, too, then? Do you have any suggestions as to the best approach? Should I just expand the Moonraker sensors as mentioned by @rackrick?

[meteyou]

yes of course. our goal is to support every official/mainline Klipper feature

[meteyou]

just my 2 cents: i think this feature (analog_input) is a nice diagnostic tool, which can be used in a lot of use cases!

can you pls post a link to your Klipper PR? is the unit of the value also part of the Klipper config?

[rcloran]

Here's the discussion where I've proposed the feature: https://klipper.discourse.group/t/feature-generic-analog-inputs/22074