Some feedback

[cyphix333]

Thanks for this but I found a few things that could be improved and have provided some feedback below:

• The instructions were lacking quite a bit, it was missing detailed implementation instructions. I had to assume I just applied the class to the input fields and not the labels, which seemed to work.

• It would be nice if it could work with your existing labels rather than create it's own.

• I know you can remove the style, but setting .jvfloat to a default of display: inline; seems very inflexible or wrong as then having block level elements inside it are invalid and since this is the primary container it can cause issues like this.

• Alternatively it would be nice if you could select an option to use as a container rather than jvfloat wrapping it in it's own container; for example I currently using my own wrapper elements to contain the label and field, so jvfloat adding another just adds unnecessary markup; if jvfloat needed to add any styles to this container it could do them inline or add a note when using this option of what styles the container needs.

A few of these issues are causing me problems right now as I applied jvfloat to my inputs and an example of my current markup is:

<div class="field">
    <label for="form_name">Name</label>
    <input id="form_name" type="text" name="name" placeholder="Name" required="required" />
</div>

But when I apply jvfloat to the input I get this:

<div class="field">
    <label for="form_name">Name</label>
    <div class="jvFloat">
        <label class="placeHolder required active" for="form_name">Name</label>
        <input id="form_name" type="text" name="name" placeholder="Name" required="required">
    </div>
</div>

As you can see, I now have duplicate labels and unnecessary markup - the extra markup isn't a huge deal though.

If you can't work with existing labels, then alternatively you should remove the other label and reproduce any additional attributes, classes etc it has.

Edit: Just noticed this hasn't been touched in 2.5 years, so perhaps it's been abandoned. Oh well.