Skip to content

Commit ddac37e

Browse files
committed
use sha256 instead of md5
1 parent 4f6cbea commit ddac37e

File tree

9 files changed

+12
-20
lines changed

9 files changed

+12
-20
lines changed

.travis.yml

Lines changed: 0 additions & 8 deletions
This file was deleted.

bin/incremental-diff-record.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ catch (err) { key = JSON.parse(key); }
7272
s3url.Key = [
7373
s3url.Key,
7474
table,
75-
crypto.createHash('md5')
75+
crypto.createHash('sha256')
7676
.update(Dyno.serialize(key))
7777
.digest('hex')
7878
].join('/');

bin/incremental-record-history.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ catch (err) { key = JSON.parse(key); }
7070
s3url.Key = [
7171
s3url.Key,
7272
table,
73-
crypto.createHash('md5')
73+
crypto.createHash('sha256')
7474
.update(Dyno.serialize(key))
7575
.digest('hex')
7676
].join('/');

index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ function incrementalBackup(event, context, callback) {
174174

175175
changes.forEach(function(change) {
176176
q.defer(function(next) {
177-
var id = crypto.createHash('md5')
177+
var id = crypto.createHash('sha256')
178178
.update(JSON.stringify(change.dynamodb.Keys))
179179
.digest('hex');
180180

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@mapbox/dynamodb-replicator",
3-
"version": "10.0.0",
3+
"version": "10.1.0",
44
"description": "",
55
"main": "index.js",
66
"scripts": {

s3-backfill.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ function backfill(config, done) {
5353
return key;
5454
}, {});
5555

56-
var id = crypto.createHash('md5')
56+
var id = crypto.createHash('sha256')
5757
.update(Dyno.serialize(key))
5858
.digest('hex');
5959

test/backup.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ dynamodb.test('backup: one segment', primaryItems, function(assert) {
4343
if (err) return assert.end();
4444

4545
assert.equal(details.count, 3, 'reported 3 records');
46-
assert.equal(details.size, 98, 'reported 98 bytes');
46+
assert.equal(details.size, 101, 'reported 101 bytes');
4747

4848
s3.getObject({
4949
Bucket: 'mapbox',

test/incremental.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ dynamodb.test('[s3-backfill]', records, function(assert) {
5252
var q = queue(20);
5353

5454
records.forEach(function(expected) {
55-
var key = crypto.createHash('md5')
55+
var key = crypto.createHash('sha256')
5656
.update(Dyno.serialize({ id: expected.id }))
5757
.digest('hex');
5858

test/index.test.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ test('[incremental backup] insert', function(assert) {
155155

156156
var event = require(path.join(events, 'insert.json'));
157157
var table = event.Records[0].eventSourceARN.split('/')[1];
158-
var id = crypto.createHash('md5')
158+
var id = crypto.createHash('sha256')
159159
.update(JSON.stringify(event.Records[0].dynamodb.Keys))
160160
.digest('hex');
161161

@@ -182,7 +182,7 @@ test('[incremental backup] insert & modify', function(assert) {
182182

183183
var event = require(path.join(events, 'insert-modify.json'));
184184
var table = event.Records[0].eventSourceARN.split('/')[1];
185-
var id = crypto.createHash('md5')
185+
var id = crypto.createHash('sha256')
186186
.update(JSON.stringify(event.Records[0].dynamodb.Keys))
187187
.digest('hex');
188188

@@ -209,7 +209,7 @@ test('[incremental backup] insert, modify & delete', function(assert) {
209209

210210
var event = require(path.join(events, 'insert-modify-delete.json'));
211211
var table = event.Records[0].eventSourceARN.split('/')[1];
212-
var id = crypto.createHash('md5')
212+
var id = crypto.createHash('sha256')
213213
.update(JSON.stringify(event.Records[0].dynamodb.Keys))
214214
.digest('hex');
215215

@@ -244,7 +244,7 @@ test('[incremental backup] adjust many', function(assert) {
244244
expected.forEach(function(record) {
245245
q.defer(function(next) {
246246
var key = { id: record.id };
247-
var id = crypto.createHash('md5')
247+
var id = crypto.createHash('sha256')
248248
.update(JSON.stringify(key))
249249
.digest('hex');
250250

@@ -264,7 +264,7 @@ test('[incremental backup] adjust many', function(assert) {
264264
});
265265

266266
q.defer(function(next) {
267-
var id = crypto.createHash('md5')
267+
var id = crypto.createHash('sha256')
268268
.update(JSON.stringify({ id: { S: 'record-1' } }))
269269
.digest('hex');
270270

0 commit comments

Comments
 (0)