Hi, I want to just point out some of your decisions and try to understand your reasons for making them. Feel free to share you thought process and rationale behind your decision. This is to understand your app design process and level of understanding of various parts of the app development.
-
Its really interesting to see you go extra mile to add fastlane to the project. What kind of lanes do you usually write in a typical project and how do you usually tie it up in continuous integration system? I saw that you are directly using api token in your fastfile, is there a way we can extract it out of git repo?
-
I saw that you are using storyboards in your app, I just want to discuss the pros and cons of using storyboard vs programmatic UI. Which one would you prefer?
-
You are actually using two separate JSON libraries in app, ObjectMapper and Swity JSON, have you tried working with swift Codable? Alamofire 5 even supports automatic decoding right?
-
Do you think creating an interceptor layer in network service would be beneficial at this stage of app development?
-
I saw that you have stored Auth key and secret in constants file. I have two questions here, do you think there is a better way to namespace Constants than using a struct? How do you think we can manage secrets in our app without leaking it to the git repo?
-
One last thing I want to discuss is your choice of folder structure. It is good but I want to know why you chose to bundle up viewModels of each module into a single folder structure? What would be the benefit of bundling viewModels in same folder vs bundling viewModel, views and controllers of each feature or module in same folder.
Hi, I want to just point out some of your decisions and try to understand your reasons for making them. Feel free to share you thought process and rationale behind your decision. This is to understand your app design process and level of understanding of various parts of the app development.
Its really interesting to see you go extra mile to add fastlane to the project. What kind of lanes do you usually write in a typical project and how do you usually tie it up in continuous integration system? I saw that you are directly using api token in your fastfile, is there a way we can extract it out of git repo?
I saw that you are using storyboards in your app, I just want to discuss the pros and cons of using storyboard vs programmatic UI. Which one would you prefer?
You are actually using two separate JSON libraries in app, ObjectMapper and Swity JSON, have you tried working with swift Codable? Alamofire 5 even supports automatic decoding right?
Do you think creating an interceptor layer in network service would be beneficial at this stage of app development?
I saw that you have stored Auth key and secret in constants file. I have two questions here, do you think there is a better way to namespace Constants than using a struct? How do you think we can manage secrets in our app without leaking it to the git repo?
One last thing I want to discuss is your choice of folder structure. It is good but I want to know why you chose to bundle up viewModels of each module into a single folder structure? What would be the benefit of bundling viewModels in same folder vs bundling viewModel, views and controllers of each feature or module in same folder.