Build warning on RHEL 8.10

[rohr22]

I got this build warning building on a RHEL 8.10 system:

./config.sh
grep: /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/device/bus.h: No such file or directory
make -C /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build M=/opt/vtl.source/mhvtl/kernel modules
make[1]: Entering directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64'
  CC [M]  /opt/vtl.source/mhvtl/kernel/mhvtl.o
/opt/vtl.source/mhvtl/kernel/mhvtl.c: In function ‘mhvtl_driver_probe’:
/opt/vtl.source/mhvtl/kernel/mhvtl.c:1452:25: warning: passing argument 1 of ‘scsi_host_alloc’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  hpnt = scsi_host_alloc(&mhvtl_driver_template, sizeof(*mhvtl_hba));
                         ^~~~~~~~~~~~~~~~~~~~~~
In file included from /opt/vtl.source/mhvtl/kernel/mhvtl.c:62:
./include/scsi/scsi_host.h:795:26: note: expected ‘struct scsi_host_template *’ but argument is of type ‘const struct scsi_host_template *’
 extern struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *, int);
                          ^~~~~~~~~~~~~~~
  Building modules, stage 2.
  MODPOST 1 modules
  CC      /opt/vtl.source/mhvtl/kernel/mhvtl.mod.o
  LD [M]  /opt/vtl.source/mhvtl/kernel/mhvtl.ko
make[1]: Leaving directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64'

[gonzoleeman]

On Feb 7, 2025, at 3:41 PM, Peter ***@***.***> wrote: I got this build warning building on a RHEL 8.10 system: ./config.sh grep: /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/device/bus.h: No such file or directory make -C /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build M=/opt/vtl.source/mhvtl/kernel modules make[1]: Entering directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64' CC [M] /opt/vtl.source/mhvtl/kernel/mhvtl.o /opt/vtl.source/mhvtl/kernel/mhvtl.c: In function ‘mhvtl_driver_probe’: /opt/vtl.source/mhvtl/kernel/mhvtl.c:1452:25: warning: passing argument 1 of ‘scsi_host_alloc’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] hpnt = scsi_host_alloc(&mhvtl_driver_template, sizeof(*mhvtl_hba)); ^~~~~~~~~~~~~~~~~~~~~~ In file included from /opt/vtl.source/mhvtl/kernel/mhvtl.c:62: ./include/scsi/scsi_host.h:795:26: note: expected ‘struct scsi_host_template *’ but argument is of type ‘const struct scsi_host_template *’ extern struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *, int); ^~~~~~~~~~~~~~~ Building modules, stage 2. MODPOST 1 modules CC /opt/vtl.source/mhvtl/kernel/mhvtl.mod.o LD [M] /opt/vtl.source/mhvtl/kernel/mhvtl.ko make[1]: Leaving directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64'

That is a fairly old version of the Linux kernel. :O I see two issues here with the compat.sh script: it is not finding the file bus.h, so it can’t check if (bus_type->comp)() needs a const first argument or not it seems to be incorrectling determining if the first argument to scsi_host_alloc() needs to be a const or not I don’t have any acces to RHEL releases, but I have pulled v4.8 of the kernel. I have a fix for the first issue. As for the 2nd issue, I’m perplexed. In 4.8, the argument to scsi_host_alloc() is passed in as a const, but the compiler expects otherwise. Can you run a test for me, to better determine the problem? Can you put “set -x” in the first few lines of kernel/compat.sh, then run “make” in the kernel directory, and capture the output for me? Thanks. — Lee Duncan

[rohr22]

it is not finding the file bus.h, so it can’t check if (bus_type->comp)() needs a const first argument or not
it seems to be incorrectling determining if the first argument to scsi_host_alloc() needs to be a const or not

Do I need to install the kernel-devel RPM? It provides bus.h in these locations:

kernel-devel-4.18.0-553.16.1.el8_10.x86_64 : Development package for building
                                           : kernel modules to match the kernel
Repo        : @System
Matched from:
Filename    : /usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64/include/config/ac97/bus.h
Filename    : /usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64/include/config/auxiliary/bus.h
Filename    : /usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64/include/config/intel/idxd/bus.h
Filename    : /usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64/include/config/mdio/bus.h
Filename    : /usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64/include/config/mhi/bus.h
Filename    : /usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64/include/config/virt/to/bus.h
Filename    : /usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64/include/linux/amba/bus.h

Can you put “set -x” in the first few lines of kernel/compat.sh, then run “make” in the kernel directory, and capture the output for me?

I didn't find a kernel/compat.sh, but I did find a kernel/config.sh. I did a make clean and then a make and saw:

# make
./config.sh
+ declare -A syms
+ syms[kmem_cache_create_usercopy]=slab.h
+ syms[file_inode]=fs.h
+ syms[sysfs_emit]=sysfs.h
+ output=config.h
+ kparent=/lib/modules/4.18.0-553.16.1.el8_10.x86_64
+ '[' -e /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/fs.h ']'
+ hdrs=/lib/modules/4.18.0-553.16.1.el8_10.x86_64/build
+ rm -f config.h
+ cat
+ for sym in ${!syms[@]}
+ grep -q sysfs_emit /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/sysfs.h
+ '[' 0 -eq 0 ']'
++ echo sysfs_emit
++ tr '[:lower:]' '[:upper:]'
+ printf '#define HAVE_%s\n' SYSFS_EMIT
+ for sym in ${!syms[@]}
+ grep -q file_inode /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/fs.h
+ '[' 0 -eq 0 ']'
++ echo file_inode
++ tr '[:lower:]' '[:upper:]'
+ printf '#define HAVE_%s\n' FILE_INODE
+ for sym in ${!syms[@]}
+ grep -q kmem_cache_create_usercopy /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/slab.h
+ '[' 0 -eq 0 ']'
++ echo kmem_cache_create_usercopy
++ tr '[:lower:]' '[:upper:]'
+ printf '#define HAVE_%s\n' KMEM_CACHE_CREATE_USERCOPY
+ '[' -e /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/genhd.h ']'
+ echo '#define HAVE_GENHD'
+ syms[file_operations]=fs.h
+ grep -q unlocked_ioctl /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/fs.h
+ echo '#ifndef HAVE_UNLOCKED_IOCTL'
+ echo '#define HAVE_UNLOCKED_IOCTL'
+ echo '#endif'
++ grep 'rc = func_name##_lck' /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/scsi/scsi_host.h
+ str='		rc = func_name##_lck (cmd, cmd->scsi_done);			\'
+ [[ 		rc = func_name##_lck (cmd, cmd->scsi_done);			\ == *,* ]]
+ echo '#undef QUEUECOMMAND_LCK_ONE_ARG'
+ grep -q 'DEFINE_SEMAPHORE(_name, _n)' /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/semaphore.h
+ echo '#undef DEFINE_SEMAPHORE_HAS_NUMERIC_ARG'
+ grep -q 'const struct scsi_host_template' /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/scsi/scsi_host.h
+ echo '#ifndef DEFINE_CONST_STRUCT_SCSI_HOST_TEMPLATE'
+ echo '#define DEFINE_CONST_STRUCT_SCSI_HOST_TEMPLATE'
+ echo '#endif'
+ fgrep -q 'int (*match)(struct device *dev, const struct device_driver *drv);' /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/device/bus.h
grep: /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/device/bus.h: No such file or directory
+ echo '#undef DEFINE_CONST_STRUCT_DEVICE_DRIVER'
+ printf '\n\n#endif /* _MHVTL_KERNEL_CONFIG_H */\n'
make -C /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build M=/opt/vtl.source/mhvtl/kernel modules
make[1]: Entering directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64'
  CC [M]  /opt/vtl.source/mhvtl/kernel/mhvtl.o
/opt/vtl.source/mhvtl/kernel/mhvtl.c: In function ‘mhvtl_driver_probe’:
/opt/vtl.source/mhvtl/kernel/mhvtl.c:1452:25: warning: passing argument 1 of ‘scsi_host_alloc’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  hpnt = scsi_host_alloc(&mhvtl_driver_template, sizeof(*mhvtl_hba));
                         ^~~~~~~~~~~~~~~~~~~~~~
In file included from /opt/vtl.source/mhvtl/kernel/mhvtl.c:62:
./include/scsi/scsi_host.h:795:26: note: expected ‘struct scsi_host_template *’ but argument is of type ‘const struct scsi_host_template *’
 extern struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *, int);
                          ^~~~~~~~~~~~~~~
  Building modules, stage 2.
  MODPOST 1 modules
  CC      /opt/vtl.source/mhvtl/kernel/mhvtl.mod.o
  LD [M]  /opt/vtl.source/mhvtl/kernel/mhvtl.ko
make[1]: Leaving directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64'

I had to manually delete the config.h file after doing a make clean. It seems like the clean target should delete that also. The make clean has this output:

# make clean
rm -f mhvtl.ko
rm -f *.o
rm -f TAGS

[markh794]

Thanks for the bug report.

I shall update the 'clean' target to also remove the config.h

note: The 'distclean' target does remove config.h.

make distclean

Re: bus.h

Let me see if there is a distribution agnostic method to check this.
Perhaps for now just failing with a sane error message if bus.h cannot be found would be better than the silent behaviour/confusion it currently exhibits.

[gonzoleeman]

Mark: I have a patch for the bus.h issue, which I will ask the OP to try soon. I wanted to see if there was a 2nd issue, as well.

…

On Feb 9, 2025, at 2:12 PM, Mark Harvey ***@***.***> wrote: Thanks for the bug report. I shall update the 'clean' target to also remove the config.h note: The 'distclean' target does remove config.h. make distclean Re: bus.h Let me see if there is a distribution agnostic method to check this. Perhaps for now just failing with a sane error message if bus.h cannot be found would be better than the silent behaviour/confusion it currently exhibits. — Reply to this email directly, view it on GitHub <#141 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOJGHAWKKQBR5KOF3LXRVL2O7HDLAVCNFSM6AAAAABWXAC24OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNBWGYZDGMZZHA>. You are receiving this because you commented.

[gonzoleeman]

On Feb 9, 2025, at 9:30 AM, Peter ***@***.***> wrote: it is not finding the file bus.h, so it can’t check if (bus_type->comp)() needs a const first argument or not it seems to be incorrectling determining if the first argument to scsi_host_alloc() needs to be a const or not Do I need to install the kernel-devel RPM? It provides bus.h in these locations:

No, the ’struct bus_type’ definiton is not in bus.h for v4.8, I believe it is in include/linux/device.h. My new patch will handle that. But you should have the kernel-devel package installed anyway. I believe the INSTALL file says that. — Lee

[rohr22]

But you should have the kernel-devel package installed anyway. I believe the INSTALL file says that.

I think in the past I never bothered installing the kernel-devel RPM.

[rohr22]

In spite of the warnings I got when building the kernel driver, it seems like mhvtl has been working well. I ran some of our regression tests that use virtual tapes, and they all completed successfully.

[markh794]

In spite of the warnings I got when building the kernel driver, it seems like mhvtl has been working well. I ran some of our regression tests that use virtual tapes, and they all completed successfully.

Good luck rather than good management. The defaults work in this case :)

WFIW: Without the 'kernel-devel' rpm installed, you get the following error when trying to make the kernel driver:

[markh@alma8 kernel]$ make
./config.sh
Cannot infer kernel headers location
make: *** [Makefile:33: config.h] Error 1

[rohr22]

WFIW: Without the 'kernel-devel' rpm installed, you get the following error when trying to make the kernel driver
[markh@alma8 kernel]$ make
./config.sh
Cannot infer kernel headers location
make: *** [Makefile:33: config.h] Error 1

Somehow I don't get that. I see:

# make
./config.sh
grep: /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/device/bus.h: No such file or directory
make -C /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build M=/opt/vtl.source/mhvtl/kernel modules
make[1]: Entering directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64'
  CC [M]  /opt/vtl.source/mhvtl/kernel/mhvtl.o
/opt/vtl.source/mhvtl/kernel/mhvtl.c: In function ‘mhvtl_driver_probe’:
/opt/vtl.source/mhvtl/kernel/mhvtl.c:1452:25: warning: passing argument 1 of ‘scsi_host_alloc’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  hpnt = scsi_host_alloc(&mhvtl_driver_template, sizeof(*mhvtl_hba));
                         ^~~~~~~~~~~~~~~~~~~~~~
In file included from /opt/vtl.source/mhvtl/kernel/mhvtl.c:62:
./include/scsi/scsi_host.h:795:26: note: expected ‘struct scsi_host_template *’ but argument is of type ‘const struct scsi_host_template *’
 extern struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *, int);
                          ^~~~~~~~~~~~~~~
  Building modules, stage 2.
  MODPOST 1 modules
  CC      /opt/vtl.source/mhvtl/kernel/mhvtl.mod.o
  LD [M]  /opt/vtl.source/mhvtl/kernel/mhvtl.ko
make[1]: Leaving directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64'

[gonzoleeman]

On Feb 9, 2025, at 8:35 PM, Peter ***@***.***> wrote: WFIW: Without the 'kernel-devel' rpm installed, you get the following error when trying to make the kernel driver ***@***.*** kernel]$ make ./config.sh Cannot infer kernel headers location make: *** [Makefile:33: config.h] Error 1 Somehow I don't get that. I see: # make ./config.sh grep: /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/device/bus.h: No such file or directory make -C /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build M=/opt/vtl.source/mhvtl/kernel modules make[1]: Entering directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64' CC [M] /opt/vtl.source/mhvtl/kernel/mhvtl.o /opt/vtl.source/mhvtl/kernel/mhvtl.c: In function ‘mhvtl_driver_probe’: /opt/vtl.source/mhvtl/kernel/mhvtl.c:1452:25: warning: passing argument 1 of ‘scsi_host_alloc’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] hpnt = scsi_host_alloc(&mhvtl_driver_template, sizeof(*mhvtl_hba)); ^~~~~~~~~~~~~~~~~~~~~~ In file included from /opt/vtl.source/mhvtl/kernel/mhvtl.c:62: ./include/scsi/scsi_host.h:795:26: note: expected ‘struct scsi_host_template *’ but argument is of type ‘const struct scsi_host_template *’ extern struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *, int); ^~~~~~~~~~~~~~~ Building modules, stage 2. MODPOST 1 modules CC /opt/vtl.source/mhvtl/kernel/mhvtl.mod.o LD [M] /opt/vtl.source/mhvtl/kernel/mhvtl.ko make[1]: Leaving directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64’

I believe the config.sh script is finding that your headers are at //lib/modules/4.18.0-533.16.1.el8_10.x86_64/build, but they are not correct? Either way, just install the kernel development RPM? I have pushed a fix for your bus.h issue to gonzoleeman/mhvtl, branch fix-scsi-host-alloc-issue. Can you please try it out? There are only 2 new commits, both to config.sh. (The 2nd commit just removes a debug statement I left in by accident.) If this works for you I can ask Mark to merge it. — Lee

[markh794]

Sorry Lee, still getting the failure on a AlmaLinux 8.10 install.

With 'set -x' in the config.sh script.

[markh@alma8 kernel]$ make
./config.sh
+ '[' -z /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build ']'
+ declare -A syms
+ syms[kmem_cache_create_usercopy]=slab.h
+ syms[file_inode]=fs.h
+ syms[sysfs_emit]=sysfs.h
+ output=config.h
+ kparent=/lib/modules/4.18.0-553.36.1.el8_10.x86_64
+ '[' -e /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/linux/fs.h ']'
+ hdrs=/lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include
+ rm -f config.h
+ cat
+ for sym in ${!syms[@]}
+ grep -q sysfs_emit /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/linux/sysfs.h
+ '[' 0 -eq 0 ']'
++ tr '[:lower:]' '[:upper:]'
++ echo sysfs_emit
+ printf '#define HAVE_%s\n' SYSFS_EMIT
+ for sym in ${!syms[@]}
+ grep -q file_inode /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/linux/fs.h
+ '[' 0 -eq 0 ']'
++ echo file_inode
++ tr '[:lower:]' '[:upper:]'
+ printf '#define HAVE_%s\n' FILE_INODE
+ for sym in ${!syms[@]}
+ grep -q kmem_cache_create_usercopy /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/linux/slab.h
+ '[' 0 -eq 0 ']'
++ echo kmem_cache_create_usercopy
++ tr '[:lower:]' '[:upper:]'
+ printf '#define HAVE_%s\n' KMEM_CACHE_CREATE_USERCOPY
+ '[' -e /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/linux/genhd.h ']'
+ echo '#define HAVE_GENHD'
+ syms[file_operations]=fs.h
+ grep -q unlocked_ioctl /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/linux/fs.h
+ echo '#ifndef HAVE_UNLOCKED_IOCTL'
+ echo '#define HAVE_UNLOCKED_IOCTL'
+ echo '#endif'
++ grep 'rc = func_name##_lck' /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/scsi/scsi_host.h
+ str='		rc = func_name##_lck (cmd, cmd->scsi_done);			\'
+ [[ 		rc = func_name##_lck (cmd, cmd->scsi_done);			\ == *,* ]]
+ echo '#undef QUEUECOMMAND_LCK_ONE_ARG'
+ grep -q 'DEFINE_SEMAPHORE(_name, _n)' /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/linux/semaphore.h
+ echo '#undef DEFINE_SEMAPHORE_HAS_NUMERIC_ARG'
+ grep -q 'const struct scsi_host_template' /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/scsi/scsi_host.h
+ echo '#ifndef DEFINE_CONST_STRUCT_SCSI_HOST_TEMPLATE'
+ echo '#define DEFINE_CONST_STRUCT_SCSI_HOST_TEMPLATE'
+ echo '#endif'
+ pat='int (*match)(struct device *dev, const struct device_driver *drv);'
++ grep -rl 'struct bus_type {' /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include
+ bus_type_def_file=/lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/linux/device.h
+ : '{bus_type_def_file:=not-found}'
+ '[' -r /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/linux/device.h ']'
+ fgrep -q 'int (*match)(struct device *dev, const struct device_driver *drv);' /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build/include/linux/device.h
+ echo '#undef DEFINE_CONST_STRUCT_DEVICE_DRIVER'
+ printf '\n\n#endif /* _MHVTL_KERNEL_CONFIG_H */\n'
make -C /lib/modules/4.18.0-553.36.1.el8_10.x86_64/build M=/home/markh/src/mhvtl-gonzo/kernel modules
make[1]: Entering directory '/usr/src/kernels/4.18.0-553.36.1.el8_10.x86_64'
  CC [M]  /home/markh/src/mhvtl-gonzo/kernel/mhvtl.o
/home/markh/src/mhvtl-gonzo/kernel/mhvtl.c: In function ‘mhvtl_driver_probe’:
/home/markh/src/mhvtl-gonzo/kernel/mhvtl.c:1452:25: warning: passing argument 1 of ‘scsi_host_alloc’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  hpnt = scsi_host_alloc(&mhvtl_driver_template, sizeof(*mhvtl_hba));
                         ^~~~~~~~~~~~~~~~~~~~~~
In file included from /home/markh/src/mhvtl-gonzo/kernel/mhvtl.c:62:
./include/scsi/scsi_host.h:795:26: note: expected ‘struct scsi_host_template *’ but argument is of type ‘const struct scsi_host_template *’
 extern struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *, int);
                          ^~~~~~~~~~~~~~~
  Building modules, stage 2.
  MODPOST 1 modules
  LD [M]  /home/markh/src/mhvtl-gonzo/kernel/mhvtl.ko
make[1]: Leaving directory '/usr/src/kernels/4.18.0-553.36.1.el8_10.x86_64'

[rohr22]

Either way, just install the kernel development RPM?

I have pushed a fix for your bus.h issue to gonzoleeman/mhvtl, branch fix-scsi-host-alloc-issue.

Can you please try it out? There are only 2 new commits, both to config.sh. (The 2nd commit just removes a debug statement I left in by accident.)

I actually do have the kernel-devel RPM installed:

# rpm -qa "kernel-dev*"
kernel-devel-4.18.0-553.16.1.el8_10.x86_64
kernel-devel-4.18.0-553.el8_10.x86_64

I tried to switch to your fix-scsi-host-alloc-issue branch, but saw:

# git switch fix-scsi-host-alloc-issue
fatal: invalid reference: fix-scsi-host-alloc-issue

I have a clone of this:

# git remote -v
origin	https://github.com/markh794/mhvtl.git (fetch)
origin	https://github.com/markh794/mhvtl.git (push)

Thank you,
Peter

[markh794]

Hi Peter,

You need to clone from Lee's repo:

git clone https://github.com/gonzoleeman/mhvtl.git mhvtl-gonzo (or what ever local directory you want to name this).
Then

cd mhvtl-gonzo
git switch fix-scsi-host-alloc-issue

I wasn't aware of the switch and used git checkout fix-scsi-host-alloc-issue

[rohr22]

Mark, thank you instructions on how to get stuff from Lee's repo. I tried out the fix-scsi-host-alloc-issue branch and still get the same issues as before:

# make
./config.sh
+ declare -A syms
+ syms[kmem_cache_create_usercopy]=slab.h
+ syms[file_inode]=fs.h
+ syms[sysfs_emit]=sysfs.h
+ output=config.h
+ kparent=/lib/modules/4.18.0-553.16.1.el8_10.x86_64
+ '[' -e /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/fs.h ']'
+ hdrs=/lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include
+ rm -f config.h
+ cat
+ for sym in ${!syms[@]}
+ grep -q sysfs_emit /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/sysfs.h
+ '[' 0 -eq 0 ']'
++ echo sysfs_emit
++ tr '[:lower:]' '[:upper:]'
+ printf '#define HAVE_%s\n' SYSFS_EMIT
+ for sym in ${!syms[@]}
+ grep -q file_inode /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/fs.h
+ '[' 0 -eq 0 ']'
++ echo file_inode
++ tr '[:lower:]' '[:upper:]'
+ printf '#define HAVE_%s\n' FILE_INODE
+ for sym in ${!syms[@]}
+ grep -q kmem_cache_create_usercopy /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/slab.h
+ '[' 0 -eq 0 ']'
++ echo kmem_cache_create_usercopy
++ tr '[:lower:]' '[:upper:]'
+ printf '#define HAVE_%s\n' KMEM_CACHE_CREATE_USERCOPY
+ '[' -e /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/genhd.h ']'
+ echo '#define HAVE_GENHD'
+ syms[file_operations]=fs.h
+ grep -q unlocked_ioctl /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/fs.h
+ echo '#ifndef HAVE_UNLOCKED_IOCTL'
+ echo '#define HAVE_UNLOCKED_IOCTL'
+ echo '#endif'
++ grep 'rc = func_name##_lck' /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/scsi/scsi_host.h
+ str='		rc = func_name##_lck (cmd, cmd->scsi_done);			\'
+ [[ 		rc = func_name##_lck (cmd, cmd->scsi_done);			\ == *,* ]]
+ echo '#undef QUEUECOMMAND_LCK_ONE_ARG'
+ grep -q 'DEFINE_SEMAPHORE(_name, _n)' /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/semaphore.h
+ echo '#undef DEFINE_SEMAPHORE_HAS_NUMERIC_ARG'
+ grep -q 'const struct scsi_host_template' /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/scsi/scsi_host.h
+ echo '#ifndef DEFINE_CONST_STRUCT_SCSI_HOST_TEMPLATE'
+ echo '#define DEFINE_CONST_STRUCT_SCSI_HOST_TEMPLATE'
+ echo '#endif'
+ pat='int (*match)(struct device *dev, const struct device_driver *drv);'
++ grep -rl 'struct bus_type {' /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include
+ bus_type_def_file=/lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/device.h
+ : '{bus_type_def_file:=not-found}'
+ '[' -r /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/device.h ']'
+ fgrep -q 'int (*match)(struct device *dev, const struct device_driver *drv);' /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build/include/linux/device.h
+ echo '#undef DEFINE_CONST_STRUCT_DEVICE_DRIVER'
+ printf '\n\n#endif /* _MHVTL_KERNEL_CONFIG_H */\n'
make -C /lib/modules/4.18.0-553.16.1.el8_10.x86_64/build M=/opt/vtl.source/mhvtl-gonzo/kernel modules
make[1]: Entering directory '/usr/src/kernels/4.18.0-553.16.1.el8_10.x86_64'
  CC [M]  /opt/vtl.source/mhvtl-gonzo/kernel/mhvtl.o
/opt/vtl.source/mhvtl-gonzo/kernel/mhvtl.c: In function ‘mhvtl_driver_probe’:
/opt/vtl.source/mhvtl-gonzo/kernel/mhvtl.c:1452:25: warning: passing argument 1 of ‘scsi_host_alloc’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
  hpnt = scsi_host_alloc(&mhvtl_driver_template, sizeof(*mhvtl_hba));
                         ^~~~~~~~~~~~~~~~~~~~~~
In file included from /opt/vtl.source/mhvtl-gonzo/kernel/mhvtl.c:62:
./include/scsi/scsi_host.h:795:26: note: expected ‘struct scsi_host_template *’ but argument is of type ‘const struct scsi_host_template *’
 extern struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *, int);
                          ^~~~~~~~~~~~~~~
  Building modules, stage 2.
  MODPOST 1 modules
  CC      /opt/vtl.source/mhvtl-gonzo/kernel/mhvtl.mod.o
  LD [M]  /opt/vtl.source/mhvtl-gonzo/kernel/mhvtl.ko