Merge pull request #1810 from marklogic/feature/23146-compile-fixes

MLE-23146 Address compile warnings in src/main/java

Author: rjrudin

examples/src/main/java/com/marklogic/client/example/handle/GSONHandleExample.java

@@ -55,7 +55,7 @@ public static void runShortcut(ExampleProperties props) throws IOException {
     String docId = "/example/"+filename;
 
     // parse the example file with GSON
-    JsonElement writeDocument = new JsonParser().parse(
+    JsonElement writeDocument = JsonParser.parseReader(
       new InputStreamReader(docStream, "UTF-8"));
 
     // write the document
@@ -99,7 +99,7 @@ public static void runStrongTyped(ExampleProperties props) throws IOException {
     GSONHandle writeHandle = new GSONHandle();
 
     // parse the example file with GSON
-    JsonElement writeDocument = writeHandle.getParser().parse(
+    JsonElement writeDocument = JsonParser.parseReader(
       new InputStreamReader(docStream, "UTF-8"));
     writeHandle.set(writeDocument);
 

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/datamovement/functionaltests/TestSplitters.java

@@ -36,6 +36,7 @@
 
 import static org.junit.jupiter.api.Assertions.*;
 
+@SuppressWarnings("unchecked")
 public class TestSplitters  extends BasicJavaClientREST {
     private static String dbName = "TestSplittersDB";
     private static String[] fNames = {"TestSplittersDB-1"};
@@ -1050,6 +1051,7 @@ public void setFileStream(FileInputStream fileStream) {
     }
 
     @Override
+	@SuppressWarnings("unchecked")
     public void run() {
         Stream<StringHandle> contentStream = null;
         Charset cs = Charset.forName("UTF-8");

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/RowBatcherFuncTest.java

@@ -68,8 +68,8 @@ public void testRowBatcherWithJackson() {
         PlanBuilder p = rowMgr.newPlanBuilder();
         PlanBuilder.ModifyPlan plan = p.fromView("opticFunctionalTest", "detail");
         rowsBatcherOfJsonObj.withBatchView(plan);
-        ArrayList<Double> exptdAmt = new ArrayList(Arrays.asList(10.01,20.02,30.03,40.04,50.05,60.06));
-        ArrayList<Double> resultAmt = new ArrayList<>();
+        List<Double> exptdAmt = Arrays.asList(10.01,20.02,30.03,40.04,50.05,60.06);
+        List<Double> resultAmt = new ArrayList<>();
 
         rowsBatcherOfJsonObj.onSuccess(e ->{
             JsonNode resDoc = e.getRowsDoc().get("rows");
@@ -117,8 +117,8 @@ public void testJoinInner() {
                         p.col( "color")
                 );
         rowsBatcherOfJsonObj.withBatchView(plan3);
-        ArrayList<Double> exptdAmt = new ArrayList(Arrays.asList(10.01,20.02,30.03,40.04,50.05,60.06));
-        ArrayList<Double> resultAmt = new ArrayList<>();
+        List<Double> exptdAmt = Arrays.asList(10.01,20.02,30.03,40.04,50.05,60.06);
+        List<Double> resultAmt = new ArrayList<>();
 
         rowsBatcherOfJsonObj.onSuccess(e ->{
             JsonNode resDoc = e.getRowsDoc().get("rows");
@@ -168,8 +168,8 @@ public void testWithExpressioncolumns() {
                         p.as("divided", p.divide(p.col("amount"), p.multiply(p.col("amount"), p.viewCol("detail", "id"))))
                 );
         rowsBatcherOfJsonObj.withBatchView(plan3);
-        ArrayList<Double> exptdAmt = new ArrayList(Arrays.asList(11.01, 22.02, 31.03, 42.04, 51.05, 62.06));
-        ArrayList<Double> resultAmt = new ArrayList<>();
+        List<Double> exptdAmt = Arrays.asList(11.01, 22.02, 31.03, 42.04, 51.05, 62.06);
+		List<Double> resultAmt = new ArrayList<>();
 
         rowsBatcherOfJsonObj.onSuccess(e -> {
             JsonNode resDoc = e.getRowsDoc().get("rows");
@@ -259,9 +259,9 @@ public void testMultipleSuccessListener() {
         PlanBuilder p = rowMgr.newPlanBuilder();
         PlanBuilder.ModifyPlan plan = p.fromView("opticFunctionalTest", "detail");
         rowsBatcherOfJsonObj.withBatchView(plan);
-        ArrayList<Double> exptdAmt = new ArrayList(Arrays.asList(10.01,20.02,30.03,40.04,50.05,60.06));
-        ArrayList<Double> resultAmt1 = new ArrayList<>();
-        ArrayList<Double> resultAmt2 = new ArrayList<>();
+        List<Double> exptdAmt = Arrays.asList(10.01,20.02,30.03,40.04,50.05,60.06);
+		List<Double> resultAmt1 = new ArrayList<>();
+		List<Double> resultAmt2 = new ArrayList<>();
         rowsBatcherOfJsonObj.onSuccess(e ->{
             JsonNode resDoc = e.getRowsDoc().get("rows");
 
@@ -364,8 +364,8 @@ public void testExceptionInSecondSuccessListener() {
         PlanBuilder p = rowMgr.newPlanBuilder();
         PlanBuilder.ModifyPlan plan = p.fromView("opticFunctionalTest", "detail");
         rowsBatcherOfJsonObj.withBatchView(plan);
-        ArrayList<Double> exptdAmt = new ArrayList(Arrays.asList(10.01, 20.02, 30.03, 40.04, 50.05, 60.06));
-        ArrayList<Double> resultAmt1 = new ArrayList<>();
+        List<Double> exptdAmt = Arrays.asList(10.01, 20.02, 30.03, 40.04, 50.05, 60.06);
+		List<Double> resultAmt1 = new ArrayList<>();
 
         rowsBatcherOfJsonObj.onSuccess(e -> {
                 JsonNode resDoc = e.getRowsDoc().get("rows");

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestDocumentFormat.java

@@ -26,9 +26,7 @@
 import java.security.KeyManagementException;
 import java.security.NoSuchAlgorithmException;
 
-
-
-
+@SuppressWarnings("unchecked")
 public class TestDocumentFormat extends AbstractFunctionalTest {
 
   @BeforeAll

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestDocumentMimetype.java

@@ -18,6 +18,7 @@
 import java.security.KeyManagementException;
 import java.security.NoSuchAlgorithmException;
 
+@SuppressWarnings("unchecked")
 public class TestDocumentMimetype extends AbstractFunctionalTest {
 
   @Test

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestEvalJavaScript.java

@@ -515,7 +515,7 @@ public void testJSReturningDifferentTypesOrder3fromModules() throws Exception {
       DocumentMetadataHandle metadataHandle = new DocumentMetadataHandle();
       metadataHandle.getPermissions().add("test-js-eval",
           Capability.UPDATE, Capability.READ, Capability.EXECUTE);
-      DocumentManager dm = moduleClient.newDocumentManager();
+      TextDocumentManager dm = moduleClient.newTextDocumentManager();
       dm.write("/data/javascriptQueries.sjs", metadataHandle, ish);
       /*DocumentBuilder db = DocumentBuilderFactory.newInstance()
           .newDocumentBuilder();*/
@@ -648,7 +648,7 @@ public void testJavaScriptModules() {
 			  mjsString + "export default output;" :
 			  mjsString + "output";
 
-		  DocumentManager dm = moduleClient.newDocumentManager();
+		  TextDocumentManager dm = moduleClient.newTextDocumentManager();
 		  DocumentMetadataHandle metadataHandle = new DocumentMetadataHandle();
 		  metadataHandle.getPermissions().add("test-js-eval",
 				  Capability.UPDATE, Capability.READ, Capability.EXECUTE);

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestEvalXquery.java

@@ -8,6 +8,7 @@
 import com.marklogic.client.DatabaseClient;
 import com.marklogic.client.FailedRequestException;
 import com.marklogic.client.document.DocumentManager;
+import com.marklogic.client.document.TextDocumentManager;
 import com.marklogic.client.eval.EvalResult;
 import com.marklogic.client.eval.EvalResult.Type;
 import com.marklogic.client.eval.EvalResultIterator;
@@ -413,7 +414,7 @@ public void testXqueryInvokeModuleRetDiffTypes() throws Exception {
       ish.set(inputStream);
       DocumentMetadataHandle metadataHandle = new DocumentMetadataHandle();
       metadataHandle.getPermissions().add("test-eval", Capability.UPDATE, Capability.READ, Capability.EXECUTE);
-      DocumentManager dm = moduleClient.newDocumentManager();
+      TextDocumentManager dm = moduleClient.newTextDocumentManager();
       dm.write("/data/xquery-modules-with-diff-variable-types.xqy", metadataHandle, ish);
       DocumentBuilder db = DocumentBuilderFactory.newInstance().newDocumentBuilder();
       InputSource is = new InputSource();

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestOpticEnhancements.java

@@ -21,6 +21,7 @@
 import java.util.regex.Pattern;
 
 
+@SuppressWarnings("unchecked")
 public class TestOpticEnhancements extends AbstractFunctionalTest {
 
   private static Map<String, Object>[] literals1 = new HashMap[10];

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestOpticOnLiterals.java

@@ -31,6 +31,7 @@
 import java.util.HashMap;
 import java.util.Map;
 
+@SuppressWarnings("unchecked")
 public class TestOpticOnLiterals extends AbstractFunctionalTest {
 
   private static Map<String, Object>[] literals1 = new HashMap[5];

marklogic-client-api-functionaltests/src/test/java/com/marklogic/client/fastfunctest/TestOpticOnMixedViews.java

@@ -23,7 +23,7 @@
 /* The tests here are for sanity checks when we have plans from different sources
  * such as fromLexicons and fromtriples.
  */
-
+@SuppressWarnings("unchecked")
 public class TestOpticOnMixedViews extends AbstractFunctionalTest {
 
   @BeforeAll