Fix for Polaris issues and test failures.

Author: anu3990

lib/documents.js

@@ -2659,7 +2659,7 @@ function collectDocUris(forestName, jobState){
           jobState.error = err;
           jobState.stream.emit('error', err);
         }
-          finishOnQueryAllDocs(jobState);
+        finishOnQueryAllDocs(jobState);
       });
 }
 

lib/patch-builder.js

@@ -446,7 +446,9 @@ function replace() {
       continue;
     }
     if (apply === null || apply === undefined) {
-      apply = arg.apply;
+      if(arg){
+        apply = arg.apply;
+      }
       if (apply != null) {
         content = arg.content;
         continue;

lib/resources-exec.js

@@ -243,7 +243,7 @@ function writeResources(self, method, responseType, args) {
   }
 
   operation.requestPartList = [];
-  if (typeof documents !== 'undefined') {
+  if (typeof documents !== 'undefined' && documents !== null) {
     for (var i=0; i < documents.length; i++) {
       addPart(operation, documents[i]);
     }

lib/responder.js

@@ -102,9 +102,9 @@ function responseDispatcher(response) {
     }
 
     dispatcher = new MultipartDispatcher(operation);
-  } else if (20 <= responseTypeLen && responseType.substr(0, 20) === 'application/json-seq') {
+  } else if (20 <= responseTypeLen && responseType && responseType.substr(0, 20) === 'application/json-seq') {
     dispatcher = new JSONSeqDispatcher(operation);
-  } else if (8 <= responseTypeLen && responseType.substr(0, 8) === 'text/csv') {
+  } else if (8 <= responseTypeLen && responseType && responseType.substr(0, 8) === 'text/csv') {
     dispatcher = new CSVDispatcher(operation);
   } else {
     if (expectedType === 'multipart') {

lib/transactions.js

@@ -94,7 +94,7 @@ Transactions.prototype.open = function openTransaction() {
       }
       throw new Error('unknown parameter for transaction open: '+arg);
     }
-  } else if (argLen === 1) {
+  } else if (argLen === 1 && arg) {
     transactionName = arg.transactionName;
     timeLimit       = arg.timeLimit;
     withState       = arg.withState;

test-basic/endpoint-proxy.js

@@ -236,7 +236,9 @@ void 0;`;
                 .execute(multiNodeInputMultiOutputDecl.functionName, {input:input})
                 .then(function(output) {
                     (output === void 0).should.equal(false);
-                    input.length.should.equal(output.length);
+                    if(output){
+                        input.length.should.equal(output.length);
+                    }
                     for (let i=0; i < input.length; i++) {
                         const expected = input[i];
                         const actual = output[i];

test-complete/nodejs-documents-values.js

@@ -288,9 +288,9 @@ describe('Document tuples test', function () {
             var strData = JSON.stringify(response);
             //console.log(strData);
             strData.should.containEql('"name":"correlation","_value":"0.263822426505543"');
-            strData.should.containEql[('"name":"covariance","_value":"0.35"') || ('"name":"covariance","_value":"0.349999999999998"')];
+            strData.should.containEql(('"name":"covariance","_value":"0.35"') || ('"name":"covariance","_value":"0.349999999999998"'));
             done();
-        }, done);
+        }).catch(error=> done(error));
     });
 
     it('should do max, min, sum, average aggregates', function (done) {

test-complete/nodejs-optic-generate-views.js

@@ -70,6 +70,7 @@ function waitForViewCreate(wTime) {
 }
 
 describe('Nodejs Optic generate views test', function () {
+    this.timeout(20000);
     it('TEST 1 - join left outer with array of on', function (done) {
 
         const plan1 =
@@ -101,9 +102,9 @@ describe('Nodejs Optic generate views test', function () {
                 }).
                     result(function (response) {
                         //	console.log(JSON.stringify(response, null, 4));
+                    done();
                     });
-                done();
-            }, done);
+            }).catch(error=>done(error));
     });
 
     waitForViewCreate(10000);
@@ -126,8 +127,7 @@ describe('Nodejs Optic generate views test', function () {
                 expect(row5['InnerJoin.keymatch.amount'].value).to.equal(10.01);
                 done();
             }, function (error) {
-                console.log(JSON.stringify(error, null, 2));
-                done();
+                done(error);
             });
     });
 
@@ -158,9 +158,9 @@ describe('Nodejs Optic generate views test', function () {
                 }).
                     result(function (response) {
                         //	console.log(JSON.stringify(response, null, 4));
+                    done();
                     });
-                done();
-            }, done);
+            }).catch(error=>done(error));
     });
 
     waitForViewCreate(10000);
@@ -181,8 +181,7 @@ describe('Nodejs Optic generate views test', function () {
                 expect(row7['sparql.groupmin.min_sales'].value).to.equal(10000000);
                 done();
             }, function (error) {
-                console.log(JSON.stringify(error, null, 2));
-                done();
+                done(error);
             });
     });
 
@@ -218,9 +217,9 @@ describe('Nodejs Optic generate views test', function () {
                 }).
                     result(function (response) {
                         //	console.log(JSON.stringify(response, null, 4));
+                    done();
                     });
-                done();
-            }, done);
+            }).catch(error=>done(error));
     });
 
     waitForViewCreate(10000);
@@ -241,8 +240,7 @@ describe('Nodejs Optic generate views test', function () {
                 expect(row3['lexicons.orderbyselect.date'].value).to.equal('2007-01-01');
                 done();
             }, function (error) {
-                console.log(JSON.stringify(error, null, 2));
-                done();
+                done(error);
             });
     });
 });