Add support for test, build results summary and logs grouping via common-utils #81
+612
−4,376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sameagen-MW
approved these changes
Nov 25, 2025
Contributor
sameagen-MW
left a comment
sameagen-MW
left a comment
There was a problem hiding this comment.
LGTM overall, just a few comments / questions.
|
|
||
| RMC_BASE_URL='https://ssd.mathworks.com/supportfiles/ci/run-matlab-command/v2' | ||
| SUPPORTED_OS=('win64' 'maci64' 'maca64' 'glnxa64') | ||
| source ./node_modules/common-utils/scripts/setupdeps.sh |
Contributor
There was a problem hiding this comment.
See my comments on run-tests here.
TL;DR: I generally prefer the setup script to be self-contained in the action repo
Contributor
There was a problem hiding this comment.
Does this mean run-command and run-build will now ship with scriptgen? I don't think they were before.
davidbuzinski
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes required with matlab-actions/common-utils#1 to begin using the new common utility.
NOTE: Before merging, the version for
common-utilsdependency inpackage.json,package-lock.jsonwill be updated after its release (couldn't add a comment since it's a JSON file). At the moment, the dependency refers to my working branch