Skip to content
This repository was archived by the owner on Apr 12, 2022. It is now read-only.
This repository was archived by the owner on Apr 12, 2022. It is now read-only.

Wrong Sync timeout configuration #551

@bagolysz

Description

@bagolysz

When setting the syncDelay to a custom value, the sync timeout parameter is no longer set to desired value.

Description

  • When building a default session, like below:
    session = MXSession.Builder(hsConfig!!, dataHandler, context).build(); session?.startEventStream(null);

The sync requests are made expected, with the default timeout value (after the first sync):
https://mybaseurl/_matrix/client/r0/sync?filter=%7B%7D&set_presence=offline&timeout=0 https://mybaseurl/_matrix/client/r0/sync?filter=1&set_presence=offline&timeout=30000&since=s94606_169438_162_1_1_1_1_22183_1

  • When building a session with custom syncDelay:
    session = MXSession.Builder(hsConfig!!, dataHandler, context).build(); session?.syncDelay = 20000; session?.startEventStream(null);

The sync requests now are sending the parameter timeout with value 0 all the time (not only for first sync):
https://mybaseurl/_matrix/client/r0/sync?filter=%7B%7D&set_presence=offline&timeout=0 https://mybaseurl/_matrix/client/r0/sync?filter=1&set_presence=offline&timeout=0&since=s94605_169415_162_1_1_1_1_22182_1

  • Moreover, if the syncTimeout is set:
    session?.syncTimeout = 10000

the timeout param in the request still remains the default one:
https://mybaseurl/_matrix/client/r0/sync?filter=1&set_presence=offline&timeout=30000&since=s94606_169438_162_1_1_1_1_22183_1

Additional information
Matrix-Android-Sdk version: v0.9.35
Android Studio version: 4.0.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions