Goal import fails when the same team scores more than once in a minute

[matt-bernhardt]

On March 6, 2016 Orlando scored in the 94th and 95th minute. The stoppage time correction adjusts both goal times to the 89th minute (because all times are normalized within 0-90).

Unfortunately, something in the goal import step results in only the second goal being recorded. The goal string for this sequence is:

Larin (Shea, Barry) 94+; Winter (Larin, Carrasco) 95+

This gets parsed by import-goals into an list of six elements (two goals, four assists) - but in the database only the goal from Winter is recorded.

The log from import-goals shows six records:

Looking up PlayerID for event:
{'GameID': 17214, 'playername': u'Larin', 'OpponentID': 340, 'MinuteID': 89, 'TeamID': 506, 'Notes': '', 'Event': 1}
Looking up PlayerID for event:
{'GameID': 17214, 'playername': u'Shea', 'Notes': '', 'MinuteID': 89, 'TeamID': 506, 'Event': 2}
Looking up PlayerID for event:
{'GameID': 17214, 'playername': u'Barry', 'Notes': '', 'MinuteID': 89, 'TeamID': 506, 'Event': 3}
Looking up PlayerID for event:
{'GameID': 17214, 'playername': u'Winter', 'OpponentID': 340, 'MinuteID': 89, 'TeamID': 506, 'Notes': '', 'Event': 1}
Looking up PlayerID for event:
{'GameID': 17214, 'playername': u'Larin', 'Notes': '', 'MinuteID': 89, 'TeamID': 506, 'Event': 2}
Looking up PlayerID for event:
{'GameID': 17214, 'playername': u'Carrasco', 'Notes': '', 'MinuteID': 89, 'TeamID': 506, 'Event': 3}

[matt-bernhardt]

Hmm...there may be a slightly different error going on here. Adding a bit of debugging to import_goal.py around line 116 produces this output in the log:

{'GameID': 17214, 'playername': u'Larin', 'OpponentID': 340, 'MinuteID': 89, 'PlayerID': 5109, 'TeamID': 506, 'Notes': '', 'Event': 1}
ERROR
{'GameID': 17214, 'playername': u'Shea', 'Notes': '', 'MinuteID': 89, 'PlayerID': 3469, 'TeamID': 506, 'Event': 2}
Record ID provided - we update
{'GameID': 17214, 'playername': u'Barry', 'Notes': '', 'MinuteID': 89, 'PlayerID': 5452, 'TeamID': 506, 'Event': 3}
Record ID provided - we update
{'GameID': 17214, 'playername': u'Winter', 'OpponentID': 340, 'MinuteID': 89, 'PlayerID': 5189, 'TeamID': 506, 'Notes': '', 'Event': 1}
Record ID provided - we update
{'GameID': 17214, 'playername': u'Larin', 'Notes': '', 'MinuteID': 89, 'PlayerID': 5109, 'TeamID': 506, 'Event': 2}
ERROR
{'GameID': 17214, 'playername': u'Carrasco', 'Notes': '', 'MinuteID': 89, 'PlayerID': 3740, 'TeamID': 506, 'Event': 3}

This doesn't look like the goal being flagged, but the two events or Cyle Larin.

It is also possible that both of these things are problematic - two events for the same player in the same (corrected) minute, and two goals for the same team in the same minute.