Skip to content

Redact user event for direct logins #291

@redgoat650

Description

@redgoat650

When a user logs in with two steps, e.g.

> login token
> {"field_id_1":"xyz...","field_id_2":"abc..."}

the user's second message gets redacted to hide the field values (they might contain tokens or other secrets).

When a user logs in direct (checkLoginCommandDirectParams), e.g.:

> login token xyz... abc...

the message is left unredacted, with the values in plaintext.

Any reason for this differing behavior with respect to redactions? Can we assume that if the user provided extra ce.Args, they're probably attempting to provide login secrets, and we should issue a redaction for them? Or do some login flows allow only non-secret extra args that we want to keep around and not redact? Thoughts?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions