Skip to content

Commit 72dfd34

Browse files
committed
WIP: Bzlmod part the thirtieth
Extract junit_deps list in test/BUILD, then add it to more targets that need it.
1 parent b02c12c commit 72dfd34

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

MODULE.bazel.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/BUILD

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -695,12 +695,15 @@ check_statsfile("ScalaBinary")
695695
check_statsfile("ScalaLibBinary")
696696

697697
#discovering tests from a separate target
698+
699+
junit_deps = [
700+
"@io_bazel_rules_scala_junit_junit" + version_suffix(SCALA_VERSION)
701+
]
702+
698703
scala_library(
699704
name = "JunitSeparateTarget",
700705
srcs = ["src/main/scala/scalarules/test/junit/separate_target/JunitSeparateTargetTest.scala"],
701-
deps = [
702-
"@io_bazel_rules_scala_junit_junit" + version_suffix(SCALA_VERSION)
703-
],
706+
deps = junit_deps,
704707
)
705708

706709
scala_junit_test(
@@ -714,9 +717,7 @@ scala_junit_test(
714717
java_library(
715718
name = "JunitJavaSeparateTarget",
716719
srcs = ["src/main/scala/scalarules/test/junit/separate_target/JunitJavaSeparateTargetTest.java"],
717-
deps = [
718-
"@io_bazel_rules_scala_junit_junit" + version_suffix(SCALA_VERSION)
719-
],
720+
deps = junit_deps,
720721
)
721722

722723
scala_junit_test(
@@ -736,6 +737,7 @@ scala_library(
736737
name = "JunitSeparateTargetWithDependencyOnTest",
737738
srcs = ["src/main/scala/scalarules/test/junit/separate_target/JunitSeparateTargetTest.scala"],
738739
runtime_deps = [":TargetWithTestThatShouldNotRun"],
740+
deps = junit_deps,
739741
)
740742

741743
scala_junit_test(
@@ -750,9 +752,7 @@ java_library(
750752
name = "JunitSeparateJavaTargetWithDependencyOnTest",
751753
srcs = ["src/main/scala/scalarules/test/junit/separate_target/JunitJavaSeparateTargetTest.java"],
752754
runtime_deps = [":TargetWithTestThatShouldNotRun"],
753-
deps = [
754-
"@io_bazel_rules_scala_junit_junit" + version_suffix(SCALA_VERSION)
755-
],
755+
deps = junit_deps,
756756
)
757757

758758
scala_junit_test(
@@ -769,6 +769,7 @@ scala_library(
769769
"src/main/scala/scalarules/test/junit/separate_target/JunitJavaSeparateTargetTest.java",
770770
"src/main/scala/scalarules/test/junit/separate_target/SomeScalaClass.scala",
771771
],
772+
deps = junit_deps,
772773
)
773774

774775
scala_junit_test(

0 commit comments

Comments
 (0)