Skip to content

Commit d73cbf5

Browse files
committed
Add proper authentication for pulling gcr private images
1 parent 158db20 commit d73cbf5

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

.github/workflows/cd.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,6 @@ jobs:
88
- name: 'Checkout'
99
uses: 'actions/checkout@v1'
1010

11-
- uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
12-
with:
13-
version: '278.0.0'
14-
service_account_email: ${{ secrets.GCP_SA_EMAIL }}
15-
service_account_key: ${{ secrets.GCP_SA_KEY }}
16-
17-
- name: Authorize gcloud with docker
18-
run: gcloud auth configure-docker
19-
2011
- name: 'Helm dependency updates'
2112
run: |
2213
curl -LO https://get.helm.sh/helm-v3.0.3-linux-amd64.tar.gz \

first-deploy-quickstart.sh

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,29 @@
55
kubectl create namespace doppelganger
66
kubectl create namespace staging-doppelganger
77
kubectl create namespace production-doppelganger
8+
9+
# Need to create secret for each namespace we will run pods in
810
kubectl create secret docker-registry gcr-json-key \
911
--namespace doppelganger \
1012
--docker-server=gcr.io \
1113
--docker-username=_json_key \
1214
--docker-password="$(cat ./json-key-file.json)" \
1315
--docker-email=any@valid.email
1416

17+
kubectl create secret docker-registry gcr-json-key \
18+
--namespace staging-doppelganger \
19+
--docker-server=gcr.io \
20+
--docker-username=_json_key \
21+
--docker-password="$(cat ./json-key-file.json)" \
22+
--docker-email=any@valid.email
23+
24+
kubectl create secret docker-registry gcr-json-key \
25+
--namespace production-doppelganger \
26+
--docker-server=gcr.io \
27+
--docker-username=_json_key \
28+
--docker-password="$(cat ./json-key-file.json)" \
29+
--docker-email=any@valid.email
30+
1531
kubectl patch serviceaccount default \
1632
-p "{\"imagePullSecrets\": [{\"name\": \"gcr-json-key\"}]}"
1733
helm repo add stable https://kubernetes-charts.storage.googleapis.com

0 commit comments

Comments
 (0)