Possible issue in boot_serial.c: reset off = 0 outside conditional block

[alcarraro]

Hello,

While porting MCUboot to my platform, I found a behaviour in boot_serial.c that prevent the correct communication with mcumgr unless I modify the code as following:

Original code:

    /* serve errors: out of decode memory, or bad encoding */
    if (rc == 1) {
        boot_serial_input(&dec_buf[2], dec_off - 2);
    }
    off = 0;

Modified code to make it work in my scenario:

    /* serve errors: out of decode memory, or bad encoding */
    if (rc == 1) {
        boot_serial_input(&dec_buf[2], dec_off - 2);
        off = 0;
    }

Could this be a bug or am I missing something?
If someone could point me in the right direction, I'd appreciate it.

Thanks in advance!

[alcarraro]

Sorry for the noise, I found the issue in the base64 library used in my platform.