Skip to content

feat(legacy): inline yari #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
caugner wants to merge 4 commits into
base: main
Choose a base branch
from
+125,162 −15,605
Draft

feat(legacy): inline yari #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
734530c
feat(legacy): inline https://github.com/mdn/yari/commit/0cfdd1b8445c0…
caugner Oct 2, 2025
d40a96a
chore(legacy): use vendor/yari instead of node_modules/@mdn/yari
caugner Oct 2, 2025
13c8b4f
chore: remove obsolete yari parts
caugner Oct 2, 2025
7a4128d
fix(vendor/yari): ignore Express errors
caugner Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 2 additions & 2 deletions .lefthook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ pre-commit:
glob: "components/**/*.js"

- name: stylelint
run: npx stylelint --fix --cache {staged_files}
run: npx stylelint --fix --cache --allow-empty-input {staged_files}
glob: "*.css"
stage_fixed: true

Expand All @@ -42,7 +42,7 @@ pre-push:
- name: lit-analyzer
run: npm run lit-analyzer -- components
- name: stylelint
run: npx stylelint '**/*.css' --cache --ignore-path .gitignore
run: npx stylelint '**/*.css' --cache --ignore-path .stylelintignore --ignore-path .gitignore
- name: tsc
run: npx tsc

Expand Down
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
CHANGELOG.md
vendor
1 change: 1 addition & 0 deletions .stylelintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
dist/
vendor/
12 changes: 6 additions & 6 deletions legacy/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import ReactDOM from "react-dom/client";
Copy link
Contributor Author

@caugner caugner Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I now realize that no longer having @mdn/yari in our dependencies means this transitive dependency is no longer installed.

In theory, we could use vendor/yari as a local dependency, but that would break Dependabot updates.

import { BrowserRouter as Router, Route, Routes } from "react-router-dom";
import { UserDataProvider } from "@mdn/yari/client/src/user-context";
import { UIProvider } from "@mdn/yari/client/src/ui-context";
import { Plus } from "@mdn/yari/client/src/plus";
import { GleanProvider } from "@mdn/yari/client/src/telemetry/glean-context";
import { UserDataProvider } from "../vendor/yari/client/src/user-context";
import { UIProvider } from "../vendor/yari/client/src/ui-context";
import { Plus } from "../vendor/yari/client/src/plus";
import { GleanProvider } from "../vendor/yari/client/src/telemetry/glean-context";

import "@mdn/yari/client/src/app.scss";
import "@mdn/yari/client/src/document/index.scss";
import "../vendor/yari/client/src/app.scss";
import "../vendor/yari/client/src/document/index.scss";

import "./legacy.css";
import "../hooks/legacy-theme-controller.js";
Expand Down
Loading
Loading