Skip to content

fix(color-theme): show current theme in dropdown button #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
brysonbw wants to merge 3 commits into
base: main
Choose a base branch
from
+8 −4
Draft

fix(color-theme): show current theme in dropdown button #876

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd119fc
fix (ui): show current theme on the color theme toggle button
brysonbw Oct 7, 2025
1d0b312
Merge branch 'main' into show-current-theme-on-the-color-theme-button
caugner Oct 23, 2025
8f2a537
Merge branch 'main' into show-current-theme-on-the-color-theme-button
caugner Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions components/color-theme/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ export class MDNColorTheme extends L10nMixin(LitElement) {
super();
/** @type {import("./types.js").ColorScheme} */
this._mode = "light dark";
this._options = Object.entries({
this._options = {
"light dark": this.l10n("theme-default")`OS default`,
light: this.l10n`Light`,
dark: this.l10n`Dark`,
});
};
}

/** @param {MouseEvent} event */
Expand All @@ -43,6 +43,10 @@ export class MDNColorTheme extends L10nMixin(LitElement) {
}
}

get _theme() {
return this._options[this._mode] ?? this.l10n`Theme`;
}

/**
* @param {import("lit").PropertyValues<this>} changedProperties
*/
Expand Down Expand Up @@ -70,15 +74,15 @@ export class MDNColorTheme extends L10nMixin(LitElement) {
type="button"
aria-label=${this.l10n`Switch color theme`}
>
<span>${this.l10n`Theme`}</span>
<span>${this._theme}</span>
</button>
<div
slot="dropdown"
class="color-theme__dropdown"
id="color-theme__dropdown"
>
<ul class="color-theme__list">
${this._options.map(
${Object.entries(this._options).map(
([mode, option]) =>
html`<li>
<button
Expand Down
Loading