Unable to compile

[daurnimator]

In file included from libui-lua.c:8:0:
control-common.h:9:32: fatal error: common/controlsigs.h: No such file or directory
 #include <common/controlsigs.h>

What is this 'common' directory?

[mdombroski]

Fair question.
common/controlsigs.h refers to a header contained within libui itself.
I will describe my build environment in the readme.

[daurnimator]

Perhaps consider adding a rockspec to the repository?

[mdombroski]

That's a pretty good idea.
I'll do that.

[daurnimator]

Earlier today I wrote a rockspec for the other lua libui binding. You may want to look at that: https://github.com/daurnimator/libuilua/blob/fbc1c4c67246b0e8df578949b36768ce7c468ed5/libuilua-scm-0.rockspec

[mdombroski]

Have another look when you get the chance, I've redone all the build system stuff.
Custom makefile is out, CMake or rockspec is in.

One thing that could potentially be a problem is the name of the output file: libui.so/dll
I can see a conflict happening on windows.

[daurnimator]

Your dependency spec "lua >= 5.1, < 5.4" is invalid, I get error:
Error: Could not load rockspec file /tmp/luarocks_luarocks-rockspec-libui-lua-git-0-2737/libui-lua-git-0.rockspec (Error loading file: [string "/tmp/luarocks_luarocks-rockspec-libui-lua-git..."]:5: unexpected symbol near '<')

Otherwise you should normally put a version of 'scm-0' for rockspecs that follow any version control, there are a few places in luarocks that treat it specially.

[mdombroski]

Weird, I copied that straight out of your example.
I haven't made a rockspec before. The conventions are new to me.

[daurnimator]

Oh shit sorry, I just did a noob move and gave it the wrong file. The dependency section was correct.

[daurnimator]

At the moment you're incompatible with upstream libui. Is this something you intend on fixing? If not, could you #ifdef out the incompatible parts?

[mdombroski]

Medium term goal, yes. I've added a few things I wanted (images/icons, timeouts).
As those things become available upstream I will rebase on them.

[daurnimator]

Other misc thing about the rockspec I'd suggest is putting one source file per line.