skb_layout_t::lines is not freed in skb_layout_destroy()

[JCash]

I run clang with Address Sanitizer, and nowadays on Linux clang, it also runs with the LeakDetector.
This is how I found out that the skb_layout_t destruction function doesn't free the linesmember.

I also suggest setting up a GitHub action that runs with Asan on the platforms that support it (e.g. macOS/Linux/Windows)

[memononen]

Thanks for the report!

I set up asan for msvc, but looks like it does not capture the mem leaks (but handles buffer overflows and such). I was able to catch the memleaks using the crt alloc debug stuff, though, so that I will see them now in my usual workflow.

There were embarrassingly many leaks, should be all fixed now.

[JCash]

There were embarrassingly many leaks

Same here, and I'm only halfway through our them ^^

should be all fixed now.

Thanks!
I'll grab a new version of the library now, and then reverify on my end.