From 1b0e40f608d7f0d1a6588a685239a93ed16c436e Mon Sep 17 00:00:00 2001 From: Yordan Date: Wed, 16 Jul 2025 14:08:07 +0200 Subject: [PATCH 1/3] fix(popup-menu): add design mode padding for empty dropzone --- .../popup-menu-web/src/PopupMenu.editorPreview.tsx | 10 +++++++++- .../popup-menu-web/src/ui/PopupMenuPreview.scss | 4 ++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/pluggableWidgets/popup-menu-web/src/PopupMenu.editorPreview.tsx b/packages/pluggableWidgets/popup-menu-web/src/PopupMenu.editorPreview.tsx index 35f609eabe..2519b4a5f0 100644 --- a/packages/pluggableWidgets/popup-menu-web/src/PopupMenu.editorPreview.tsx +++ b/packages/pluggableWidgets/popup-menu-web/src/PopupMenu.editorPreview.tsx @@ -1,4 +1,5 @@ import { parseStyle } from "@mendix/widget-plugin-platform/preview/parse-style"; +import classNames from "classnames"; import { createElement, ReactElement } from "react"; import { PopupMenu as PopupMenuComponent } from "./components/PopupMenu"; @@ -36,10 +37,17 @@ export function preview(props: PopupMenuPreviewProps): ReactElement { }); } + const isDesign = props.renderMode === "design"; + const isDropzoneEmpty = props.menuTrigger.widgetCount === 0; + + const popupMenuClass = classNames("popupmenu", { + "popupmenu--design-empty": isDesign && isDropzoneEmpty + }); + return ( Date: Wed, 16 Jul 2025 14:21:20 +0200 Subject: [PATCH 2/3] fix(changelog): updated changelog --- packages/pluggableWidgets/popup-menu-web/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/pluggableWidgets/popup-menu-web/CHANGELOG.md b/packages/pluggableWidgets/popup-menu-web/CHANGELOG.md index 478864b9a5..ad5c1b29c9 100644 --- a/packages/pluggableWidgets/popup-menu-web/CHANGELOG.md +++ b/packages/pluggableWidgets/popup-menu-web/CHANGELOG.md @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ## [Unreleased] +### Fixed + +- We fixed an issue where the user was unable to open the configuration panel in design-mode. + ## [4.0.2] - 2025-02-20 ### Fixed From 3a3a26aa84970f0628485c9cbc91f4cdfe456bd6 Mon Sep 17 00:00:00 2001 From: Yordan Date: Wed, 16 Jul 2025 15:08:41 +0200 Subject: [PATCH 3/3] fix(popup-menu): remove unnecessary design mode check, replace padding with var --- .../popup-menu-web/src/PopupMenu.editorPreview.tsx | 6 ++---- .../popup-menu-web/src/ui/PopupMenuPreview.scss | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/pluggableWidgets/popup-menu-web/src/PopupMenu.editorPreview.tsx b/packages/pluggableWidgets/popup-menu-web/src/PopupMenu.editorPreview.tsx index 2519b4a5f0..ae288e91c2 100644 --- a/packages/pluggableWidgets/popup-menu-web/src/PopupMenu.editorPreview.tsx +++ b/packages/pluggableWidgets/popup-menu-web/src/PopupMenu.editorPreview.tsx @@ -36,12 +36,10 @@ export function preview(props: PopupMenuPreviewProps): ReactElement { }); }); } - - const isDesign = props.renderMode === "design"; const isDropzoneEmpty = props.menuTrigger.widgetCount === 0; - const popupMenuClass = classNames("popupmenu", { - "popupmenu--design-empty": isDesign && isDropzoneEmpty + const popupMenuClass = classNames(props.className, "popupmenu", { + "popupmenu--design-empty": isDropzoneEmpty }); return ( diff --git a/packages/pluggableWidgets/popup-menu-web/src/ui/PopupMenuPreview.scss b/packages/pluggableWidgets/popup-menu-web/src/ui/PopupMenuPreview.scss index 47c9db5e8f..35098c5676 100644 --- a/packages/pluggableWidgets/popup-menu-web/src/ui/PopupMenuPreview.scss +++ b/packages/pluggableWidgets/popup-menu-web/src/ui/PopupMenuPreview.scss @@ -7,5 +7,5 @@ } .popupmenu--design-empty { - padding: 16px; + padding: var(--spacing-8, 8px); }