[WC-1784] DG: Column drag and drop enhancements #1989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordan-st
force-pushed
the
feat/WC-1784_DG-coldrag-enhance
branch
from
0f9af81 to
fb41b35
Compare
iobuhov
force-pushed
the
iobuhov_next
branch
from
6b44437 to
fc9dceb
Compare
yordan-st
force-pushed
the
feat/WC-1784_DG-coldrag-enhance
branch
from
5f3b6d2 to
0520f25
Compare
iobuhov
force-pushed
the
iobuhov_next
branch
from
736304d to
e3a4e71
Compare
yordan-st
force-pushed
the
feat/WC-1784_DG-coldrag-enhance
branch
2 times, most recently
from
8e73071 to
7bb9a06
Compare
iobuhov
reviewed
Nov 27, 2025
packages/pluggableWidgets/datagrid-web/src/features/column/ColumnHeader.viewModel.ts
Outdated
Show resolved
Hide resolved
iobuhov
reviewed
Nov 27, 2025
packages/pluggableWidgets/datagrid-web/src/components/__tests__/Header.spec.tsx
Outdated
Show resolved
Hide resolved
iobuhov
reviewed
Nov 27, 2025
packages/pluggableWidgets/datagrid-web/src/features/column/HeaderDragnDrop.viewModel.ts
Outdated
Show resolved
Hide resolved
iobuhov
reviewed
Nov 27, 2025
packages/pluggableWidgets/datagrid-web/src/features/column/HeaderDragnDrop.viewModel.ts
Show resolved
Hide resolved
iobuhov
reviewed
Nov 27, 2025
packages/pluggableWidgets/datagrid-web/src/components/ColumnContainer.tsx
Outdated
Show resolved
Hide resolved
iobuhov
reviewed
Nov 27, 2025
packages/pluggableWidgets/datagrid-web/src/components/ColumnContainer.tsx
Outdated
Show resolved
Hide resolved
iobuhov
reviewed
Nov 27, 2025
packages/pluggableWidgets/datagrid-web/src/components/ColumnContainer.tsx
Outdated
Show resolved
Hide resolved
iobuhov
requested changes
Nov 27, 2025
packages/pluggableWidgets/datagrid-web/src/components/ColumnHeader.tsx
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/datagrid-web/src/features/column/HeaderDragnDrop.viewModel.ts
Show resolved
Hide resolved
iobuhov
reviewed
Nov 27, 2025
packages/pluggableWidgets/datagrid-web/src/components/ColumnContainer.tsx
Outdated
Show resolved
Hide resolved
iobuhov
force-pushed
the
iobuhov_next
branch
from
e430570 to
e3a73dd
Compare
yordan-st
force-pushed
the
feat/WC-1784_DG-coldrag-enhance
branch
from
7bb9a06 to
fba291a
Compare
…lified architecture
yordan-st
force-pushed
the
feat/WC-1784_DG-coldrag-enhance
branch
from
75213b1 to
bb74b16
Compare
iobuhov
reviewed
Nov 28, 2025
packages/modules/data-widgets/src/themesource/datawidgets/web/_datagrid.scss
Show resolved
Hide resolved
iobuhov
reviewed
Nov 28, 2025
packages/pluggableWidgets/datagrid-web/src/model/hooks/injection-hooks.ts
Outdated
Show resolved
Hide resolved
iobuhov
reviewed
Nov 28, 2025
iobuhov
reviewed
Nov 28, 2025
iobuhov
reviewed
Nov 28, 2025
packages/pluggableWidgets/datagrid-web/src/features/column/HeaderDragnDrop.viewModel.ts
Show resolved
Hide resolved
iobuhov
reviewed
Nov 28, 2025
packages/pluggableWidgets/datagrid-web/src/model/containers/Datagrid.container.ts
Outdated
Show resolved
Hide resolved
iobuhov
requested changes
Nov 28, 2025
packages/pluggableWidgets/datagrid-web/src/features/column/HeaderDragnDrop.viewModel.ts
Outdated
Show resolved
Hide resolved
iobuhov
requested changes
Nov 28, 2025
| } | ||
|
|
||
| export const ColumnHeader = observer(function ColumnHeader(): ReactElement { | ||
| const { header, canSort, alignment, toggleSort } = useColumn(); |
Collaborator
There was a problem hiding this comment.
toggleSort will break.
replace with this:
const { header, canSort, alignement } = column
...
getSortProps(() => column.toggleSort)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Description
TODO
features/column