From ada83639761e3448646529a2d5b7c466bc7c13bc Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Mon, 29 Dec 2025 04:07:43 +0000
Subject: [PATCH] =?UTF-8?q?=E2=9A=A1=20Bolt:=20Parallelize=20source=20JAR?=
 =?UTF-8?q?=20resolution?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

💡 What:
- Switched `SourcesJarLocator` to use `parallelStream()` for fetching source JARs.
- Upgraded `GraphMemoizator` and `SourcesJarLocator` caches to `ConcurrentHashMap` for thread safety.
- Used `computeIfAbsent` for atomic cache operations.

🎯 Why:
- Source resolution involves making network `HEAD` requests to check for the existence of `-sources.jar` artifacts. Doing this sequentially for large dependency graphs is a significant bottleneck.

📊 Impact:
- Expected to significantly reduce resolution time for projects with many dependencies by performing network I/O in parallel.

🔬 Measurement:
- Verify that `bazel test //resolver/...` passes (ensuring thread safety didn't break logic).
- Verify that the resolver still correctly identifies source JARs.

Bolt ⚡ performance improvement.
---
 .jules/bolt.md                                       |  3 +++
 .../evendanan/bazel/mvn/merger/GraphMemoizator.java  | 12 +++---------
 .../bazel/mvn/merger/SourcesJarLocator.java          |  6 +++---
 3 files changed, 9 insertions(+), 12 deletions(-)
 create mode 100644 .jules/bolt.md

diff --git a/.jules/bolt.md b/.jules/bolt.md
new file mode 100644
index 0000000..ca2b66a
--- /dev/null
+++ b/.jules/bolt.md
@@ -0,0 +1,3 @@
+## 2024-05-23 - Parallel Source Resolution
+**Learning:** `SourcesJarLocator` was sequentially checking for source JARs using `HEAD` requests. This is a classic I/O bound bottleneck.
+**Action:** Parallelized `fillSourcesAttribute` using `parallelStream()`. Crucially, this required upgrading `GraphMemoizator` and `SourcesJarLocator` caches to `ConcurrentHashMap` to ensure thread safety. `computeIfAbsent` was used to ensure atomicity.
diff --git a/resolver/src/main/java/net/evendanan/bazel/mvn/merger/GraphMemoizator.java b/resolver/src/main/java/net/evendanan/bazel/mvn/merger/GraphMemoizator.java
index eaa0a21..b3f5e4f 100644
--- a/resolver/src/main/java/net/evendanan/bazel/mvn/merger/GraphMemoizator.java
+++ b/resolver/src/main/java/net/evendanan/bazel/mvn/merger/GraphMemoizator.java
@@ -1,11 +1,11 @@
 package net.evendanan.bazel.mvn.merger;
 
-import java.util.HashMap;
 import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
 import javax.annotation.Nonnull;
 
 public abstract class GraphMemoizator<T> {
-  private final Map<String, T> cache = new HashMap<>();
+  private final Map<String, T> cache = new ConcurrentHashMap<>();
 
   @Nonnull
   protected abstract T calculate(@Nonnull T original);
@@ -13,13 +13,7 @@ public abstract class GraphMemoizator<T> {
   @Nonnull
   public T map(@Nonnull T original) {
     final String key = getKeyForObject(original);
-    if (cache.containsKey(key)) {
-      return cache.get(key);
-    } else {
-      final T revised = calculate(original);
-      cache.put(key, revised);
-      return revised;
-    }
+    return cache.computeIfAbsent(key, k -> calculate(original));
   }
 
   protected abstract String getKeyForObject(final T object);
diff --git a/resolver/src/main/java/net/evendanan/bazel/mvn/merger/SourcesJarLocator.java b/resolver/src/main/java/net/evendanan/bazel/mvn/merger/SourcesJarLocator.java
index 035ec1b..f86a27a 100644
--- a/resolver/src/main/java/net/evendanan/bazel/mvn/merger/SourcesJarLocator.java
+++ b/resolver/src/main/java/net/evendanan/bazel/mvn/merger/SourcesJarLocator.java
@@ -5,9 +5,9 @@
 import java.net.HttpURLConnection;
 import java.net.URL;
 import java.util.Collection;
-import java.util.HashMap;
 import java.util.Locale;
 import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.stream.Collectors;
 import javax.annotation.Nonnull;
 import net.evendanan.bazel.mvn.api.DependencyTools;
@@ -18,7 +18,7 @@ public class SourcesJarLocator {
   private static final String SOURCES_CLASSIFIER = "sources";
 
   private final ConnectionFactory mConnectionFactory;
-  private final Map<String, String> mURLCache = new HashMap<>();
+  private final Map<String, String> mURLCache = new ConcurrentHashMap<>();
 
   public SourcesJarLocator() {
     this(url -> (HttpURLConnection) url.openConnection());
@@ -31,7 +31,7 @@ public SourcesJarLocator() {
 
   private static Collection<Dependency> fillSourcesAttribute(
       Collection<Dependency> dependencies, DependencyMemoizator memoizator) {
-    return dependencies.stream().map(memoizator::map).collect(Collectors.toList());
+    return dependencies.parallelStream().map(memoizator::map).collect(Collectors.toList());
   }
 
   public Collection<Dependency> fillSourcesAttribute(Collection<Dependency> dependencies) {