Commit 8fbdba7
authored
Fix stride computation formula used during compute estimation (#42)
Turns out the previous PR
#37
was not correct. It divided the wrong dim's stride.
This PR divides the dim to the left of the one being sharded, which is
what really happens.
Note: that we have this util at all is worrying me. Why don't we just
use dtensors to propagate?1 parent 233d68b commit 8fbdba7
1 file changed
+4
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
169 | 169 | | |
170 | 170 | | |
171 | 171 | | |
172 | | - | |
173 | | - | |
174 | | - | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
175 | 176 | | |
176 | 177 | | |
177 | 178 | | |
| |||
0 commit comments