Skip to content

Commit 615798d

Browse files
siyengarmeta-codesync[bot]
siyengar
authored and
meta-codesync[bot]
committed
fix lint with reduceop (#38)
Summary: Pull Request resolved: #38 pass reduce op by const ref instead of copying it. This fixes the lint issues Reviewed By: d4l3k Differential Revision: D86011312 fbshipit-source-id: 2d5b7e4525af39e2c65242aa9c1bc321928c82db
1 parent 7b52531 commit 615798d

File tree

13 files changed

+65
-65
lines changed

13 files changed

+65
-65
lines changed

‎comms/torchcomms/TorchComm.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ c10::intrusive_ptr<TorchWork> TorchComm::broadcast(
6666

6767
c10::intrusive_ptr<TorchWork> TorchComm::all_reduce(
6868
at::Tensor& tensor,
69-
ReduceOp op,
69+
const ReduceOp& op,
7070
bool async_op,
7171
const AllReduceOptions& options) {
7272
return impl_->all_reduce(tensor, op, async_op, options);
@@ -75,7 +75,7 @@ c10::intrusive_ptr<TorchWork> TorchComm::all_reduce(
7575
c10::intrusive_ptr<TorchWork> TorchComm::reduce(
7676
const at::Tensor& tensor,
7777
int root,
78-
ReduceOp op,
78+
const ReduceOp& op,
7979
bool async_op,
8080
const ReduceOptions& options) {
8181
return impl_->reduce(tensor, root, op, async_op, options);
@@ -108,7 +108,7 @@ c10::intrusive_ptr<TorchWork> TorchComm::all_gather_single(
108108
c10::intrusive_ptr<TorchWork> TorchComm::reduce_scatter(
109109
at::Tensor& output,
110110
const std::vector<at::Tensor>& input_list,
111-
ReduceOp op,
111+
const ReduceOp& op,
112112
bool async_op,
113113
const ReduceScatterOptions& options) {
114114
return impl_->reduce_scatter(output, input_list, op, async_op, options);
@@ -117,7 +117,7 @@ c10::intrusive_ptr<TorchWork> TorchComm::reduce_scatter(
117117
c10::intrusive_ptr<TorchWork> TorchComm::reduce_scatter_v(
118118
at::Tensor& output,
119119
const std::vector<at::Tensor>& input_list,
120-
ReduceOp op,
120+
const ReduceOp& op,
121121
bool async_op,
122122
const ReduceScatterOptions& options) {
123123
return impl_->reduce_scatter_v(output, input_list, op, async_op, options);
@@ -126,7 +126,7 @@ c10::intrusive_ptr<TorchWork> TorchComm::reduce_scatter_v(
126126
c10::intrusive_ptr<TorchWork> TorchComm::reduce_scatter_single(
127127
at::Tensor& output,
128128
const at::Tensor& input,
129-
ReduceOp op,
129+
const ReduceOp& op,
130130
bool async_op,
131131
const ReduceScatterSingleOptions& options) {
132132
return impl_->reduce_scatter_single(output, input, op, async_op, options);

‎comms/torchcomms/TorchComm.hpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,13 @@ class TorchComm {
5151
const BroadcastOptions& options = {});
5252
c10::intrusive_ptr<TorchWork> all_reduce(
5353
at::Tensor& tensor,
54-
ReduceOp op,
54+
const ReduceOp& op,
5555
bool async_op,
5656
const AllReduceOptions& options = {});
5757
c10::intrusive_ptr<TorchWork> reduce(
5858
const at::Tensor& tensor,
5959
int root,
60-
ReduceOp op,
60+
const ReduceOp& op,
6161
bool async_op,
6262
const ReduceOptions& options = {});
6363
c10::intrusive_ptr<TorchWork> all_gather(
@@ -78,19 +78,19 @@ class TorchComm {
7878
c10::intrusive_ptr<TorchWork> reduce_scatter(
7979
at::Tensor& output,
8080
const std::vector<at::Tensor>& input_list,
81-
ReduceOp op,
81+
const ReduceOp& op,
8282
bool async_op,
8383
const ReduceScatterOptions& options = {});
8484
c10::intrusive_ptr<TorchWork> reduce_scatter_v(
8585
at::Tensor& output,
8686
const std::vector<at::Tensor>& input_list,
87-
ReduceOp op,
87+
const ReduceOp& op,
8888
bool async_op,
8989
const ReduceScatterOptions& options = {});
9090
c10::intrusive_ptr<TorchWork> reduce_scatter_single(
9191
at::Tensor& output,
9292
const at::Tensor& input,
93-
ReduceOp op,
93+
const ReduceOp& op,
9494
bool async_op,
9595
const ReduceScatterSingleOptions& options = {});
9696
c10::intrusive_ptr<TorchWork> all_to_all_single(

‎comms/torchcomms/TorchCommBackend.hpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,13 @@ class TorchCommBackend {
6464
const BroadcastOptions& options = {}) = 0;
6565
virtual c10::intrusive_ptr<TorchWork> all_reduce(
6666
at::Tensor& tensor,
67-
ReduceOp op,
67+
const ReduceOp& op,
6868
bool async_op,
6969
const AllReduceOptions& options = {}) = 0;
7070
virtual c10::intrusive_ptr<TorchWork> reduce(
7171
const at::Tensor& tensor,
7272
int root,
73-
ReduceOp op,
73+
const ReduceOp& op,
7474
bool async_op,
7575
const ReduceOptions& options = {}) = 0;
7676
virtual c10::intrusive_ptr<TorchWork> all_gather(
@@ -91,19 +91,19 @@ class TorchCommBackend {
9191
virtual c10::intrusive_ptr<TorchWork> reduce_scatter(
9292
at::Tensor& output,
9393
const std::vector<at::Tensor>& input_list,
94-
ReduceOp op,
94+
const ReduceOp& op,
9595
bool async_op,
9696
const ReduceScatterOptions& options = {}) = 0;
9797
virtual c10::intrusive_ptr<TorchWork> reduce_scatter_v(
9898
at::Tensor& output,
9999
const std::vector<at::Tensor>& input_list,
100-
ReduceOp op,
100+
const ReduceOp& op,
101101
bool async_op,
102102
const ReduceScatterOptions& options = {}) = 0;
103103
virtual c10::intrusive_ptr<TorchWork> reduce_scatter_single(
104104
at::Tensor& output,
105105
const at::Tensor& input,
106-
ReduceOp op,
106+
const ReduceOp& op,
107107
bool async_op,
108108
const ReduceScatterSingleOptions& options = {}) = 0;
109109
virtual c10::intrusive_ptr<TorchWork> all_to_all_single(

‎comms/torchcomms/gloo/TorchCommGloo.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ c10::intrusive_ptr<TorchWork> TorchCommGloo::broadcast(
553553

554554
c10::intrusive_ptr<TorchWork> TorchCommGloo::all_reduce(
555555
at::Tensor& tensor,
556-
ReduceOp op,
556+
const ReduceOp& op,
557557
bool async_op,
558558
const AllReduceOptions& options) {
559559
checkInitialized();
@@ -597,7 +597,7 @@ c10::intrusive_ptr<TorchWork> TorchCommGloo::all_reduce(
597597
c10::intrusive_ptr<TorchWork> TorchCommGloo::reduce(
598598
const at::Tensor& tensor,
599599
int root,
600-
ReduceOp op,
600+
const ReduceOp& op,
601601
bool async_op,
602602
const ReduceOptions& options) {
603603
checkInitialized();
@@ -782,7 +782,7 @@ c10::intrusive_ptr<TorchWork> TorchCommGloo::all_gather_single(
782782
c10::intrusive_ptr<TorchWork> TorchCommGloo::reduce_scatter(
783783
at::Tensor& output,
784784
const std::vector<at::Tensor>& input_list,
785-
ReduceOp op,
785+
const ReduceOp& op,
786786
bool async_op,
787787
const ReduceScatterOptions& options) {
788788
checkInitialized();
@@ -818,7 +818,7 @@ c10::intrusive_ptr<TorchWork> TorchCommGloo::reduce_scatter(
818818
c10::intrusive_ptr<TorchWork> TorchCommGloo::reduce_scatter_v(
819819
at::Tensor& output,
820820
const std::vector<at::Tensor>& input_list,
821-
ReduceOp op,
821+
const ReduceOp& op,
822822
bool async_op,
823823
const ReduceScatterOptions& options) {
824824
throw std::runtime_error(
@@ -828,7 +828,7 @@ c10::intrusive_ptr<TorchWork> TorchCommGloo::reduce_scatter_v(
828828
c10::intrusive_ptr<TorchWork> TorchCommGloo::reduce_scatter_single(
829829
at::Tensor& output,
830830
const at::Tensor& input,
831-
ReduceOp op,
831+
const ReduceOp& op,
832832
bool async_op,
833833
const ReduceScatterSingleOptions& options) {
834834
checkInitialized();

‎comms/torchcomms/gloo/TorchCommGloo.hpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,13 @@ class TorchCommGloo : public TorchCommBackend,
7676
const BroadcastOptions& options = {}) override;
7777
c10::intrusive_ptr<TorchWork> all_reduce(
7878
at::Tensor& tensor,
79-
ReduceOp op,
79+
const ReduceOp& op,
8080
bool async_op,
8181
const AllReduceOptions& options = {}) override;
8282
c10::intrusive_ptr<TorchWork> reduce(
8383
const at::Tensor& tensor,
8484
int root,
85-
ReduceOp op,
85+
const ReduceOp& op,
8686
bool async_op,
8787
const ReduceOptions& options = {}) override;
8888
c10::intrusive_ptr<TorchWork> all_gather(
@@ -103,19 +103,19 @@ class TorchCommGloo : public TorchCommBackend,
103103
c10::intrusive_ptr<TorchWork> reduce_scatter(
104104
at::Tensor& output,
105105
const std::vector<at::Tensor>& input_list,
106-
ReduceOp op,
106+
const ReduceOp& op,
107107
bool async_op,
108108
const ReduceScatterOptions& options = {}) override;
109109
c10::intrusive_ptr<TorchWork> reduce_scatter_v(
110110
at::Tensor& output,
111111
const std::vector<at::Tensor>& input_list,
112-
ReduceOp op,
112+
const ReduceOp& op,
113113
bool async_op,
114114
const ReduceScatterOptions& options = {}) override;
115115
c10::intrusive_ptr<TorchWork> reduce_scatter_single(
116116
at::Tensor& output,
117117
const at::Tensor& input,
118-
ReduceOp op,
118+
const ReduceOp& op,
119119
bool async_op,
120120
const ReduceScatterSingleOptions& options = {}) override;
121121
c10::intrusive_ptr<TorchWork> all_to_all_single(

‎comms/torchcomms/nccl/TorchCommNCCL.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ c10::intrusive_ptr<TorchWork> TorchCommNCCL::broadcast(
548548

549549
c10::intrusive_ptr<TorchWork> TorchCommNCCL::all_reduce(
550550
at::Tensor& tensor,
551-
ReduceOp op,
551+
const ReduceOp& op,
552552
bool async_op,
553553
const AllReduceOptions& options) {
554554
checkInitialized();
@@ -590,7 +590,7 @@ c10::intrusive_ptr<TorchWork> TorchCommNCCL::all_reduce(
590590
c10::intrusive_ptr<TorchWork> TorchCommNCCL::reduce(
591591
const at::Tensor& tensor,
592592
int root,
593-
ReduceOp op,
593+
const ReduceOp& op,
594594
bool async_op,
595595
const ReduceOptions& options) {
596596
checkInitialized();
@@ -746,7 +746,7 @@ c10::intrusive_ptr<TorchWork> TorchCommNCCL::all_gather_single(
746746
c10::intrusive_ptr<TorchWork> TorchCommNCCL::reduce_scatter(
747747
at::Tensor& output,
748748
const std::vector<at::Tensor>& input_list,
749-
ReduceOp op,
749+
const ReduceOp& op,
750750
bool async_op,
751751
const ReduceScatterOptions& options) {
752752
checkInitialized();
@@ -821,7 +821,7 @@ c10::intrusive_ptr<TorchWork> TorchCommNCCL::reduce_scatter(
821821
c10::intrusive_ptr<TorchWork> TorchCommNCCL::reduce_scatter_v(
822822
at::Tensor& output,
823823
const std::vector<at::Tensor>& input_list,
824-
ReduceOp op,
824+
const ReduceOp& op,
825825
bool async_op,
826826
const ReduceScatterOptions& options) {
827827
throw std::runtime_error("reduce_scatter_v is not supported in NCCL backend");
@@ -830,7 +830,7 @@ c10::intrusive_ptr<TorchWork> TorchCommNCCL::reduce_scatter_v(
830830
c10::intrusive_ptr<TorchWork> TorchCommNCCL::reduce_scatter_single(
831831
at::Tensor& output,
832832
const at::Tensor& input,
833-
ReduceOp op,
833+
const ReduceOp& op,
834834
bool async_op,
835835
const ReduceScatterSingleOptions& options) {
836836
checkInitialized();

‎comms/torchcomms/nccl/TorchCommNCCL.hpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,13 @@ class TorchCommNCCL : public TorchCommBackend,
9393
const BroadcastOptions& options = {}) override;
9494
c10::intrusive_ptr<TorchWork> all_reduce(
9595
at::Tensor& tensor,
96-
ReduceOp op,
96+
const ReduceOp& op,
9797
bool async_op,
9898
const AllReduceOptions& options = {}) override;
9999
c10::intrusive_ptr<TorchWork> reduce(
100100
const at::Tensor& tensor,
101101
int root,
102-
ReduceOp op,
102+
const ReduceOp& op,
103103
bool async_op,
104104
const ReduceOptions& options = {}) override;
105105
c10::intrusive_ptr<TorchWork> all_gather(
@@ -120,19 +120,19 @@ class TorchCommNCCL : public TorchCommBackend,
120120
c10::intrusive_ptr<TorchWork> reduce_scatter(
121121
at::Tensor& output,
122122
const std::vector<at::Tensor>& input_list,
123-
ReduceOp op,
123+
const ReduceOp& op,
124124
bool async_op,
125125
const ReduceScatterOptions& options = {}) override;
126126
c10::intrusive_ptr<TorchWork> reduce_scatter_v(
127127
at::Tensor& output,
128128
const std::vector<at::Tensor>& input_list,
129-
ReduceOp op,
129+
const ReduceOp& op,
130130
bool async_op,
131131
const ReduceScatterOptions& options = {}) override;
132132
c10::intrusive_ptr<TorchWork> reduce_scatter_single(
133133
at::Tensor& output,
134134
const at::Tensor& input,
135-
ReduceOp op,
135+
const ReduceOp& op,
136136
bool async_op,
137137
const ReduceScatterSingleOptions& options = {}) override;
138138
c10::intrusive_ptr<TorchWork> all_to_all_single(

‎comms/torchcomms/ncclx/TorchCommNCCLX.cpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,7 @@ c10::intrusive_ptr<TorchWork> TorchCommNCCLX::broadcast(
574574

575575
c10::intrusive_ptr<TorchWork> TorchCommNCCLX::all_reduce(
576576
at::Tensor& tensor,
577-
ReduceOp op,
577+
const ReduceOp& op,
578578
bool async_op,
579579
const AllReduceOptions& options) {
580580
checkInitialized();
@@ -617,7 +617,7 @@ c10::intrusive_ptr<TorchWork> TorchCommNCCLX::all_reduce(
617617
c10::intrusive_ptr<TorchWork> TorchCommNCCLX::reduce(
618618
const at::Tensor& tensor,
619619
int root,
620-
ReduceOp op,
620+
const ReduceOp& op,
621621
bool async_op,
622622
const ReduceOptions& options) {
623623
checkInitialized();
@@ -825,7 +825,7 @@ c10::intrusive_ptr<TorchWork> TorchCommNCCLX::all_gather_single(
825825
c10::intrusive_ptr<TorchWork> TorchCommNCCLX::reduce_scatter(
826826
at::Tensor& output,
827827
const std::vector<at::Tensor>& input_list,
828-
ReduceOp op,
828+
const ReduceOp& op,
829829
bool async_op,
830830
const ReduceScatterOptions& options) {
831831
checkInitialized();
@@ -900,7 +900,7 @@ c10::intrusive_ptr<TorchWork> TorchCommNCCLX::reduce_scatter(
900900
c10::intrusive_ptr<TorchWork> TorchCommNCCLX::reduce_scatter_v(
901901
at::Tensor& output,
902902
const std::vector<at::Tensor>& input_list,
903-
ReduceOp op,
903+
const ReduceOp& op,
904904
bool async_op,
905905
const ReduceScatterOptions& options) {
906906
checkInitialized();
@@ -980,7 +980,7 @@ c10::intrusive_ptr<TorchWork> TorchCommNCCLX::reduce_scatter_v(
980980
c10::intrusive_ptr<TorchWork> TorchCommNCCLX::reduce_scatter_single(
981981
at::Tensor& output,
982982
const at::Tensor& input,
983-
ReduceOp op,
983+
const ReduceOp& op,
984984
bool async_op,
985985
const ReduceScatterSingleOptions& options) {
986986
checkInitialized();

‎comms/torchcomms/ncclx/TorchCommNCCLX.hpp‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,13 @@ class TorchCommNCCLX : public TorchCommBackend,
9595
const BroadcastOptions& options = {}) override;
9696
c10::intrusive_ptr<TorchWork> all_reduce(
9797
at::Tensor& tensor,
98-
ReduceOp op,
98+
const ReduceOp& op,
9999
bool async_op,
100100
const AllReduceOptions& options = {}) override;
101101
c10::intrusive_ptr<TorchWork> reduce(
102102
const at::Tensor& tensor,
103103
int root,
104-
ReduceOp op,
104+
const ReduceOp& op,
105105
bool async_op,
106106
const ReduceOptions& options = {}) override;
107107
c10::intrusive_ptr<TorchWork> all_gather(
@@ -122,19 +122,19 @@ class TorchCommNCCLX : public TorchCommBackend,
122122
c10::intrusive_ptr<TorchWork> reduce_scatter(
123123
at::Tensor& output,
124124
const std::vector<at::Tensor>& input_list,
125-
ReduceOp op,
125+
const ReduceOp& op,
126126
bool async_op,
127127
const ReduceScatterOptions& options = {}) override;
128128
c10::intrusive_ptr<TorchWork> reduce_scatter_v(
129129
at::Tensor& output,
130130
const std::vector<at::Tensor>& input_list,
131-
ReduceOp op,
131+
const ReduceOp& op,
132132
bool async_op,
133133
const ReduceScatterOptions& options = {}) override;
134134
c10::intrusive_ptr<TorchWork> reduce_scatter_single(
135135
at::Tensor& output,
136136
const at::Tensor& input,
137-
ReduceOp op,
137+
const ReduceOp& op,
138138
bool async_op,
139139
const ReduceScatterSingleOptions& options = {}) override;
140140
c10::intrusive_ptr<TorchWork> all_to_all_single(

0 commit comments

Comments
 (0)