From 6a014de2b5eb232cec566e2aa8fdb7019494debf Mon Sep 17 00:00:00 2001
From: Kiuk Chung <kiuk@meta.com>
Date: Mon, 6 Oct 2025 13:48:24 -0700
Subject: [PATCH] (torchx/specs) Remove deprecated base_image attribute from
 Role (#1138)

Summary:

`role.base_image` has been marked for deprecation for a few years. Remove it.

Reviewed By: richardwang-at-fb

Differential Revision: D83780899
---
 torchx/schedulers/test/kubernetes_mcad_scheduler_test.py | 8 --------
 torchx/specs/api.py                                      | 1 -
 2 files changed, 9 deletions(-)

diff --git a/torchx/schedulers/test/kubernetes_mcad_scheduler_test.py b/torchx/schedulers/test/kubernetes_mcad_scheduler_test.py
index 38328a922..209a800c8 100644
--- a/torchx/schedulers/test/kubernetes_mcad_scheduler_test.py
+++ b/torchx/schedulers/test/kubernetes_mcad_scheduler_test.py
@@ -706,7 +706,6 @@ def test_get_role_information(
                 name="echo",
                 image="echoImage",
                 min_replicas=None,
-                base_image=None,
                 args=[
                     "bash",
                     "-c",
@@ -862,7 +861,6 @@ def test_get_role_information_no_specs(
                 name="echo",
                 image="",
                 min_replicas=None,
-                base_image=None,
                 args=[],
                 env={},
                 num_replicas=1,
@@ -926,7 +924,6 @@ def test_get_role_information_no_image_name(
                 name="echo",
                 image="",
                 min_replicas=None,
-                base_image=None,
                 args=[],
                 env={},
                 num_replicas=1,
@@ -978,7 +975,6 @@ def test_get_role_information_no_resources(
                 name="echo",
                 image="echoImage",
                 min_replicas=None,
-                base_image=None,
                 args=[
                     "bash",
                     "-c",
@@ -1045,7 +1041,6 @@ def test_get_role_information_no_cpu(
                 name="echo",
                 image="echoImage",
                 min_replicas=None,
-                base_image=None,
                 args=[
                     "bash",
                     "-c",
@@ -1112,7 +1107,6 @@ def test_get_role_information_no_memory(
                 name="echo",
                 image="echoImage",
                 min_replicas=None,
-                base_image=None,
                 args=[
                     "bash",
                     "-c",
@@ -1179,7 +1173,6 @@ def test_get_role_information_no_ports(
                 name="echo",
                 image="echoImage",
                 min_replicas=None,
-                base_image=None,
                 args=[
                     "bash",
                     "-c",
@@ -1246,7 +1239,6 @@ def test_get_role_information_no_volume_mounts(
                 name="echo",
                 image="echoImage",
                 min_replicas=None,
-                base_image=None,
                 args=[
                     "bash",
                     "-c",
diff --git a/torchx/specs/api.py b/torchx/specs/api.py
index f50bc4619..1a71ec050 100644
--- a/torchx/specs/api.py
+++ b/torchx/specs/api.py
@@ -407,7 +407,6 @@ class Role:
     name: str
     image: str
     min_replicas: Optional[int] = None
-    base_image: Optional[str] = None  # DEPRECATED DO NOT SET, WILL BE REMOVED SOON
     entrypoint: str = MISSING
     args: List[str] = field(default_factory=list)
     env: Dict[str, str] = field(default_factory=dict)