Enable and fix Java compiler warnings.

- metafacture-commons/src/main/java/org/metafacture/commons/reflection/ConfigurableClass.java:203: warning: [unchecked] unchecked method invocation: method valueOf in class Enum is applied to given types
- metafacture-biblio/src/main/java/org/metafacture/biblio/ComarcXmlHandler.java:105: warning: [fallthrough] possible fall-through into case
- metafacture-biblio/src/main/java/org/metafacture/biblio/marc21/Marc21Encoder.java:74: warning: [static] static variable should be qualified by type name, RecordFormat, instead of by an expression
- metafacture-biblio/src/main/java/org/metafacture/biblio/marc21/Marc21Encoder.java:160: warning: [static] static variable should be qualified by type name, RecordFormat, instead of by an expression
- metafacture-flowcontrol/src/test/java/org/metafacture/flowcontrol/CloseSuppressorTest.java:34: warning: [unchecked] unchecked conversion
- metafacture-formeta/src/main/java/org/metafacture/formeta/FormetaRecordsReader.java:81: warning: [fallthrough] possible fall-through into case
- metafacture-javaintegration/src/test/java/org/metafacture/javaintegration/pojo/PojoEncoderTest.java:260: warning: [unchecked] unchecked cast
- metafacture-xml/src/test/java/org/metafacture/xml/GenericXMLHandlerTest.java:50: warning: [deprecation] GenericXmlHandler(String) in GenericXmlHandler has been deprecated

Author: blackwinter

build.gradle

@@ -64,8 +64,14 @@ subprojects {
   targetCompatibility = 1.8
 
   tasks.withType(JavaCompile) {
+    'all -processing -rawtypes -serial'.split().each {
+        options.compilerArgs << "-Xlint:${it}"
+    }
+
+    options.compilerArgs << '-Werror'
     options.encoding = 'UTF-8'
   }
+
   task sourceJar(type: Jar) {
     dependsOn tasks.classes
     from sourceSets.main.allJava

metafacture-biblio/src/main/java/org/metafacture/biblio/ComarcXmlHandler.java

@@ -89,6 +89,7 @@ else if (RECORD.equals(localName) && NAMESPACE.equals(uri)) {
     }
 
     @Override
+    @SuppressWarnings("fallthrough")
     public void endElement(final String uri, final String localName,
             final String qName) throws SAXException {
         if (SUBFIELD.equals(localName)) {

metafacture-biblio/src/main/java/org/metafacture/biblio/marc21/Marc21Encoder.java

@@ -17,6 +17,7 @@
 package org.metafacture.biblio.marc21;
 
 import org.metafacture.biblio.iso2709.RecordBuilder;
+import org.metafacture.biblio.iso2709.RecordFormat;
 import org.metafacture.framework.FluxCommand;
 import org.metafacture.framework.FormatException;
 import org.metafacture.framework.ObjectReceiver;
@@ -71,7 +72,7 @@
 public final class Marc21Encoder extends
         DefaultStreamPipe<ObjectReceiver<String>> {
 
-    private static final int NAME_LENGTH = Marc21Constants.MARC21_FORMAT.TAG_LENGTH +
+    private static final int NAME_LENGTH = RecordFormat.TAG_LENGTH +
             Marc21Constants.MARC21_FORMAT.getIndicatorLength();
 
     private final RecordBuilder builder;
@@ -157,7 +158,7 @@ private void startField(final String name) {
         if (name.length() != NAME_LENGTH) {
             throw new FormatException("invalid entity name: " + name);
         }
-        final char[] tag = new char[Marc21Constants.MARC21_FORMAT.TAG_LENGTH];
+        final char[] tag = new char[RecordFormat.TAG_LENGTH];
         final char[] indicators = new char[Marc21Constants.MARC21_FORMAT.getIndicatorLength()];
         name.getChars(0, tag.length, tag, 0);
         name.getChars(tag.length, name.length(), indicators, 0);

metafacture-commons/src/main/java/org/metafacture/commons/reflection/ConfigurableClass.java

@@ -188,7 +188,7 @@ private void applySetters(final T target, final Map<String, String> setterValues
         }
     }
 
-    private Object convertValue(final String value, final Class<?> type) {
+    private <T extends Enum<T>> Object convertValue(final String value, final Class<?> type) {
         final Object result;
 
         if (type == boolean.class) {
@@ -199,7 +199,7 @@ else if (type == int.class) {
         }
         else if (type.isEnum()) {
             @SuppressWarnings("unchecked")  // protected by type.isEnum() check
-            final Class<Enum> enumType = (Class<Enum>) type;
+            final Class<T> enumType = (Class<T>) type;
             result = Enum.valueOf(enumType, value.toUpperCase());
         }
         else {

metafacture-flowcontrol/src/test/java/org/metafacture/flowcontrol/CloseSuppressorTest.java

@@ -16,9 +16,13 @@
 
 package org.metafacture.flowcontrol;
 
+import org.junit.Rule;
 import org.junit.Test;
 import org.metafacture.framework.ObjectReceiver;
+import org.mockito.Mock;
 import org.mockito.Mockito;
+import org.mockito.junit.MockitoJUnit;
+import org.mockito.junit.MockitoRule;
 
 /**
  * Tests for class {@link CloseSuppressor}.
@@ -28,10 +32,15 @@
  */
 public final class CloseSuppressorTest {
 
+    @Rule
+    public final MockitoRule mockitoRule = MockitoJUnit.rule();
+
+    @Mock
+    private ObjectReceiver<Object> receiver;
+
     @Test
     public void testSuppression() {
         final CloseSuppressor<Object> supressor = new CloseSuppressor<>(3);
-        final ObjectReceiver<Object> receiver = Mockito.mock(ObjectReceiver.class);
         supressor.setReceiver(receiver);
         supressor.closeStream();
         supressor.closeStream();

metafacture-formeta/src/main/java/org/metafacture/formeta/FormetaRecordsReader.java

@@ -51,6 +51,7 @@ public FormetaRecordsReader() {
     }
 
     @Override // checkstyle-disable-line CyclomaticComplexity
+    @SuppressWarnings("fallthrough")
     public void process(final Reader reader) {
         assert !isClosed();
 

metafacture-javaintegration/src/test/java/org/metafacture/javaintegration/pojo/PojoEncoderTest.java

@@ -254,6 +254,7 @@ public void shouldEncodeEntityStreamToPojoWithSimplePojoMap() {
                 .stringField2);
     }
 
+    @SuppressWarnings("unchecked")
     private <T> ObjectReceiver<T> createObjectReceiverMock() {
         // There is no type safe to create a mock with Mockito#mock(Class).
         // Hence, we have to use an unchecked cast here:

metafacture-xml/src/test/java/org/metafacture/xml/GenericXMLHandlerTest.java

@@ -47,7 +47,8 @@ public final class GenericXMLHandlerTest {
     @Before
     public void setup() {
         MockitoAnnotations.initMocks(this);
-        genericXmlHandler = new GenericXmlHandler("record");
+        genericXmlHandler = new GenericXmlHandler();
+        genericXmlHandler.setRecordTagName("record");
         genericXmlHandler.setReceiver(receiver);
     }