Background
From PR #197 code review (LOW priority items).
Items
-
Rename test_create_with_type_enum — The test passes type="FEATURE" (a string), so the name is misleading. Consider renaming to test_create_with_uppercase_type_string or similar.
-
Tighten regex assertions in parent_part validation tests — The match="parent_part is required" regex could include the specific part type name (e.g., match="parent_part is required when creating a CAPABILITY") to prevent regressions that might lose type specificity in the error message.
Related
Background
From PR #197 code review (LOW priority items).
Items
Rename
test_create_with_type_enum— The test passestype="FEATURE"(a string), so the name is misleading. Consider renaming totest_create_with_uppercase_type_stringor similar.Tighten regex assertions in parent_part validation tests — The
match="parent_part is required"regex could include the specific part type name (e.g.,match="parent_part is required when creating a CAPABILITY") to prevent regressions that might lose type specificity in the error message.Related