Set defaultOptions properly

Author: micantoine

src/index.ts

@@ -4,18 +4,22 @@ import type { PluginOptions, PreprocessorOptions, PreprocessorResult } from './t
 import { nativeProcessor, mixedProcessor, scopedProcessor } from './processors';
 import { getLocalIdent, isFileIncluded, hasModuleImports, hasModuleAttribute } from './lib';
 
-let pluginOptions: PluginOptions = {
-  mode: 'native',
-  getLocalIdent,
-  hashSeeder: ['style', 'filepath', 'classname'],
-  includePaths: [],
-  includeAttributes: [],
-  localIdentName: '[local]-[hash:base64:6]',
-  parseStyleTag: true,
-  parseExternalStylesheet: false,
-  useAsDefaultScoping: false,
+const defaultOptions = (): PluginOptions => {
+  return {
+    getLocalIdent,
+    hashSeeder: ['style', 'filepath', 'classname'],
+    includeAttributes: [],
+    includePaths: [],
+    localIdentName: '[local]-[hash:base64:6]',
+    mode: 'native',
+    parseExternalStylesheet: false,
+    parseStyleTag: true,
+    useAsDefaultScoping: false,
+  };
 };
 
+let pluginOptions: PluginOptions;
+
 const markup = async ({ content, filename }: PreprocessorOptions): Promise<PreprocessorResult> => {
   const isIncluded = await isFileIncluded(pluginOptions.includePaths, filename);
 
@@ -75,10 +79,9 @@ const markup = async ({ content, filename }: PreprocessorOptions): Promise<Prepr
   };
 };
 
-// eslint-disable-next-line no-multi-assign
 export default module.exports = (options: Partial<PluginOptions>) => {
   pluginOptions = {
-    ...pluginOptions,
+    ...defaultOptions(),
     ...options,
   };
   return {

src/types/index.ts

@@ -1,14 +1,14 @@
 import type { GetLocalIdent } from '../lib';
 
 export type PluginOptions = {
-  mode: 'native' | 'mixed' | 'scoped';
+  getLocalIdent: GetLocalIdent;
+  hashSeeder: Array<'style' | 'filepath' | 'classname'>;
   includeAttributes: string[];
   includePaths: string[];
   localIdentName: string;
-  getLocalIdent: GetLocalIdent;
-  hashSeeder: Array<'style' | 'filepath' | 'classname'>;
-  parseStyleTag: boolean;
+  mode: 'native' | 'mixed' | 'scoped';
   parseExternalStylesheet: boolean;
+  parseStyleTag: boolean;
   useAsDefaultScoping: boolean;
 };
 

test/globalFixtures/options.test.js

@@ -50,6 +50,34 @@ describe('When the module attribute has an invalid value', () => {
   });
 });
 
+test('Use the filepath only as hash seeder', async () => {
+  const output = await compiler({
+    source: '<style module>.red { color: red; } .bold { color: bold; }</style><span class="red bold">Red</span>',
+  }, {
+    mode: 'native',
+    localIdentName: '[local]-[hash:6]',
+    hashSeeder: ['filepath'],
+  });
+
+  expect(output).toBe(
+    '<style module>:global(.red-027d15) { color: red; } :global(.bold-027d15) { color: bold; }</style><span class="red-027d15 bold-027d15">Red</span>'
+  );
+});
+
+describe('When the hashSeeder has a wrong key', () => {
+  const source = '<style module>.red { color: red; }</style>';
+
+  it('throws an exception', async () => {
+    await expect(compiler({
+      source
+    }, {
+      hashSeeder: ['filepath', 'content'],
+    })).rejects.toThrow(
+      `The hash seeder only accepts the keys 'style', 'filepath' and 'classname': 'content' was passed.`
+    );
+  });
+});
+
 describe('When the preprocessor is set as default scoping', () => {
   it('parses the style tag with no module attributes', async () => {
     const source = '<style>.red { color: red; }</style><p class="red">red</p>';
@@ -94,40 +122,10 @@ describe('When the preprocessor is set as default scoping', () => {
     const output = await compiler({
       source
     }, {
-      parseStyleTag: true,
       useAsDefaultScoping: true,
     });
 
     expect(output).toBe('<p class="red">red</p>')
   });
 });
 
-test('Use the filepath only as hash seeder', async () => {
-  const output = await compiler({
-    source: '<style module>.red { color: red; } .bold { color: bold; }</style><span class="red bold">Red</span>',
-  }, {
-    mode: 'native',
-    localIdentName: '[local]-[hash:6]',
-    hashSeeder: ['filepath'],
-  });
-
-  expect(output).toBe(
-    '<style module>:global(.red-027d15) { color: red; } :global(.bold-027d15) { color: bold; }</style><span class="red-027d15 bold-027d15">Red</span>'
-  );
-});
-
-describe('When the hashSeeder has a wrong key', () => {
-  const source = '<style module>.red { color: red; }</style>';
-
-  it('throws an exception', async () => {
-    await expect(compiler({
-      source
-    }, {
-      hashSeeder: ['filepath', 'content'],
-    })).rejects.toThrow(
-      `The hash seeder only accepts the keys 'style', 'filepath' and 'classname': 'content' was passed.`
-    );
-  });
-});
-
-