Adding mongodb realization for undo #8
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| import java.time.LocalDateTime; | ||
|
|
||
| @Data | ||
| @Builder |
There was a problem hiding this comment.
SameNameButDifferent: The name @Builder refers to [java.lang.SuppressWarnings, java.lang.String, java.time.LocalDateTime, dev.fomenko.springundomongo.RecordEntity.RecordEntityBuilder, dev.fomenko.springundomongo.RecordEntity, java.lang.Override] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.
| @Builder | |
| RecordEntity.@Builder |
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| import java.time.LocalDateTime; | ||
|
|
||
| @Data |
There was a problem hiding this comment.
SameNameButDifferent: The name @Data refers to [java.lang.SuppressWarnings, java.lang.String, java.time.LocalDateTime, java.lang.Override, java.lang.Object] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
|
|
||
| @CommonsLog | ||
| @RequiredArgsConstructor |
There was a problem hiding this comment.
SameNameButDifferent: The name @RequiredArgsConstructor refers to [java.lang.SuppressWarnings, org.springframework.data.mongodb.core.MongoTemplate] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| import java.util.stream.Collectors; | ||
|
|
||
|
|
||
| @CommonsLog |
There was a problem hiding this comment.
SameNameButDifferent: The name @CommonsLog refers to [java.lang.SuppressWarnings, org.apache.commons.logging.Log, org.apache.commons.logging.LogFactory] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
|
|
||
| @Data | ||
| @Builder | ||
| @AllArgsConstructor |
There was a problem hiding this comment.
SameNameButDifferent: The name @AllArgsConstructor refers to [java.lang.SuppressWarnings, java.lang.String, java.time.LocalDateTime] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @Document | ||
| public class RecordEntity<T> { | ||
| @Id | ||
| private String recordId; |
There was a problem hiding this comment.
SameNameButDifferent: The name recordId; refers to [java.lang.SuppressWarnings, java.lang.String] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| import java.time.LocalDateTime; | ||
|
|
||
| @Data | ||
| @Builder |
There was a problem hiding this comment.
MissingSummary: A summary fragment is required; consider using the value of the @return block as a summary fragment instead.
| @Builder | |
| Returns {@code this}. |
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| @Id | ||
| private String recordId; | ||
| private T action; | ||
| private LocalDateTime expiresAt; |
There was a problem hiding this comment.
SameNameButDifferent: The name expiresAt; refers to [java.lang.SuppressWarnings, java.time.LocalDateTime] within this file. It may be confusing to have the same name refer to multiple types. Consider qualifying them for clarity.
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
| compileOnly("org.springframework.boot:spring-boot-starter-data-mongodb:${Versions.springBootVersion}") | ||
| compileOnly(project(":spring-undo-core")) | ||
|
|
||
| testImplementation("org.springframework.boot:spring-boot-starter-data-mongodb:${Versions.springBootVersion}") |
There was a problem hiding this comment.
Critical OSS Vulnerability:
pkg:maven/org.springframework.boot/spring-boot-starter-data-mongodb@2.6.7
1 Critical, 1 Severe, 0 Moderate, 0 Unknown vulnerabilities have been found across 2 dependencies
Components
pkg:maven/org.springframework/spring-beans@5.3.19
SEVERE Vulnerabilities (1)
[CVE-2022-22970] CWE-770: Allocation of Resources Without Limits or Throttling
In spring framework versions prior to 5.3.20+ , 5.2.22+ and old unsupported versions, applications that handle file uploads are vulnerable to DoS attack if they rely on data binding to set a MultipartFile or javax.servlet.Part to a field in a model object.
CVSS Score: 5.3
CVSS Vector: CVSS:3.1/AV:N/AC:H/PR:L/UI:N/S:U/C:N/I:N/A:H
CWE: CWE-770
pkg:maven/org.springframework.data/spring-data-mongodb@3.3.4
CRITICAL Vulnerabilities (1)
[CVE-2022-22980] CWE-917: Improper Neutralization of Special Elements used in an Expression Language Statement ('Expression Language Injection')
A Spring Data MongoDB application is vulnerable to SpEL Injection when using @query or @Aggregation-annotated query methods with SpEL expressions that contain query parameter placeholders for value binding if the input is not sanitized.
CVSS Score: 9
CVSS Vector: CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:C/C:H/I:H/A:H
CWE: CWE-917
Reply with "@sonatype-lift help" for info about LiftBot commands.
Reply with "@sonatype-lift ignore" to tell LiftBot to leave out the above finding from this PR.
Reply with "@sonatype-lift ignoreall" to tell LiftBot to leave out all the findings from this PR and from the status bar in Github.
When talking to LiftBot, you need to refresh the page to see its response. Click here to get to know more about LiftBot commands.
Was this a good recommendation?
[ 🙁 Not relevant ] - [ 😕 Won't fix ] - [ 😑 Not critical, will fix ] - [ 🙂 Critical, will fix ] - [ 😊 Critical, fixing now ]
1 participant
No description provided.