Alpha from range check doesn't work in combat

[m33shoq]

I've tried different check types here 38m/99m/heal as well as creating new profiles from default presets

As soon as I enter combat all frames become non faded

Can provide more info if needed

[michaelnpsp]

Strange i have no other reports, and this should be an obvious issue for everyone.
Grid2 version ?
Game version beta, ptr or live ?
Class played and spec/talents ?
Type of content ?
Does this happen even on a training dummy or in open world ?
Any LUA error ?
Can you test the client in english to see if it makes any difference ?

[m33shoq]

Grid2 v3.0.19

Retail, but I remember this was an issue during raid testing on beta as well
Attaching a vod from beta testing but can't confirm which version I had at the time, date is Jan 23
https://www.youtube.com/live/AJPM2unUK9g?si=dH_m7OYNRT6c8KmU&t=5996
At the linked timing after messing with edit mode I've spawned default raid frames and you can see that half the raid is in another phase(raid is split after people do the soak), default frames properly reflect that as out of range

After a bit of digging I figured out that it doesn't work only on my warrior, hunter and dh, other classes are fine. Following the code there are missing friendly range check spells for those classes. And if there is no friendly spell to check range with it just falls to InCombatLockdown()

	elseif playerClass == 'WARRIOR' then
		getHostile  = function() return 355 end  -- Taunt
		getFriendly = function() return nil end  -- no avail
	elseif playerClass == 'DEMONHUNTER' then
		getHostile  = function() return 185123 end -- Throw Glaive
		getFriendly = function() return nil    end -- no avail
	elseif playerClass == 'HUNTER' then
		getHostile  = function() return IVS(193455) or IVS(19434) or IVS(132031) end -- Cobra Shot, Aimed Short, Steady shot
		getFriendly = function() return nil end -- no avail

On retail I only tested in raid and open world but behavior is the same across those.

Attaching a video where I do following steps

1. Create a new Grid2 profile from modern preset(default range check here is 38m)
2. Reload to ensure everything is applied
3. Enter combat with dummy

As soon as I enter combat frame of the rogue in my group which is in ogrimmar at the moment becomes unfaded.

The only loaded addon was Grid2 and its modules

https://www.youtube.com/watch?v=P7pBPR3s1ME

If you don't have good ways to make your range check method work UnitInRange returns secrets but works for all classes. You can use that to set alpha with Region:SetAlphaFromBooleanor or C_CurveUtil.EvaluateColorValueFromBoolean + SetAlpha

[m33shoq]

Should I still try to test it with english client?

[m33shoq]

Another note is that I've only tested on

• warrior, hunter, dh (not working)
• dk, paladin (works fine)

[michaelnpsp]

The issue is that UnitInRange() breaks the statuses priority (when several statuses are asigned to the same indicator, the active status with higher priority is used but now i cannot check if a status is active or not if the status has a secret activation): i have yet to refactor some code to make grid2 work with secrets activations, another issue is that UnitInRange() does not work with non-grouped units.
Status range is not the only code that barelly works, unfortunatelly the midnight restrictions broke some of the basic designs of the addon, so i have to redesign/refactor some internal/critical parts and i have yet to find a good way to do this without breaking old profiles.

[m33shoq]

Priority thing is kinda solvable by C_CurveUtil.EvaluateColorValueFromBoolean if your statuses may be represented by booleans as you can chain calls here.

Lets say you have 3 statuses attached to the indicator that which can be represented by booleans

local function evaluateStatuses(statuses)	
	local alpha = 1 -- default to full alpha
	
	for i, state in ipairs_reverse(statuses) do
		if state.when == true then
			alpha = C_CurveUtil.EvaluateColorValueFromBoolean(state.bool, state.alpha, alpha)
		else
			alpha = C_CurveUtil.EvaluateColorValueFromBoolean(state.bool, alpha, state.alpha)
		end
	end
	return alpha
end

local statuses1 = {
    {bool = true, when = false, alpha = 0.5}, -- unit in range, priority 1
    {bool = false, when = true, alpha = 0.4}, -- unit is dead, priority 2
    {bool = true, when = false, alpha = 0.3}, -- unit is connected, priority 3
}

print("Example 1:", evaluateStatuses(statuses1)) -- 1, all statuses are inactive

local statuses2 = {
    {bool = false, when = false, alpha = 0.5}, -- unit in range, priority 1
    {bool = true, when = true, alpha = 0.4}, -- unit is dead, priority 2
    {bool = false, when = false, alpha = 0.3}, -- unit is connected, priority 3
}

print("Example 2:", evaluateStatuses(statuses2)) -- 0.5, out of range has highest priority than dead/connected

local statuses3 = {
    {bool = true, when = false, alpha = 0.5}, -- unit in range, priority 1
    {bool = true, when = true, alpha = 0.4}, -- unit is dead, priority 2
    {bool = false, when = false, alpha = 0.3}, -- unit is connected, priority 3
}

print("Example 3:", evaluateStatuses(statuses3)) -- 0.4, dead is the only active status

local statuses4 = {
    {bool = true, when = false, alpha = 0.5}, -- unit in range, priority 1
    {bool = false, when = true, alpha = 0.4}, -- unit is dead, priority 2
    {bool = false, when = false, alpha = 0.3}, -- unit is connected, priority 3
}

print("Example 4:", evaluateStatuses(statuses4)) -- 0.3, offline has the lowest priority but other statuses are inactive

It works with both secret and non secret booleans

Totally understand the need to refactor stuff, having to jump through those hoops is such a shame for the state of api...

[michaelnpsp]

Its not so simple, the status activation checks are not used only to assign colors, it is a general design/common code used to decide a lot of things, about texts, bars, load conditions.
I canot rewrite almost the whole addon, i have not enough time to do that, so my approach now is to do small changes trying to not break too many things.

[michaelnpsp]

For future reference:
My original plan, when i fixed the range status to at least not crash in midnight, was to implement an additional range status because, using UnitInRange should be more simple and efficient: less code and event driven so not need a timer to update all units.
Unfortunatelly i found a big issue, i need to negate the UnitInRange() return value inside status:IsActive() to make the status compatible with the currently implemented indicators and with older profiles.
So i am going to delay this. The current system is not perfect but anyway not many dps are using grid2, and I have a lot of other issues to fix.

[michaelnpsp]

First try to refactor this shxt:

UNIT_IN_RANGE_UPDATE is not fired when used with RegisterEvent(), only with RegisterUnitEvent().
But in Grid2 design statuses dont know about unit frames so they dont register events for specific units, maybe i have to use the standard timer, but UnitInRange() is secret so i cannot use a cache to avoid updating indicators ton of times per second. So performance wise this is even worse than old system.

Ironically, the refactored code is even more complex than before, because UnitInRange() does not work in a lot of cases: for non-grouped units, non friendly units, pets, for the player if not in group, etc, so i have to rely on spells checks and use a timer anyway for non-grouped/enemy units.

Options:

• Stop wasting time with this and use the old code.
• Write a new api/library to implement a new RegisterEvent() using RegisterUnitEvent(), creating lot of hidden frames to register all units of the grid2 roster.

[michaelnpsp]

Refactored alpha and range status in version 3.0.25-beta. Now 38 yards range uses UnitInRange for grouped units.
Probably i have yet to fix some edge cases like checking range for player pet when player is not in group (this is a very old bug in UnitInRange() that i don't know if it was fixed).

[m33shoq]

Can confirm that pet part is still not fixed

[michaelnpsp]

Version 3.0.30-beta should fix the pet issue.
This version uses UnitInRange() if player is in group and a pet spell check (like mend pet) when the player is solo.