From 6508565fbf3d0e02f7aba5dac5d6a82dd0bb27bd Mon Sep 17 00:00:00 2001 From: Iskander Sharipov Date: Wed, 3 Oct 2018 01:40:27 +0300 Subject: [PATCH] plugins: simplify `x = x y` to `x = y` For `x += 1` do a further simplifications to `x++`. https://open.microsoft.com/2018/09/30/join-hacktoberfest-2018-celebration-microsoft Signed-off-by: Iskander Sharipov --- plugins/gpuschedulerplugin/gpu.go | 2 +- plugins/nvidiagpuplugin/gpu/nvidia/nvidia_gpu_manager_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/plugins/gpuschedulerplugin/gpu.go b/plugins/gpuschedulerplugin/gpu.go index feb4ce84..01f10ef7 100644 --- a/plugins/gpuschedulerplugin/gpu.go +++ b/plugins/gpuschedulerplugin/gpu.go @@ -192,7 +192,7 @@ func assignGPUs(node *sctypes.SortedTreeNode, prefix string, resourceGrp string, for i := 0; i < toTake; i++ { resList[types.ResourceName(prefix+"/"+resource+"/"+strconv.Itoa(i)+"/"+suffix)] = 1 } - *numLeft = *numLeft - toTake + *numLeft -= toTake } else { for i, child := range node.Child { newPrefix := prefix + strconv.Itoa(level-1) + "/" + strconv.Itoa(i) diff --git a/plugins/nvidiagpuplugin/gpu/nvidia/nvidia_gpu_manager_test.go b/plugins/nvidiagpuplugin/gpu/nvidia/nvidia_gpu_manager_test.go index 87c4cfb0..db57ff7d 100644 --- a/plugins/nvidiagpuplugin/gpu/nvidia/nvidia_gpu_manager_test.go +++ b/plugins/nvidiagpuplugin/gpu/nvidia/nvidia_gpu_manager_test.go @@ -52,10 +52,10 @@ func checkElemEqual(t *testing.T, a1 []string, a2 []string) { a1Map := make(map[string]int) a2Map := make(map[string]int) for _, val := range a1 { - a1Map[val] = a1Map[val] + 1 + a1Map[val]++ } for _, val := range a2 { - a2Map[val] = a2Map[val] + 1 + a2Map[val]++ } if len(a1Map) != len(a2Map) { t.Errorf("Not same number of unique elements %v vs %v", len(a1Map), len(a2Map))