Merged PR 5329: Enhance datetime parsing and timestamp handling for better compatibility with...

Enhance datetime parsing and timestamp handling to support fractional second.
Return Bit in Bool format

----
#### AI description  (iteration 1)
#### PR Classification
Enhancement for datetime parsing and timestamp handling.

#### PR Summary
This pull request enhances datetime parsing and timestamp handling for better compatibility, addressing the linked work item to convert Bit to Bool and support fractional seconds for DateTime.
- `mssql_python/cursor.py`: Added support for parsing datetime strings with fractional seconds and ensured proper handling of fractional seconds.
- `mssql_python/pybind/ddbc_bindings.cpp`: Converted microseconds to nanoseconds for SQL server compatibility and vice versa, and converted SQL_BIT to boolean.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->

Related work items: #33924

Author: Ramudaykumar

mssql_python/cursor.py

@@ -104,17 +104,28 @@ def _parse_datetime(self, param):
             A datetime.datetime object if parsing is successful, else None.
         """
         formats = [
+            "%Y-%m-%dT%H:%M:%S.%f",     # ISO 8601 datetime with fractional seconds
             "%Y-%m-%dT%H:%M:%S",        # ISO 8601 datetime
             "%Y-%m-%d %H:%M:%S.%f",     # Datetime with fractional seconds (up to 3 digits)
+            "%Y-%m-%d %H:%M:%S",        # Datetime without fractional seconds
         ]
         for fmt in formats:
             try:
                 dt = datetime.datetime.strptime(param, fmt)
-                if fmt == "%Y-%m-%d %H:%M:%S.%f" and len(param.split('.')[-1]) <= 3 or fmt == "%Y-%m-%dT%H:%M:%S":
-                    return dt
+
+                # If there are fractional seconds, ensure they do not exceed 7 digits
+                if fmt in ["%Y-%m-%d %H:%M:%S.%f", "%Y-%m-%dT%H:%M:%S.%f"]:
+                    fractional_part = param.split('.')[-1]
+                    # If the fractional part is more than 3 digits, truncate to 3 digits
+                    if len(fractional_part) > 3:
+                        fractional_part = fractional_part[:3]
+                        # Convert to microseconds
+                        dt = dt.replace(microsecond=int(fractional_part.ljust(3, "0")) * 1000)
+                return dt  # Valid datetime
             except ValueError:
-                continue
-        return None
+                continue  # Try next format
+
+        return None  # If all formats fail, return None
 
     def _parse_time(self, param):
         """

mssql_python/pybind/ddbc_bindings.cpp

@@ -518,9 +518,9 @@ SQLRETURN BindParameters(SQLHANDLE hStmt, const py::list& params,
                 sqlTimestampPtr->hour = param.attr("hour").cast<int>();
                 sqlTimestampPtr->minute = param.attr("minute").cast<int>();
                 sqlTimestampPtr->second = param.attr("second").cast<int>();
-                // TODO: timestamp.fraction field seems to involve some computation.
-                // Handle this in python and pass result to pybind module?
-                sqlTimestampPtr->fraction = 0;
+                // SQL server supports in ns, but python datetime supports in µs
+                sqlTimestampPtr->fraction = static_cast<SQLUINTEGER>(
+                    param.attr("microsecond").cast<int>() * 1000);  // Convert µs to ns
                 dataPtr = static_cast<void*>(sqlTimestampPtr);
                 break;
             }
@@ -1058,7 +1058,8 @@ SQLRETURN SQLGetData_wrap(intptr_t StatementHandle, SQLUSMALLINT colCount, py::l
                             timestampValue.day,
                             timestampValue.hour,
                             timestampValue.minute,
-                            timestampValue.second
+                            timestampValue.second,
+                            timestampValue.fraction / 1000  // Convert back ns to µs
                         )
                     );
                 } else {
@@ -1356,7 +1357,7 @@ SQLRETURN FetchBatchData(SQLHSTMT hStmt, ColumnBuffers& buffers, py::list& colum
                         row.append(buffers.charBuffers[col - 1][i]);
                         break;
                     case SQL_BIT:
-                        row.append(buffers.charBuffers[col - 1][i]);
+                        row.append(static_cast<bool>(buffers.charBuffers[col - 1][i]));
                         break;
                     case SQL_REAL:
                         row.append(buffers.realBuffers[col - 1][i]);
@@ -1389,7 +1390,8 @@ SQLRETURN FetchBatchData(SQLHSTMT hStmt, ColumnBuffers& buffers, py::list& colum
                                 buffers.timestampBuffers[col - 1][i].day,
                                 buffers.timestampBuffers[col - 1][i].hour,
                                 buffers.timestampBuffers[col - 1][i].minute,
-                                buffers.timestampBuffers[col - 1][i].second
+                                buffers.timestampBuffers[col - 1][i].second,
+                                buffers.timestampBuffers[col - 1][i].fraction / 1000  // Convert back ns to µs
                             )
                         );
                         break;

tests/test_004_cursor.py

@@ -41,7 +41,7 @@
     1.23456789,
     "nvarchar data",
     time(12, 34, 56),
-    datetime(2024, 5, 20, 12, 34, 56),
+    datetime(2024, 5, 20, 12, 34, 56, 123000),
     date(2024, 5, 20),
     1.23456789
 )
@@ -51,7 +51,7 @@
     TEST_DATA,
     (2, 0, 0, 0, 0, 0, 0.0, "test1", time(0, 0, 0), datetime(2024, 1, 1, 0, 0, 0), date(2024, 1, 1), 0.0),
     (3, 1, 1, 1, 1, 1, 1.1, "test2", time(1, 1, 1), datetime(2024, 2, 2, 1, 1, 1), date(2024, 2, 2), 1.1),
-    (4, 0, 127, 32767, 9223372036854775807, 2147483647, 1.23456789, "test3", time(12, 34, 56), datetime(2024, 5, 20, 12, 34, 56), date(2024, 5, 20), 1.23456789)
+    (4, 0, 127, 32767, 9223372036854775807, 2147483647, 1.23456789, "test3", time(12, 34, 56), datetime(2024, 5, 20, 12, 34, 56, 123000), date(2024, 5, 20), 1.23456789)
 ]
 
 def drop_table_if_exists(cursor, table_name):
@@ -137,11 +137,11 @@ def test_insert_datetime_column(cursor, db_connection):
         drop_table_if_exists(cursor, "single_column")
         cursor.execute("CREATE TABLE single_column (datetime_column DATETIME)")
         db_connection.commit()
-        cursor.execute("INSERT INTO single_column (datetime_column) VALUES (?)", [datetime(2024, 5, 20, 12, 34, 56)])
+        cursor.execute("INSERT INTO single_column (datetime_column) VALUES (?)", [datetime(2024, 5, 20, 12, 34, 56, 123000)])
         db_connection.commit()
         cursor.execute("SELECT datetime_column FROM single_column")
         row = cursor.fetchone()
-        assert row[0] == datetime(2024, 5, 20, 12, 34, 56), "Datetime column insertion/fetch failed"
+        assert row[0] == datetime(2024, 5, 20, 12, 34, 56, 123000), "Datetime column insertion/fetch failed"
     except Exception as e:
         pytest.fail(f"Datetime column insertion/fetch failed: {e}")
     finally: