Skip to content

Commit eca18a0

Browse files
author
Saumya Garg
committed
resolve review comments
1 parent 085f721 commit eca18a0

File tree

1 file changed

+0
-7
lines changed

1 file changed

+0
-7
lines changed

mssql_python/pybind/ddbc_bindings.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -530,10 +530,6 @@ std::wstring LoadDriverOrThrowException() {
530530
dllDir += L"\\msodbcsql18.dll";
531531

532532
// Preload mssql-auth.dll from the same path if available
533-
<<<<<<< HEAD
534-
=======
535-
// TODO: Only load mssql-auth.dll if using Entra ID Authentication modes (Active Directory modes)
536-
>>>>>>> 25d6ef0 (refactor native layer and create reusable components)
537533
HMODULE hAuthModule = LoadLibraryW(mssqlauthDllPath.c_str());
538534
if (hAuthModule) {
539535
LOG("Authentication library loaded successfully from - {}", mssqlauthDllPath.c_str());
@@ -2147,10 +2143,7 @@ PYBIND11_MODULE(ddbc_bindings, m) {
21472143

21482144
try {
21492145
// Try loading the ODBC driver when the module is imported
2150-
<<<<<<< HEAD
21512146
LOG("Loading ODBC driver");
2152-
=======
2153-
>>>>>>> 25d6ef0 (refactor native layer and create reusable components)
21542147
DriverLoader::getInstance().loadDriver(); // Load the driver
21552148
} catch (const std::exception& e) {
21562149
// Log the error but don't throw - let the error happen when functions are called

0 commit comments

Comments
 (0)