From c7a1a89f746e9d72c3d57a6c7e58bf8b92fddb03 Mon Sep 17 00:00:00 2001 From: Holger Benl Date: Wed, 12 Nov 2025 15:44:50 +0100 Subject: [PATCH] chore(bidi): don't set Accept-Language header for a locale override --- packages/playwright-core/src/server/bidi/bidiBrowser.ts | 6 ++---- packages/playwright-core/src/server/bidi/bidiPage.ts | 2 -- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/playwright-core/src/server/bidi/bidiBrowser.ts b/packages/playwright-core/src/server/bidi/bidiBrowser.ts index d9cdc83e0e1c0..f7f102a91fac0 100644 --- a/packages/playwright-core/src/server/bidi/bidiBrowser.ts +++ b/packages/playwright-core/src/server/bidi/bidiBrowser.ts @@ -226,7 +226,7 @@ export class BidiBrowserContext extends BrowserContext { userContexts: [this._userContextId()], })); } - if (this._options.extraHTTPHeaders || this._options.locale) + if (this._options.extraHTTPHeaders) promises.push(this.doUpdateExtraHTTPHeaders()); await Promise.all(promises); } @@ -326,9 +326,7 @@ export class BidiBrowserContext extends BrowserContext { } async doUpdateExtraHTTPHeaders(): Promise { - let allHeaders = this._options.extraHTTPHeaders || []; - if (this._options.locale) - allHeaders = network.mergeHeaders([allHeaders, network.singleHeader('Accept-Language', this._options.locale)]); + const allHeaders = this._options.extraHTTPHeaders || []; await this._browser._browserSession.send('network.setExtraHeaders', { headers: allHeaders.map(({ name, value }) => ({ name, value: { type: 'string', value } })), userContexts: [this._userContextId()], diff --git a/packages/playwright-core/src/server/bidi/bidiPage.ts b/packages/playwright-core/src/server/bidi/bidiPage.ts index e2015ac12585e..9041469d57c99 100644 --- a/packages/playwright-core/src/server/bidi/bidiPage.ts +++ b/packages/playwright-core/src/server/bidi/bidiPage.ts @@ -298,11 +298,9 @@ export class BidiPage implements PageDelegate { } async updateExtraHTTPHeaders(): Promise { - const locale = this._browserContext._options.locale; const allHeaders = network.mergeHeaders([ this._browserContext._options.extraHTTPHeaders, this._page.extraHTTPHeaders(), - locale ? network.singleHeader('Accept-Language', locale) : undefined, ]); await this._session.send('network.setExtraHeaders', { headers: allHeaders.map(({ name, value }) => ({ name, value: { type: 'string', value } })),