Address feedback.

Author: cgranade

src/Simulation/qdk_sim_rs/src/linalg/array_ext.rs

@@ -10,11 +10,11 @@ use num_traits::Zero;
 
 use crate::error::QdkSimError;
 
-pub(crate) trait ShapeExt {
+pub(crate) trait ArrayBaseShapeExt {
     fn require_square(&self) -> Result<usize, QdkSimError>;
 }
 
-impl<S, D> ShapeExt for ArrayBase<S, D>
+impl<S, D> ArrayBaseShapeExt for ArrayBase<S, D>
 where
     S: RawData,
     D: Dimension,
@@ -29,15 +29,15 @@ where
     }
 }
 
-pub trait MatrixExt
+pub trait ArrayBaseMatrixExt
 where
     Self: Sized,
 {
     type Output;
     fn lower_triangular(&self) -> Self::Output;
     fn upper_triangular(&self) -> Self::Output;
 }
-impl<S, A> MatrixExt for ArrayBase<S, Ix2>
+impl<S, A> ArrayBaseMatrixExt for ArrayBase<S, Ix2>
 where
     S: Data<Elem = A>,
     A: Zero + Clone,
@@ -66,10 +66,10 @@ where
     }
 }
 
-pub(crate) trait RemoveAxisExt {
+pub(crate) trait ArrayBaseRemoveAxisExt {
     fn swap_index_axis(&mut self, axis: Axis, idx_source: usize, idx_dest: usize);
 }
-impl<S, D> RemoveAxisExt for ArrayBase<S, D>
+impl<S, D> ArrayBaseRemoveAxisExt for ArrayBase<S, D>
 where
     S: Data + DataMut,
     <S as RawData>::Elem: Clone,
@@ -88,7 +88,7 @@ where
 
 #[cfg(test)]
 mod tests {
-    use super::MatrixExt;
+    use super::ArrayBaseMatrixExt;
     use ndarray::{array, Array2};
 
     #[test]

src/Simulation/qdk_sim_rs/src/linalg/decompositions/lu.rs

@@ -9,7 +9,7 @@ use num_traits::FromPrimitive;
 
 use crate::{
     error::QdkSimError,
-    linalg::array_ext::{RemoveAxisExt, ShapeExt},
+    linalg::array_ext::{ArrayBaseRemoveAxisExt, ArrayBaseShapeExt},
 };
 
 /// Represents the output of an LU decomposition acting on a matrix.