Dark and Light Profile Icons

This commit adds the ability to swap between dark and light icons for a profile, this is a additive change so you can either keep using the string icon or you can now swap to a object form in which you specify a light property for light theme and dark for dark theme

Author: Techypanda

src/cascadia/TerminalApp/IPaneContent.idl

@@ -36,6 +36,7 @@ namespace TerminalApp
 
         void Focus(Windows.UI.Xaml.FocusState reason);
 
+        void IconRefresh();
         void Close();
 
         event Windows.Foundation.TypedEventHandler<IPaneContent, Object> CloseRequested;

src/cascadia/TerminalApp/MarkdownPaneContent.cpp

@@ -183,6 +183,11 @@ namespace winrt::TerminalApp::implementation
         return *this;
     }
 
+    // Does nothing as Icon doesn't need to be refreshed for MarkdownPaneContent
+    void MarkdownPaneContent::IconRefresh() noexcept
+    {
+    }
+
     void MarkdownPaneContent::Close()
     {
         CloseRequested.raise(*this, nullptr);

src/cascadia/TerminalApp/MarkdownPaneContent.h

@@ -37,6 +37,7 @@ namespace winrt::TerminalApp::implementation
         uint64_t TaskbarProgress() { return 0; }
         bool ReadOnly() { return false; }
         winrt::hstring Icon() const;
+        void IconRefresh() noexcept;
         Windows::Foundation::IReference<winrt::Windows::UI::Color> TabColor() const noexcept { return nullptr; }
         winrt::Windows::UI::Xaml::Media::Brush BackgroundBrush() { return Background(); }
 

src/cascadia/TerminalApp/ScratchpadContent.cpp

@@ -53,6 +53,11 @@ namespace winrt::TerminalApp::implementation
         return BaseContentArgs(L"scratchpad");
     }
 
+    // No refresh has to occur for ScratchpadContent so no implementation
+    void ScratchpadContent::IconRefresh() noexcept
+    {
+    }
+
     winrt::hstring ScratchpadContent::Icon() const
     {
         static constexpr std::wstring_view glyph{ L"\xe70b" }; // QuickNote

src/cascadia/TerminalApp/ScratchpadContent.h

@@ -27,6 +27,7 @@ namespace winrt::TerminalApp::implementation
         uint64_t TaskbarProgress() { return 0; }
         bool ReadOnly() { return false; }
         winrt::hstring Icon() const;
+        void IconRefresh() noexcept;
         Windows::Foundation::IReference<winrt::Windows::UI::Color> TabColor() const noexcept { return nullptr; }
         winrt::Windows::UI::Xaml::Media::Brush BackgroundBrush();
 

src/cascadia/TerminalApp/SettingsPaneContent.cpp

@@ -61,6 +61,11 @@ namespace winrt::TerminalApp::implementation
         return winrt::hstring{ glyph };
     }
 
+    // No need to perform an icon refresh here
+    void SettingsPaneContent::IconRefresh() noexcept
+    {
+    }
+
     Windows::Foundation::IReference<winrt::Windows::UI::Color> SettingsPaneContent::TabColor() const noexcept
     {
         return nullptr;

src/cascadia/TerminalApp/SettingsPaneContent.h

@@ -28,6 +28,7 @@ namespace winrt::TerminalApp::implementation
         uint64_t TaskbarProgress() { return 0; }
         bool ReadOnly() { return false; }
         winrt::hstring Icon() const;
+        void IconRefresh() noexcept;
         Windows::Foundation::IReference<winrt::Windows::UI::Color> TabColor() const noexcept;
         winrt::Windows::UI::Xaml::Media::Brush BackgroundBrush();
 

src/cascadia/TerminalApp/SnippetsPaneContent.cpp

@@ -108,6 +108,11 @@ namespace winrt::TerminalApp::implementation
         return winrt::hstring{ glyph };
     }
 
+    // No need to perform an icon refresh
+    void SnippetsPaneContent::IconRefresh() noexcept
+    {
+    }
+
     winrt::WUX::Media::Brush SnippetsPaneContent::BackgroundBrush()
     {
         static const auto key = winrt::box_value(L"SettingsUiTabBrush");

src/cascadia/TerminalApp/SnippetsPaneContent.h

@@ -29,6 +29,7 @@ namespace winrt::TerminalApp::implementation
         uint64_t TaskbarProgress() { return 0; }
         bool ReadOnly() { return false; }
         winrt::hstring Icon() const;
+        void IconRefresh() noexcept;
         Windows::Foundation::IReference<winrt::Windows::UI::Color> TabColor() const noexcept { return nullptr; }
         winrt::Windows::UI::Xaml::Media::Brush BackgroundBrush();
 

src/cascadia/TerminalApp/TabManagement.cpp

@@ -222,10 +222,15 @@ namespace winrt::TerminalApp::implementation
     //   tab's icon to that icon.
     // Arguments:
     // - tab: the Tab to update the title for.
-    void TerminalPage::_UpdateTabIcon(TerminalTab& tab)
+    // - isRefresh: Specified when the Icon is due to refresh due to a update e.g. Windows Theme Color Change, defaults to false
+    void TerminalPage::_UpdateTabIcon(TerminalTab& tab, bool isRefresh)
     {
         if (const auto content{ tab.GetActiveContent() })
         {
+            if (isRefresh)
+            {
+                content.IconRefresh();
+            }
             const auto& icon{ content.Icon() };
             const auto theme = _settings.GlobalSettings().CurrentTheme();
             const auto iconStyle = (theme && theme.Tab()) ? theme.Tab().IconStyle() : IconStyle::Default;