[Bug]: Add Connection Maximum call stack size exceeded

[aalbrighti2p]

Description

When attempting to add a connection to the mssql extension, I am receiving a "Maximum call stack size exceeded" error and the form inputs are missing in the Connection Dialog tab.

VSCode.mssql.Maximum.Call.Stack.Exceeded.mp4

Steps to Reproduce

1. I created connection groups as seen in video above.
2. A drag and dropped my connections into the groups.
3. I attempted to reorder the groups by drag and dropping the SANDBOX connection group between DEV and ETL.
4. This made the SANDBOX connection group disappear.
5. So I recreated the SANDBOX connection group.
6. Then tried to add connection to recreate the ones that were lost.
7. This is when I noticed the "Maximum call stack size exceeded" error.
8. I did not however attempt to add a connection before creating the connection groups, so I am unsure if the error began after that or not.

Affected Area

• Connection dialog
• Query results panel
• Query editor
• Object Explorer
• Table Designer
• Schema Compare
• Schema Designer
• Local container
• GitHub Copilot integration
• Query Plan Visualizer
• Other (please describe below)

If you selected "Other", please describe the affected area

No response

Environment Information

SQL Server (mssql) Extension Version: 1.33.0

VSCode Version

Version: 1.101.1 (system setup)
Commit: 18e3a1ec544e6907be1e944a94c496e302073435
Date: 2025-06-18T13:35:12.605Z
Electron: 35.5.1
ElectronBuildId: 11727614
Chromium: 134.0.6998.205
Node.js: 22.15.1
V8: 13.4.114.21-electron.0
OS: Windows_NT x64 10.0.22631

Confirmation

• I have searched existing issues and couldn't find a match
• I want to work on this issue

[AlessioCarminati]

I happened to encounter the same issue as well.

As a workaround, you can open the settings.json file by launching the Command Palette and selecting "Open User Settings (JSON)". Then, look for the mssql.connectionGroups array and manually remove any duplicate groups. This resolved the issue for me.

[Benjin]

@aalbrighti2p how did you create these connection groups? When you followed @AlessioCarminati's suggestion to remove duplicate groups, what was duplicated about them? Sharing the problematic mssql.connectionGroups JSON (before you removed the duplicate groups) would be helpful here.

Also:

I attempted to reorder the groups by drag and dropping the SANDBOX connection group between DEV and ETL.

We don't currently support reordering of groups or connections; they'll be displayed in alphabetical order, so you can use a numeric prefix (1. DEV, 2. Sandbox, etc) to force that currently.

[aalbrighti2p]

@aalbrighti2p how did you create these connection groups?

I clicked the "Add Connection Group" button on the "CONNECTIONS" section header of the Sql Server pane

When you followed @AlessioCarminati's suggestion to remove duplicate groups, what was duplicated about them? Sharing the problematic mssql.connectionGroups JSON (before you removed the duplicate groups) would be helpful here.

I don't have what it was before I fixed it unfortunately, but i do know they were identical in name and color, but different id. I'm unsure if they had the same parentId, or if the bad group's parentId was the id of another group (since i dragged it onto another group when attempting to sort them that would make sense).

Also:

I attempted to reorder the groups by drag and dropping the SANDBOX connection group between DEV and ETL.

We don't currently support reordering of groups or connections; they'll be displayed in alphabetical order, so you can use a numeric prefix (1. DEV, 2. Sandbox, etc) to force that currently.

Makes perfect sense, and exactly what I did instead. Was just experimenting with the drag and dropping.

Lastly, any attempts to recreate the bug are not working. Seems it is correctly nesting connection groups when i drag one onto another. Still on v1.33.0 of Sql Server extension, but am now on VSCode v1.101.2.