Apply must_use to the bindgen function (#3605)

kennykerr · web-flow · commit bb15076311bf · 2025-05-19T12:55:13.000-05:00
diff --git a/crates/libs/bindgen/src/lib.rs b/crates/libs/bindgen/src/lib.rs
@@ -54,6 +54,7 @@ use method_names::*;
 
 /// The Windows code generator.
 #[track_caller]
+#[must_use]
 pub fn bindgen<I, S>(args: I) -> Warnings
 where
     I: IntoIterator<Item = S>,
diff --git a/crates/samples/components/json_validator_winrt/build.rs b/crates/samples/components/json_validator_winrt/build.rs
@@ -31,5 +31,6 @@ fn main() {
         "Sample",
         "--flat",
         "--implement",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/samples/components/json_validator_winrt_client/build.rs b/crates/samples/components/json_validator_winrt_client/build.rs
@@ -8,5 +8,6 @@ fn main() {
         "--filter",
         "Sample",
         "--flat",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/misc/component/build.rs b/crates/tests/misc/component/build.rs
@@ -33,5 +33,6 @@ fn main() {
         "--no-comment",
         "--reference",
         "windows",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/misc/component_client/build.rs b/crates/tests/misc/component_client/build.rs
@@ -11,5 +11,6 @@ fn main() {
         "--flat",
         "--reference",
         "windows",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/winrt/collection_interop/build.rs b/crates/tests/winrt/collection_interop/build.rs
@@ -40,7 +40,8 @@ fn main() {
         "--no-comment",
         "--reference",
         "windows_collections,flat,Windows",
-    ]);
+    ])
+    .unwrap();
 
     let include = std::env::var("OUT_DIR").unwrap();
 
diff --git a/crates/tests/winrt/composable/build.rs b/crates/tests/winrt/composable/build.rs
@@ -29,5 +29,6 @@ fn main() {
         "--implement",
         "--no-comment",
         "--flat",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/winrt/composable_client/build.rs b/crates/tests/winrt/composable_client/build.rs
@@ -16,7 +16,8 @@ fn main() {
         "test_composable",
         "--no-comment",
         "--flat",
-    ]);
+    ])
+    .unwrap();
 
     let include = std::env::var("OUT_DIR").unwrap();
 
diff --git a/crates/tests/winrt/constructors/build.rs b/crates/tests/winrt/constructors/build.rs
@@ -29,5 +29,6 @@ fn main() {
         "--implement",
         "--no-comment",
         "--flat",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/winrt/constructors_client/build.rs b/crates/tests/winrt/constructors_client/build.rs
@@ -16,7 +16,8 @@ fn main() {
         "test_constructors",
         "--no-comment",
         "--flat",
-    ]);
+    ])
+    .unwrap();
 
     let include = std::env::var("OUT_DIR").unwrap();
 
diff --git a/crates/tests/winrt/events/build.rs b/crates/tests/winrt/events/build.rs
@@ -33,5 +33,6 @@ fn main() {
         "--flat",
         "--reference",
         "windows",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/winrt/events_client/build.rs b/crates/tests/winrt/events_client/build.rs
@@ -13,5 +13,6 @@ fn main() {
         "--flat",
         "--reference",
         "windows",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/winrt/noexcept/build.rs b/crates/tests/winrt/noexcept/build.rs
@@ -38,7 +38,8 @@ fn main() {
         "--implement",
         "--flat",
         "--no-comment",
-    ]);
+    ])
+    .unwrap();
 
     let include = std::env::var("OUT_DIR").unwrap();
 
diff --git a/crates/tests/winrt/overloads/build.rs b/crates/tests/winrt/overloads/build.rs
@@ -29,5 +29,6 @@ fn main() {
         "--implement",
         "--no-comment",
         "--flat",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/winrt/overloads_client/build.rs b/crates/tests/winrt/overloads_client/build.rs
@@ -9,5 +9,6 @@ fn main() {
         "test_overloads",
         "--no-comment",
         "--flat",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/winrt/ref_params/build.rs b/crates/tests/winrt/ref_params/build.rs
@@ -38,7 +38,8 @@ fn main() {
         "--implement",
         "--flat",
         "--no-comment",
-    ]);
+    ])
+    .unwrap();
 
     let include = std::env::var("OUT_DIR").unwrap();
 
diff --git a/crates/tests/winrt/reference/build.rs b/crates/tests/winrt/reference/build.rs
@@ -31,5 +31,6 @@ fn main() {
         "--flat",
         "--reference",
         "windows",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/winrt/reference_client/build.rs b/crates/tests/winrt/reference_client/build.rs
@@ -11,5 +11,6 @@ fn main() {
         "--flat",
         "--reference",
         "windows",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/winrt/reference_custom/build.rs b/crates/tests/winrt/reference_custom/build.rs
@@ -20,7 +20,7 @@ fn main() {
         panic!("Failed to run midlrt");
     }
 
-    windows_bindgen::bindgen([
+    _ = windows_bindgen::bindgen([
         "--in",
         "default",
         "test.winmd",
diff --git a/crates/tests/winrt/reference_float/build.rs b/crates/tests/winrt/reference_float/build.rs
@@ -18,7 +18,7 @@ fn main() {
         panic!("Failed to run midlrt");
     }
 
-    windows_bindgen::bindgen([
+    _ = windows_bindgen::bindgen([
         "--in",
         "metadata.winmd",
         "../../../libs/bindgen/default",
diff --git a/crates/tests/winrt/reference_no_deps/build.rs b/crates/tests/winrt/reference_no_deps/build.rs
@@ -20,7 +20,7 @@ fn main() {
         panic!("Failed to run midlrt");
     }
 
-    windows_bindgen::bindgen([
+    _ = windows_bindgen::bindgen([
         "--in",
         "default",
         "test.winmd",
diff --git a/crates/tests/winrt/reference_no_windows/build.rs b/crates/tests/winrt/reference_no_windows/build.rs
@@ -32,5 +32,6 @@ fn main() {
         "--implement",
         "--flat",
         "--no-comment",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tests/winrt/reference_windows/build.rs b/crates/tests/winrt/reference_windows/build.rs
@@ -33,5 +33,6 @@ fn main() {
         "--no-comment",
         "--reference",
         "windows",
-    ]);
+    ])
+    .unwrap();
 }
diff --git a/crates/tools/bindgen/src/main.rs b/crates/tools/bindgen/src/main.rs
@@ -6,11 +6,11 @@ use windows_bindgen::bindgen;
 fn test(args: &str) {
     let mut expand = vec!["--no-comment", "--in", "default", "--flat"];
     expand.extend(args.split_whitespace());
-    bindgen(expand);
+    _ = bindgen(expand);
 }
 
 fn test_raw(args: &str) {
-    bindgen(args.split_whitespace());
+    _ = bindgen(args.split_whitespace());
 }
 
 fn main() {
diff --git a/crates/tools/bindings/src/main.rs b/crates/tools/bindings/src/main.rs
@@ -17,8 +17,8 @@ fn main() {
     bindgen(["--etc", "crates/tools/bindings/src/threading.txt"]).unwrap();
     bindgen(["--etc", "crates/tools/bindings/src/services.txt"]).unwrap();
 
-    bindgen(["--etc", "crates/tools/bindings/src/sys.txt"]);
-    bindgen(["--etc", "crates/tools/bindings/src/windows.txt"]);
+    _ = bindgen(["--etc", "crates/tools/bindings/src/sys.txt"]);
+    _ = bindgen(["--etc", "crates/tools/bindings/src/windows.txt"]);
 
     println!("Finished in {:.2}s", time.elapsed().as_secs_f32());
 }
diff --git a/crates/tools/standalone/src/main.rs b/crates/tools/standalone/src/main.rs
@@ -228,7 +228,7 @@ fn write_win(output: &Path, filter: &[&str]) {
     args.extend_from_slice(&["--no-comment"]);
     args.extend_from_slice(&["--flat"]);
     println!("running: bindgen {}", args.join(" "));
-    windows_bindgen::bindgen(args);
+    _ = windows_bindgen::bindgen(args);
 }
 
 fn write_no_inner_attr(output: &Path, filter: &[&str]) {
@@ -246,5 +246,5 @@ fn bindgen(output: &Path, filter: &[&str], config: &[&str]) {
     args.extend_from_slice(&["--no-comment"]);
     args.extend_from_slice(config);
     println!("running: bindgen {}", args.join(" "));
-    windows_bindgen::bindgen(args);
+    _ = windows_bindgen::bindgen(args);
 }

Original file line number	Diff line number	Diff line change
`@@ -31,5 +31,6 @@ fn main() {`
`31`	`31`	`"Sample",`
`32`	`32`	`"--flat",`
`33`	`33`	`"--implement",`
`34`		`- ]);`
	`34`	`+ ])`
	`35`	`+ .unwrap();`
`35`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,5 +8,6 @@ fn main() {`
`8`	`8`	`"--filter",`
`9`	`9`	`"Sample",`
`10`	`10`	`"--flat",`
`11`		`- ]);`
	`11`	`+ ])`
	`12`	`+ .unwrap();`
`12`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,5 +33,6 @@ fn main() {`
`33`	`33`	`"--no-comment",`
`34`	`34`	`"--reference",`
`35`	`35`	`"windows",`
`36`		`- ]);`
	`36`	`+ ])`
	`37`	`+ .unwrap();`
`37`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,6 @@ fn main() {`
`11`	`11`	`"--flat",`
`12`	`12`	`"--reference",`
`13`	`13`	`"windows",`
`14`		`- ]);`
	`14`	`+ ])`
	`15`	`+ .unwrap();`
`15`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,5 +29,6 @@ fn main() {`
`29`	`29`	`"--implement",`
`30`	`30`	`"--no-comment",`
`31`	`31`	`"--flat",`
`32`		`- ]);`
	`32`	`+ ])`
	`33`	`+ .unwrap();`
`33`	`34`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,6 @@ fn main() {`
`13`	`13`	`"--flat",`
`14`	`14`	`"--reference",`
`15`	`15`	`"windows",`
`16`		`- ]);`
	`16`	`+ ])`
	`17`	`+ .unwrap();`
`17`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,5 +9,6 @@ fn main() {`
`9`	`9`	`"test_overloads",`
`10`	`10`	`"--no-comment",`
`11`	`11`	`"--flat",`
`12`		`- ]);`
	`12`	`+ ])`
	`13`	`+ .unwrap();`
`13`	`14`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ fn main() {`
`20`	`20`	`panic!("Failed to run midlrt");`
`21`	`21`	`}`
`22`	`22`
`23`		`- windows_bindgen::bindgen([`
	`23`	`+ _ = windows_bindgen::bindgen([`
`24`	`24`	`"--in",`
`25`	`25`	`"default",`
`26`	`26`	`"test.winmd",`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ fn main() {`
`18`	`18`	`panic!("Failed to run midlrt");`
`19`	`19`	`}`
`20`	`20`
`21`		`- windows_bindgen::bindgen([`
	`21`	`+ _ = windows_bindgen::bindgen([`
`22`	`22`	`"--in",`
`23`	`23`	`"metadata.winmd",`
`24`	`24`	`"../../../libs/bindgen/default",`
Original file line number	Diff line number	Diff line change
`@@ -32,5 +32,6 @@ fn main() {`
`32`	`32`	`"--implement",`
`33`	`33`	`"--flat",`
`34`	`34`	`"--no-comment",`
`35`		`- ]);`
	`35`	`+ ])`
	`36`	`+ .unwrap();`
`36`	`37`	`}`