From 438603c847bddfb621e65bc859eb5d3f3881c950 Mon Sep 17 00:00:00 2001 From: trentaml Date: Thu, 12 Mar 2020 22:35:11 -0400 Subject: [PATCH] My Code Review suggestions --- .../InstrumentedTest.kt} | 5 ++--- app/src/main/AndroidManifest.xml | 4 ++-- .../example/{party_player => partyPlayer}/MainActivity.kt | 2 +- .../ExampleUnitTest.kt => partyPlayer/UnitTest.kt} | 5 ++--- 4 files changed, 7 insertions(+), 9 deletions(-) rename app/src/androidTest/java/com/example/{party_player/ExampleInstrumentedTest.kt => partyPlayer/InstrumentedTest.kt} (89%) rename app/src/main/java/com/example/{party_player => partyPlayer}/MainActivity.kt (89%) rename app/src/test/java/com/example/{party_player/ExampleUnitTest.kt => partyPlayer/UnitTest.kt} (82%) diff --git a/app/src/androidTest/java/com/example/party_player/ExampleInstrumentedTest.kt b/app/src/androidTest/java/com/example/partyPlayer/InstrumentedTest.kt similarity index 89% rename from app/src/androidTest/java/com/example/party_player/ExampleInstrumentedTest.kt rename to app/src/androidTest/java/com/example/partyPlayer/InstrumentedTest.kt index 37182ee..ff906f9 100644 --- a/app/src/androidTest/java/com/example/party_player/ExampleInstrumentedTest.kt +++ b/app/src/androidTest/java/com/example/partyPlayer/InstrumentedTest.kt @@ -1,4 +1,4 @@ -package com.example.party_player +package com.example.partyPlayer import androidx.test.platform.app.InstrumentationRegistry import androidx.test.ext.junit.runners.AndroidJUnit4 @@ -10,11 +10,10 @@ import org.junit.Assert.* /** * Instrumented test, which will execute on an Android device. - * * See [testing documentation](http://d.android.com/tools/testing). */ @RunWith(AndroidJUnit4::class) -class ExampleInstrumentedTest { +class InstrumentedTest { @Test fun useAppContext() { // Context of the app under test. diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 1075677..7ec66e6 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -1,6 +1,6 @@ + package="com.example.partyPlayer"> - + diff --git a/app/src/main/java/com/example/party_player/MainActivity.kt b/app/src/main/java/com/example/partyPlayer/MainActivity.kt similarity index 89% rename from app/src/main/java/com/example/party_player/MainActivity.kt rename to app/src/main/java/com/example/partyPlayer/MainActivity.kt index 6f19c57..33b3fd0 100644 --- a/app/src/main/java/com/example/party_player/MainActivity.kt +++ b/app/src/main/java/com/example/partyPlayer/MainActivity.kt @@ -1,4 +1,4 @@ -package com.example.party_player +package com.example.partyPlayer import androidx.appcompat.app.AppCompatActivity import android.os.Bundle diff --git a/app/src/test/java/com/example/party_player/ExampleUnitTest.kt b/app/src/test/java/com/example/partyPlayer/UnitTest.kt similarity index 82% rename from app/src/test/java/com/example/party_player/ExampleUnitTest.kt rename to app/src/test/java/com/example/partyPlayer/UnitTest.kt index e7fa476..0e2747e 100644 --- a/app/src/test/java/com/example/party_player/ExampleUnitTest.kt +++ b/app/src/test/java/com/example/partyPlayer/UnitTest.kt @@ -1,4 +1,4 @@ -package com.example.party_player +package com.example.partyPlayer import org.junit.Test @@ -6,10 +6,9 @@ import org.junit.Assert.* /** * Example local unit test, which will execute on the development machine (host). - * * See [testing documentation](http://d.android.com/tools/testing). */ -class ExampleUnitTest { +class UnitTest { @Test fun addition_isCorrect() { assertEquals(4, 2 + 2)