The incorrect item is deleted from a slice after using add, flatten, sort, reverse or shuffle operators on a sequence.

[antoinedeschenes]

Describe the bug

The incorrect item is deleted from a slice after using add, flatten, sort, reverse or shuffle operators on a sequence.

Version of yq: 4.45.4, problem started with 4.40.1
Operating system: mac
Installed via:binary release

Input

data1.xml:

<items>
  <foo>
    <id>1</id>
  </foo>
</items>

data2.yml:

items:
  foo:
    id: 1

Command
The command you ran:

yq '.items.foo |= ([] + .) | del(.items.foo[] | select(.id==1))' data1.xml
yq '.items.foo |= ([] + .) | del(.items.foo[] | select(.id==1))' data2.yml

Actual behavior
for data1.xml

<items>
  <foo>
    <id>1</id>
  </foo>
</items>

for data2.yml

items:
  foo:
    - id: 1

Expected behavior

for data1.xml

<items></items>

for data2.yml

items:
  foo: []

Additional context

If I run the command with yq -v, I notice the node's path is printed as Pfoo.foo rather than Pfoo[0].

I've been looking at the code around addSequence and it looks like slice elements from the RHS aren't getting the index key assigned since the CandidateNode alerady had a Key set.

[nvanheuverzwijn]

This is a regression, this work with my yq version (4.22.1)

[antoinedeschenes]

After more investigation, here are a few other cases where we found issues. v4.35.2 behaves as expected:

+ ./yq4.35.2 -n '.foo = ["lhs"] + ["rhs"] | del(.foo[1])'
foo:
  - lhs
+ ./yq4.45.4 -n '.foo = ["lhs"] + ["rhs"] | del(.foo[1])'
foo:
  - rhs
+ ./yq4.35.2 -n '[3,2,1] | sort | del(.[2])'
- 1
- 2
+ ./yq4.45.4 -n '[3,2,1] | sort | del(.[2])'
- 2
- 3
+ ./yq4.35.2 -n '[3,[2],[[1]]] | flatten | del(.[2])'
- 3
- 2
+ ./yq4.45.4 -n '[3,[2],[[1]]] | flatten | del(.[2])'
- 2
- 1
+ ./yq4.35.2 -n '[3,2,1] | reverse | del(.[2])'
- 1
- 2
+ ./yq4.45.4 -n '[3,2,1] | reverse | del(.[2])'
- 2
- 3